hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Mar 2023
8:58 am

James Walter Taylor <jtaylor@diality.com>

HD-DEN-15016_System Faults During Treatment Then Returns TO The Standby Screen

Closing code review comments.

Options
    • -2
    • +2
    ./Services/SystemComm.c
8:55 am

Michael Garthwaite

8:55 am

jtaylor  (deleted user)

I saw the corresponding alarm 44, on the initial power-up. However, going back to the UI log file shows UI communication within 1 second of triggering the error. So either the received message was ...

I saw the corresponding alarm 44, on the initial power-up. However, going back to the UI log file shows UI communication within 1 second of triggering the error. So either the received message was that much delayed, or the check is otherwise broken.

8:49 am

jtaylor  (deleted user)

Done.

Done.

8:39 am

jtaylor  (deleted user)

Done.

Done.

Thursday 30 Mar 2023
9:19 pm

Sean Nash

DEN-14999: Small fix to HD WD POST.

Options
    • -0
    • +5
    ./Services/WatchdogMgmt.c
8:49 pm

Sean Nash

DEN-14999: Removed BP and DPi flow range checks.

Options
    • -30
    • +1
    ./Controllers/BloodFlow.c
    • -17
    • +3
    ./Controllers/DialInFlow.c
8:19 pm

Sean Nash

DEN-14999: Removed redundant trigger for DG restarted alarm.

Options
    • -31
    • +0
    ./Modes/SampleWater.c
7:07 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
7:06 pm

Dara Navaei

Merge branch 'DEN-14999-alarm-table-updates' into develop

Options
    • -1
    • +1
    ./Controllers/PresOccl.c
    • -1
    • +11
    ./Services/SystemCommMessages.c
7:06 pm

Dara Navaei

DEN-14999, DEN-15030 fixed the start DG command to only get the acid and bicarb parameters if the HD is sending a start command

Options
    • -3
    • +9
    ./Services/SystemCommMessages.c
7:00 pm

Sean Nash

My branch (and your DG branch) changed this to 10.

My branch (and your DG branch) changed this to 10.

7:00 pm

Sean Nash

Do you have data showing UI disappeared for > 5 seconds? Is this necessary?

Do you have data showing UI disappeared for > 5 seconds? Is this necessary?

6:59 pm

Sean Nash

Change back to 200.

Change back to 200.

5:28 pm

Sean Nash

Merge branch 'DEN-14999-alarm-table-updates' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-14999-alarm-table-updates

Options
    • -2
    • +4
    ./Services/SystemCommMessages.c
5:28 pm

Sean Nash

DEN-14999: Fixed sending of DG valve settings command.

Options
    • -0
    • +2
    ./Services/SystemCommMessages.c
4:12 pm

Dara Navaei

DEN-14999, DEN-15030 updated the DG start command payload

Options
    • -2
    • +4
    ./Services/SystemCommMessages.c
4:11 pm

Sean Nash

DEN-14999: updates to pressure POST test and 24V range alarms.

Options
    • -1
    • +1
    ./Controllers/PresOccl.c
    • -11
    • +25
    ./Controllers/Voltages.c
2:22 pm

Sean Nash

12:23 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:33 am

Sean Nash

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to ...

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to candump and this was causing alarm 46. Until UI sorts this out, I am not going to check payload.

11:28 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
11:26 am

Darren Cox <darren_m@cox.net>

Merge DEN-14860 branch

Options
    • -10
    • +10
    ./Services/Reservoirs.c
10:18 am

Michael Garthwaite

What is the other flavor of UI check in message. If it is a different size, shouldn't it be its own separate message?

What is the other flavor of UI check in message. If it is a different size, shouldn't it be its own separate message?

9:47 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:44 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:41 am

Sean Nash

DEN-14999: Removed obsolete/redundant alarms. Addressed code review comment.

Options
    • -8
    • +1
    ./Modes/Rinseback.c
    • -31
    • +2
    ./Modes/TreatmentRecirc.c
    • -1
    • +1
    ./Services/SystemComm.c
9:40 am

Sean Nash

Warning (13 min) removed since no longer alarming at 15 min.

Warning (13 min) removed since no longer alarming at 15 min.

9:38 am

Sean Nash

Fixed.

Fixed.

Wednesday 29 Mar 2023
11:09 pm

Sean Nash

DEN-14999: on blood leak detection, alarm, but then go to init state to prevent re-trigger after alarm cleared.

Options
    • -0
    • +1
    ./Controllers/BloodLeak.c