hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 13 Apr 2023
5:03 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'DEN-15049-fw-hd-voltage-not-trigger-alarm-76-when-voltage-out-of-range-in-line' into develop

# Conflicts:

# firmware/App/HDCommon.h

Options
    • -1
    • +1
    ./HDCommon.h
3:12 pm

jtaylor  (deleted user) and Sean Nash

2:22 pm

wbracken  (deleted user)

They should remain. Will be uncommented when all DVT units have updated hardware.

They should remain. Will be uncommented when all DVT units have updated hardware.

2:17 pm

dcox  (deleted user)

Are these alarms intentionally commented? Should they be activated or removed?

Are these alarms intentionally commented? Should they be activated or removed?

2:05 pm

wbracken  (deleted user)

Update header, setUFVolStatus

Update header, setUFVolStatus

2:04 pm

wbracken  (deleted user)

Update header

Update header

2:03 pm

wbracken  (deleted user)

Update header.

Update header.

2:00 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
1:58 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:58 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:58 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:58 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

1:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:56 pm

Sean Nash

DEN-15105: Started adding pre-tx patient connection sub-states.

Options
    • -2
    • +4
    ./Modes/Dialysis.c
    • -1
    • +1
    ./Modes/ModeInitPOST.c
    • -4
    • +81
    ./Modes/ModePreTreat.c
    • -0
    • +1
    ./Services/AlarmMgmtSWFaults.h
1:53 pm

wbracken  (deleted user)

Corrected

Corrected

1:52 pm

wbracken  (deleted user)

Corrected

Corrected

1:52 pm

Sean Nash

Fixed.

Fixed.

1:51 pm

wbracken  (deleted user)

Corrected

Corrected

1:51 pm

wbracken  (deleted user)

Corrected

Corrected

1:50 pm

Sean Nash

Fixed.

Fixed.

1:48 pm

wbracken  (deleted user)

Removed

Removed

1:46 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15049 Code review changes to accomodate using CPLD for power loss detection

Options
    • -14
    • +3
    ./Controllers/Voltages.c
1:22 pm

Sean Nash

I think we can just say "if ( TRUE == hasPowerBeenLost )" here. Zero trigger persistence time now that CPLD is making determination.

I think we can just say "if ( TRUE == hasPowerBeenLost )" here. Zero trigger persistence time now that CPLD is making determination.

1:17 pm

Sean Nash

I think we can fit this whole comment on the 1 line. Bring closer to break; if need more room.

I think we can fit this whole comment on the 1 line. Bring closer to break; if need more room.

1:14 pm

Sean Nash

No longer needed?

No longer needed?

1:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:12 pm

Sean Nash

Remove this method of determine whether AC power has been lost. CPLD function above is what we want.

Remove this method of determine whether AC power has been lost. CPLD function above is what we want.

1:11 pm

wbracken  (deleted user)

Corrected

Corrected