hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 21 Apr 2023
2:59 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Additional Code review comments addressed.

Options
    • -12
    • +11
    ./Services/AlarmMgmt.c
2:16 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
2:16 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/PresOccl.c
    • -1
    • +1
    ./Drivers/InternalADC.c
    • -1
    • +1
    ./Modes/ModePreTreat.c
    • -1
    • +1
    ./Modes/ModeTreatment.c
    • -2
    • +2
    ./Modes/PreTreatmentRecirc.c
    • -1
    • +1
    ./Modes/Rinseback.c
    • -1
    • +1
    ./Modes/TreatmentRecirc.c
    • -1
    • +1
    ./Services/AlarmMgmt.c
    • -2
    • +2
    ./Tasks/TaskGeneral.c
2:06 pm

Sean Nash

1:51 pm

Dara Navaei

1:42 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:41 pm

Sean Nash

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

1:31 pm

Sean Nash

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

12:15 pm

dcox  (deleted user)

12:15 pm

jtaylor  (deleted user)

AlarmMgmt.h reverted. The timer moved to static AlarmMgnt local.

AlarmMgmt.h reverted. The timer moved to static AlarmMgnt local.

12:15 pm

James Walter Taylor <jtaylor@diality.com>

DEN-14980-unable-to-resume-after-hd-unit-plugged-back-in-pre-treatment-after-priming

Moved Alarms blocked timer variable, per review.

Options
    • -6
    • +7
    ./Services/AlarmMgmt.c
    • -1
    • +0
    ./Services/AlarmMgmt.h
11:43 am

Dana Rich <drich@sunriselabs.com>

Temp Modify HAL for debugging

Options
    • -5
    • +5
    ./Modes/Update.c
  2. … 5 more files in changeset.
11:43 am

Dana Rich <drich@sunriselabs.com>

Temp Modify HAL for debugging

Options
    • -5
    • +5
    ./Modes/Update.c
  2. … 5 more files in changeset.
11:43 am

Dana Rich <drich@sunriselabs.com>

DEN-16565 cherry picked Sunrise commit IDs from 36d3216f0b5fb36aa6a162941d3e0dcddca288a8 to 6061f0c406fafe19d8785355d69847aa71b5a30e by Dara Navaei

Options
    • -5
    • +5
    ./Modes/Update.c
  2. … 2 more files in changeset.
11:43 am

Dana Rich <drich@sunriselabs.com>

Temp Modify HAL for debugging

Options
    • -5
    • +5
    ./Modes/Update.c
  2. … 2 more files in changeset.
11:43 am

Dana Rich <drich@sunriselabs.com>

Temp Modify HAL for debugging

Options
    • -5
    • +5
    ./Modes/Update.c
  2. … 5 more files in changeset.
11:42 am

Sean Nash

Not needed. Remove.

Not needed. Remove.

11:15 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:14 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:08 am

Sean Nash

DEN-15183: Fixed compiler warning.

Options
    • -0
    • +1
    ./Services/AlarmMgmt.c
11:06 am

Sean Nash

DEN-15183: Addressed code review comments.

Options
    • -1
    • +0
    ./Modes/TreatmentRecirc.c
    • -2
    • +2
    ./Services/AlarmMgmt.c
11:06 am

Sean Nash

Fixed.

Fixed.

11:04 am

Sean Nash

Fixed.

Fixed.

10:56 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
10:54 am

Sean Nash

Merge branch 'DEN-15183-in-treatment-rinseback-workflow-changes' into develop

Options
    • -2
    • +10
    ./Controllers/PresOccl.c
10:23 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

9:43 am

Michael Garthwaite

DEN-15196: Reworked battery comm fault alarm to use timed window count.

Options
    • -16
    • +25
    ./Drivers/Battery.c
9:32 am

Sean Nash

DEN-15183: Fix for DEN-15198.

Options
    • -2
    • +10
    ./Controllers/PresOccl.c
9:18 am

Michael Garthwaite

DEN-15023: reworked syringe empty check to consider force and hw variance. Added t_par check for maximum heparin. renamed syringe occlusion and gave occlusion alarm persistence outside of priming

Options
    • -9
    • +39
    ./Controllers/SyringePump.c
    • -1
    • +4
    ./Controllers/SyringePump.h
    • -0
    • +11
    ./Modes/ModeTreatmentParams.c
    • -1
    • +1
    ./Modes/SelfTests.c
8:18 am

jtaylor  (deleted user)

Done.

Done.