Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done

Done

Done

Done

Done

Done

I changed the code.

I changed the code.

Done

Done

Done

Done

I was thinking to send the command anyways. If the active reservoir is what we need, it will be ignored. But I changed the code.

I was thinking to send the command anyways. If the active reservoir is what we need, it will be ignored. But I changed the code.

Done

Done

Done. This indentation was picked by Code Composer Studios though.

Done. This indentation was picked by Code Composer Studios though.

Done

Done

No longer needed.

No longer needed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Per my other comment, please avoid in-function static variables.

Per my other comment, please avoid in-function static variables.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Now it's gone. No longer needed?

Now it's gone. No longer needed?

Missing function header

Missing function header

Removed

Removed

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the...

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the enum but is the second 2nd group of 3 bits (0 relative) returned by the FPGA.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

Corrected

Corrected