hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 23 May 2023
11:20 am

Sean Nash

DEN-13865: More fixes to alarm re-trigger prevention logic.

Options
    • -2
    • +3
    ./Services/AlarmMgmt.c
11:09 am

Sean Nash

DEN-13865: fix re-trigger block logic.

Options
    • -20
    • +23
    ./Services/AlarmMgmt.c
11:08 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
10:57 am

Sean Nash

DEN-13865: Handle no re-trigger action or end-tx only alarms during rinseback/recirc states of treatment mode.

Options
    • -2
    • +9
    ./Modes/Rinseback.c
    • -3
    • +26
    ./Services/AlarmMgmt.c
    • -0
    • +1
    ./Services/AlarmMgmt.h
9:45 am

Sean Nash

Merge branch 'DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow' into develop

Options
    • -0
    • +1
    ./Controllers/SyringePump.c
    • -0
    • +1
    ./Modes/ModeStandby.c
9:42 am

Sean Nash

DEN-13865: Implemented alarm system feature to prevent alarm re-trigger per new properties. Addressed DEN-15295.

Options
    • -0
    • +1
    ./Controllers/SyringePump.c
    • -0
    • +1
    ./Modes/ModeStandby.c
    • -9
    • +32
    ./Services/AlarmMgmt.c
    • -0
    • +1
    ./Services/AlarmMgmt.h
8:52 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
8:49 am

Dara Navaei

DEN-15367 updated the use wet cartrdige test configuration

Options
    • -69
    • +84
    ./Modes/Prime.c
8:36 am

Sean Nash

So then can we remove power loss alarm active checks from this condition (just keep the cpld power loss check as before)?

So then can we remove power loss alarm active checks from this condition (just keep the cpld power loss check as before)?

8:35 am

Sean Nash

Do we need the alarm active checks? Isn't power loss check sufficient?

Do we need the alarm active checks? Isn't power loss check sufficient?

12:02 am

Dara Navaei

HD-DEN-13865_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
HD-DEN-13865_FW Duplicate Alarms Occur During Post Treatment Rinseback And Block Workflow
Monday 22 May 2023
11:18 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
11:16 pm

Sean Nash

Merge branch 'DEN-15250-pre-treatment-does-not-end-successfully' into develop

Options
    • -7
    • +7
    ./Services/SystemCommMessages.c
11:11 pm

Sean Nash

DEN-15250: cosmetic and coding standard changes.

Options
    • -29
    • +29
    ./Modes/OperationModes.c
    • -3
    • +3
    ./Modes/OperationModes.h
    • -7
    • +7
    ./Services/SystemCommMessages.c
5:35 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
5:33 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge remote-tracking branch 'origin/DEN-15363-fw-handle-bld-sensor-communication-errors' into develop

Options
    • -5
    • +12
    ./Controllers/BloodLeak.c
4:48 pm

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15363 Reuse alarm ID 63 for Blood Leak communications errors

Options
    • -6
    • +1
    ./Controllers/BloodLeak.c
1:40 pm

Michael Garthwaite

11:59 am

jtaylor  (deleted user)

The root cause is that abnormal AC power loss on the HD causes abnormal operating conditions and spurious errors. The valves return to position after the alarm is cleared, not when AC returns. The ...

The root cause is that abnormal AC power loss on the HD causes abnormal operating conditions and spurious errors. The valves return to position after the alarm is cleared, not when AC returns. The timer gives a ten-second window following removing the power fail signal and the alarm condition, where the alarm block is active. The original block used the alarms alone, we changed to the CPLD power loss detection - which returns with the return of AC. Clearing the alarms late means removing the block before the valves return to normal operation.

I think there are two approaches. We already have distributed failsafe that is entered on power fail, which we recover from after the alarm is cleared.
1. Create a pervasive state that affects every operating mode, allowing transitions to "safe" states during alarms, then back to the original operating state. The safe state would not register errors until after the transition back to normal operation.
2. Block errors until both AC is returned and the alarm is cleared when normal operation is restored.

The second approach is much simpler and addresses the root problem: odd control configurations resulting from having alarms with conflicting controls. In this case, the secondary alarms are spurious since they result from the valves dropping into a safe position, for instance, on the loss of AC. We also have a handful of other errors that occur under these conditions, fan speed, for instance, as well as valve positions,

11:57 am

jtaylor  (deleted user)

Added alarm 62 detection disable as suggested.

Added alarm 62 detection disable as suggested.

10:02 am

Dara Navaei

HD-DEN-15396_2 Alarm 42 HD Fault Dpo Rotor Encountered IN Blood Prime Dvt 00
HD-DEN-15396_2 Alarm 42 HD Fault Dpo Rotor Encountered IN Blood Prime Dvt 00
9:45 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
9:44 am

Sean Nash

Fixed merge conflict.

Options
    • -2
    • +3
    ./Controllers/Temperatures.c
    • -2
    • +3
    ./Drivers/Battery.c
    • -1
    • +3
    ./Services/SystemCommMessages.c
    • -1
    • +3
    ./Services/SystemCommMessages.h
9:42 am

Sean Nash

Fixed merge conflict.

Options
    • -1
    • +1
    ./Services/SystemCommMessages.c
9:40 am

Sean Nash

DEN-15250: Addressed DEN-15308.

Options
    • -0
    • +8
    ./Modes/ModeTreatmentParams.c
9:01 am

Sean Nash

DEN-15396-2: Fixed rotor speed chk persistence function to handle negative motor speeds.

Options
    • -2
    • +3
    ./Controllers/DialInFlow.c
8:38 am

Sean Nash

DEN-15250: End tx should go to post-tx from pre-tx unless haven't finished water sample state. Require ack on confirmation msgs.

Options
    • -7
    • +4
    ./Modes/ModePreTreat.c
    • -1
    • +1
    ./Services/SystemCommMessages.c
Sunday 21 May 2023
2:44 pm

Dara Navaei

2:18 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
2:18 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/DialInFlow.c
    • -2
    • +2
    ./Controllers/DialOutFlow.c
    • -1
    • +1
    ./Controllers/Temperatures.c