Activity hdfirmware/firmware/App

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	10 Jun
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 30 May 2023

4:32 pm

Dara Navaei

More
91f5e1f
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 218 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./Controllers/DialInFlow.c
- History
- Source
- Diff
./Controllers/DialInFlow.c

4:28 pm

Dara Navaei

More
8e908d2
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
./HDCommon.h
- History
- Source
- Diff
./HDCommon.h

4:26 pm

James Walter Taylor <jtaylor@diality.com>

More
e6294e1
changed 1 file
develop HD-DEN-15306-2

DEN-15306-hd-fault-valve-position-alarm-after-restoring-ac-power

Aligned tests.

- -1
- +1
./Services/AlarmMgmt.c
- History
- Source
- Diff
./Services/AlarmMgmt.c

4:21 pm

Dara Navaei

More
bacc3db
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 218 more

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
./HDCommon.h
- History
- Source
- Diff
./HDCommon.h

4:21 pm

Dara Navaei

More
6178c7d
changed 1 file
DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 218 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./Modes/SelfTests.c
- History
- Source
- Diff
./Modes/SelfTests.c

4:20 pm

James Walter Taylor <jtaylor@diality.com>

More
335c721
changed 8 files
develop HD-DEN-15306-2

DEN-15306-hd-fault-valve-position-alarm-after-restoring-ac-power

Made the power loss check uniform

isACPowerLoss is an alarm status, move to AlarmMgmt

Trigger with CPLD power loss flag, recover HW state when AC returns, start alarm block countdown after alarm is cleared.

- -2
- +2
./Controllers/DGInterface.c
- History
- Source
- Diff
./Controllers/DGInterface.c
- -1
- +1
./Controllers/DialInFlow.c
- History
- Source
- Diff
./Controllers/DialInFlow.c
- -1
- +1
./Controllers/Fans.c
- History
- Source
- Diff
./Controllers/Fans.c
- -18
- +25
./Controllers/Valves.c
- History
- Source
- Diff
./Controllers/Valves.c
- -21
- +0
./Drivers/Battery.c
- History
- Source
- Diff
./Drivers/Battery.c
- -1
- +0
./Drivers/Battery.h
- History
- Source
- Diff
./Drivers/Battery.h
- -6
- +33
./Services/AlarmMgmt.c
- History
- Source
- Diff
./Services/AlarmMgmt.c
- -0
- +1
./Services/AlarmMgmt.h
- History
- Source
- Diff
./Services/AlarmMgmt.h

4:20 pm

dcox (deleted user)

More
HD-DEN-15113-1
Closed

3:18 pm

wbracken (deleted user)

More
Re: HD-DEN-15359-1
commented on review

Add stabilizationStartTimeMs to header.

Add stabilizationStartTimeMs to header.

1:25 pm

Sean Nash

More
3dee3fb
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 217 more HD-DEN-15359-1

DEN-15359: handle blood flow rate change in middle of stabilization state.

- -2
- +10
./Controllers/PresOccl.c
- History
- Source
- Diff
./Controllers/PresOccl.c

11:29 am

wbracken (deleted user)

More
Re: HD-DEN-15359-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

11:29 am

wbracken (deleted user)

More
Re: HD-DEN-15359-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

8:17 am

Sean Nash

Can't keep in message x47 as f/w will not have calculated new min/max yet. I made it so message x9 will broadcast immediately after user changes pressure limit windows.

Can't keep in message x47 as f/w will not have calculated new min/max yet.
I made it so message x9 will broadcast immediately after user changes pressure limit windows.

8:15 am

Sean Nash

More
1e55c23
changed 1 file
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 217 more HD-DEN-15359-1

DEN-15359: broadcast pressure data immediately after window change by user.

- -0
- +3
./Controllers/PresOccl.c
- History
- Source
- Diff
./Controllers/PresOccl.c

1:43 am

Behrouz NematiPour

More
Re: HD-DEN-15359-1
commented on review

Seems the only message which is providing the calculated A/V min/max is here in message 0x09. I think it was better to keep the min, max of the arterial and venous in the message 0x47 (A/V InTx adj...

Seems the only message which is providing the calculated A/V min/max is here in message 0x09.
I think it was better to keep the min, max of the arterial and venous in the message 0x47 (A/V InTx adj) to let UI immediately have the updated values,
instead of the x09 which is a broadcast and won't immediately send the updated/calculated min/max, and causes a short delay (depending on interval of the broadcast) to update the UI.
Or in both if the message 0x09 is getting continuously updated during treatment.

12:42 am

Behrouz NematiPour

More
Re: HD-DEN-15359-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

12:42 am

Behrouz NematiPour

More
Re: HD-DEN-15359-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

12:41 am

Behrouz NematiPour

More
Re: HD-DEN-15359-1
replied to Sean Nash

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Monday 29 May 2023

10:45 pm

Sean Nash

More
Re: HD-DEN-13865-1
replied to jtaylor (deleted user)

Fixed.

Fixed.

10:42 pm

Sean Nash

More
911ce9c
changed 2 files
DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error, DEN-14706-can-messge-not-acked-fix and 217 more HD-DEN-15359-1

DEN-15359: Addressed code review comments.

- -2
- +4
./Controllers/PresOccl.c
- History
- Source
- Diff
./Controllers/PresOccl.c
- -0
- +3
./Modes/ModeTreatmentParams.c
- History
- Source
- Diff
./Modes/ModeTreatmentParams.c

10:38 pm

Sean Nash

Fixed.

Fixed.

10:38 pm

Sean Nash

Yes. Fixed.

Yes. Fixed.

10:36 pm

Sean Nash

Yes. Fixed.

Yes. Fixed.

10:34 pm

Sean Nash

More
Re: HD-DEN-15359-1
replied to wbracken (deleted user)

Fixed.

Fixed.

10:34 pm

Sean Nash

More
Re: HD-DEN-15359-1
replied to wbracken (deleted user)

Fixed.

Fixed.

8:05 pm

Behrouz NematiPour

More
Re: HD-DEN-15359-1
commented on review

same here?

same here?

8:05 pm

Behrouz NematiPour

More
Re: HD-DEN-15359-1
commented on review

Isn't the Venous Asymmetric missing?

Isn't the Venous Asymmetric missing?

5:41 pm

Behrouz NematiPour

More
Re: HD-DEN-15359-1
commented on review

don't you need to add the venous asymmetric here to be reset? Since I am going to give user an option to adjust it during treatment.

don't you need to add the venous asymmetric here to be reset?
Since I am going to give user an option to adjust it during treatment.

1:52 pm

Behrouz NematiPour

More
HD-DEN-15359-1
joined review

12:17 am

wbracken (deleted user)

More
Re: HD-DEN-15367-1
commented on review

Add signalTestConfigRsrvrMgmtUse, currentReservoirMgmtState

Add signalTestConfigRsrvrMgmtUse, currentReservoirMgmtState

12:16 am

wbracken (deleted user)

More
Re: HD-DEN-15367-1
commented on review

Update header. currentPreTreatmentState, signalTestConfigRsrvrMgmtUse

Update header. currentPreTreatmentState, signalTestConfigRsrvrMgmtUse

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-07-05 01:13 -0700