hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 02 Jun 2023
1:53 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
1:52 pm

jtaylor  (deleted user)

Done. Changed each instance to the negative form for consistency.

Done. Changed each instance to the negative form for consistency.

1:52 pm

jtaylor  (deleted user)

Done. Changed each instance to the negative form for consistency.

Done. Changed each instance to the negative form for consistency.

1:51 pm

jtaylor  (deleted user)

We appear to need a delay from AC's return to the first alarm check. We have natural times at CPLD, Alarm clear, and the end of the alarm block interval. The alarm block timer currently clears 10 s...

We appear to need a delay from AC's return to the first alarm check. We have natural times at CPLD, Alarm clear, and the end of the alarm block interval. The alarm block timer currently clears 10 seconds after CPLD; the alarm is clear at a random interval from milliseconds to minutes after CPLD.
I have modified the calls for consistent use of CPLD or of isACPowerLost.

1:49 pm

jtaylor  (deleted user)

Done. The countdown timer was renamed for clarity.

Done. The countdown timer was renamed for clarity.

1:49 pm

jtaylor  (deleted user)

Done.

Done.

1:48 pm

jtaylor  (deleted user)

Renamed for clarification.

Renamed for clarification.

1:46 pm

jtaylor  (deleted user)

Done. Changed each instance to the negative form for consistency.

Done. Changed each instance to the negative form for consistency.

1:45 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15306-hd-fault-valve-position-alarm-after-restoring-ac-power-4

Reponse to comments.

Options
    • -2
    • +1
    ./Controllers/BloodFlow.c
    • -2
    • +2
    ./Controllers/DGInterface.c
    • -2
    • +2
    ./Controllers/DialInFlow.c
    • -1
    • +1
    ./Controllers/DialOutFlow.c
    • -1
    • +1
    ./Controllers/Fans.c
    • -1
    • +1
    ./Controllers/Valves.c
    • -19
    • +29
    ./Services/AlarmMgmt.c
12:48 pm

jtaylor  (deleted user)

Done. Changed each instance to the negative form for consistency.

Done. Changed each instance to the negative form for consistency.

12:12 pm

Michael Garthwaite

Merge branch 'staging' into DEN-15196-DIAL-258

Options
    • -24
    • +19
    ./Modes/ModePostTreat.c
12:10 pm

Michael Garthwaite

12:03 pm

jtaylor  (deleted user) and Sean Nash

11:58 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
11:58 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Controllers/PresOccl.c
    • -1
    • +1
    ./Modes/Dialysis.c
    • -2
    • +2
    ./Modes/ModePostTreat.c
    • -1
    • +1
    ./Services/AlarmMgmt.c
    • -1
    • +1
    ./Services/AlarmMgmt.h
    • -1
    • +1
    ./Services/SystemCommMessages.c
11:48 am

Sean Nash

11:46 am

Michael Garthwaite

11:26 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:24 am

Michael Garthwaite

DIAL-258: added clear of 4th level state once we finish wet self tests.

Options
    • -1
    • +1
    ./Modes/PreTreatmentRecirc.c
11:24 am

Michael Garthwaite

fixed. set to no sub state (0xFF) once we transition to pretx recirc

fixed. set to no sub state (0xFF) once we transition to pretx recirc

11:12 am

Sean Nash

Looks like this is only being set in wet self-tests substate of pre-tx prime. Once we leave wet self-tests, should this 4th level state be set back to zero or something?

Looks like this is only being set in wet self-tests substate of pre-tx prime. Once we leave wet self-tests, should this 4th level state be set back to zero or something?

Thursday 01 Jun 2023
9:13 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./HDCommon.h
9:03 pm

Sean Nash

Merge branch 'DEN-15317-usability-hd-door-open-alarm-during-post-treatment' into develop

Options
    • -1
    • +2
    ./Controllers/PresOccl.c
    • -16
    • +15
    ./Modes/ModePostTreat.c
    • -0
    • +1
    ./Services/SystemCommMessages.c
9:03 pm

Sean Nash

DEN-15317: Added alarm re-trigger blocked flag to alarm status broadcast msg.

Options
    • -0
    • +1
    ./Services/AlarmMgmt.c
    • -0
    • +1
    ./Services/AlarmMgmt.h
    • -0
    • +1
    ./Services/SystemCommMessages.c
8:29 pm

Sean Nash

DEN-15317: Moved post-tx homing to ensure it happens in all cases.

Options
    • -16
    • +15
    ./Modes/ModePostTreat.c
8:22 pm

Sean Nash

Seems like we should be calling CPLD function here and in Fans, DialInFlow, and DGInterface too. Also recommend calling the isACPowerLost() function in just one place - maybe alarm mgmt exec to gi...

Seems like we should be calling CPLD function here and in Fans, DialInFlow, and DGInterface too.

Also recommend calling the isACPowerLost() function in just one place - maybe alarm mgmt exec to give you your 10 sec alarm block. Maybe rename the function to checkACPowerLost() with no return value and make it static (private).

8:17 pm

Sean Nash

It is a timer counter. Counts down to zero. And still need to address function header per Bill's first comment.

It is a timer counter. Counts down to zero.

And still need to address function header per Bill's first comment.

8:16 pm

Sean Nash

This seems unnecessary now with your new function doing this all the time. Consider removing.

This seems unnecessary now with your new function doing this all the time. Consider removing.

8:13 pm

Sean Nash

This is technically a timer counter based on task tick of 50ms.

This is technically a timer counter based on task tick of 50ms.

8:11 pm

Sean Nash

This was safer the other way. Why change?

This was safer the other way. Why change?