hdfirmware / firmware

App

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 18 Aug 2023
2:37 pm

wbracken  (deleted user)

12:04 pm

Dara Navaei

HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
HD-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment
11:03 am

Sean Nash

11:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:03 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:43 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:42 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:20 am

wbracken  (deleted user) and Sean Nash

10:20 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:16 am

Sean Nash

Override should be OR'd with timeout only. Used should have to be true even if override > 0.

Override should be OR'd with timeout only. Used should have to be true even if override > 0.

10:15 am

Sean Nash

Remove blank line.

Remove blank line.

10:04 am

Dara Navaei

HD-DEN-16278_HD Pretreatment Prime Start State Does Not Allow Pause
HD-DEN-16278_HD Pretreatment Prime Start State Does Not Allow Pause
9:40 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 17 Aug 2023
6:05 pm

Dara Navaei

HD-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
HD-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
2:21 pm

Michael Garthwaite

dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

1:44 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:12 pm

wbracken  (deleted user)

Add dryPressureTestsCompleted to header.

Add dryPressureTestsCompleted to header.

1:01 pm

Sean Nash

12:56 pm

Michael Garthwaite

Updated to handle any active alarm if we havent passed pressure tests. I also modified the logic to where this valve change should only happen in d.s.p.t.

Updated to handle any active alarm if we havent passed pressure tests. I also modified the logic to where this valve change should only happen in d.s.p.t.

12:55 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:59 am

jtaylor  (deleted user)

10:24 am

wbracken  (deleted user) and Sean Nash

9:10 am

Sean Nash

9:10 am

Sean Nash

8:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:22 am

jtaylor  (deleted user)

As you pointed out earlier, rinsebackTimerCtr is set to zero in states where BP is running, so the if condition would only be TRUE (rinsebackTimerCtr > 0) if BP is not running.

As you pointed out earlier, rinsebackTimerCtr is set to zero in states where BP is running, so the if condition would only be TRUE (rinsebackTimerCtr > 0) if BP is not running.

Wednesday 16 Aug 2023
4:42 pm

Sean Nash

You removed the if (great), but I don't see that you replaced it with BP stopped check. I don't think we want a countdown if BP is running (blood not sitting).

You removed the if (great), but I don't see that you replaced it with BP stopped check. I don't think we want a countdown if BP is running (blood not sitting).

3:34 pm

dcox  (deleted user)

3:28 pm

jtaylor  (deleted user)

Done.

Done.

3:27 pm

Sean Nash

What if we got some other alarm during pressure test states? Would it be better to check dryPressureTestsCompleted?

What if we got some other alarm during pressure test states? Would it be better to check dryPressureTestsCompleted?