Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

HD-DEN-4308_HD Valve Control (1 of 2 )
HD-DEN-4308_HD Valve Control (1 of 2 )
RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14344_SW S85 MG Air Pump
HD-DEN-14344_SW S85 MG Air Pump
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
HD Staging Unreviewed Commits
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

For a release build, looks like we would do nothing and get stuck in this state.

For a release build, looks like we would do nothing and get stuck in this state.

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

Fixed. Thanks!

Fixed. Thanks!

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

It can only be 0 or 1 in a U32 for the time being. I can cast it as a bool

It can only be 0 or 1 in a U32 for the time being. I can cast it as a bool

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.