source

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-14344: air pump updates. changed halcogen code. removed some unused code. removed getairpumpmotorstate.

  1. … 3 more files in changeset.
AirPump.h should be before AirTrap.h.

AirPump.h should be before AirTrap.h.

Function removed. Thanks!

Function removed. Thanks!

Function Removed. Thanks!

Function Removed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Function removed. Thanks!

Function removed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

Fixed. Thanks!

DEN-14344: Air Pump updates. moved to task general. removal of monitor functions. code review changes. Reworked setting motor to be more direct while debugging.

  1. … 3 more files in changeset.
Do we have an alternative to reading if we successfully set the pin high/low?

Do we have an alternative to reading if we successfully set the pin high/low?

Ok. Not sure how HALCoGen got ahead of generated code for a time. RESOLVED in CODE WALKTHROUGH.

Ok. Not sure how HALCoGen got ahead of generated code for a time.
RESOLVED in CODE WALKTHROUGH.

Oh, ok. Then somebody removed a blank line previously and should not have. RESOLVED in CODE WALKTHROUGH.

Oh, ok. Then somebody removed a blank line previously and should not have.
RESOLVED in CODE WALKTHROUGH.

Not sure how we would test pump other than in pre-treatment when we do pressure leak test (bad pump will fail to pressurize venous side). Remove function unless there is some way to test pump direc...

Not sure how we would test pump other than in pre-treatment when we do pressure leak test (bad pump will fail to pressurize venous side). Remove function unless there is some way to test pump directly.

How would you check motor is running? Not clear to me that we need a monitor. Can move broadcast to control exec.

How would you check motor is running? Not clear to me that we need a monitor. Can move broadcast to control exec.

Ok to have this function - just wondering where it would be used? If not needed, remove function and make pump state enum private.

Ok to have this function - just wondering where it would be used? If not needed, remove function and make pump state enum private.

This pin is an output (or it should be), so I don't think a get function makes sense. Where is this function used?

This pin is an output (or it should be), so I don't think a get function makes sense. Where is this function used?

Put constant on right side of compare operator. State should be < num of states.

Put constant on right side of compare operator. State should be < num of states.

Put constant on right side of compare operator. State should be < num of states.

Put constant on right side of compare operator. State should be < num of states.

Remove space before "state".

Remove space before "state".

Remove extra blank lines. Add function headers.

Remove extra blank lines. Add function headers.

Remove extra blank line.

Remove extra blank line.

Add doxygen comment to top of structs and enums.

Add doxygen comment to top of structs and enums.

Align comments.

Align comments.

Remove extra blank line.

Remove extra blank line.