hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Mar 2021
10:23 pm

Dara Navaei

DEN-5980 addressed code review comments

Options
    • -1
    • +1
    ./App/Controllers/BloodFlow.c
    • -9
    • +0
    ./App/Controllers/DGInterface.h
    • -4
    • +4
    ./App/Controllers/PresOccl.c
    • -1
    • +2
    ./App/HDCommon.h
    • -0
    • +4
    ./App/Modes/ModeInitPOST.c
    • -11
    • +3
    ./App/Modes/ModePreTreat.c
    • -12
    • +12
    ./App/Modes/ModeTreatment.c
    • -4
    • +0
    ./App/Services/SystemComm.c
    • -30
    • +1
    ./App/Services/SystemCommMessages.c
    • -3
    • +0
    ./App/Services/SystemCommMessages.h
    • -3
    • +4
    ./App/Tasks/TaskBG.c
    • -10
    • +15
    ./App/Tasks/TaskGeneral.c
    • -3
    • +5
    ./App/Tasks/TaskPriority.c
10:21 pm

Dara Navaei

fwcommon had to be updated with latest changes. It is un-commented.

fwcommon had to be updated with latest changes. It is un-commented.

10:21 pm

Dara Navaei

fwcommon had to be updated with latest changes. They are un-commented.

fwcommon had to be updated with latest changes. They are un-commented.

10:17 pm

Dara Navaei

I just need to run NVDataMgmt POST and nothing else. I added a build switch.

I just need to run NVDataMgmt POST and nothing else. I added a build switch.

10:13 pm

Dara Navaei

I am not sure. I un-commented it.

I am not sure. I un-commented it.

10:11 pm

Dara Navaei

Done.

Done.

10:05 pm

Dara Navaei

Done

Done

10:04 pm

Dara Navaei

Done

Done

10:02 pm

Dara Navaei

Done

Done

9:53 pm

Dara Navaei

To be able to run the code on a board with no hardware. I added a build switch.

To be able to run the code on a board with no hardware. I added a build switch.

9:50 pm

Dara Navaei

To be able to run the code on a board with no hardware attached. I added a build switch.

To be able to run the code on a board with no hardware attached. I added a build switch.

9:46 pm

Dara Navaei

To be able to run the code on a board with no hardware attached. I added a build switch.

To be able to run the code on a board with no hardware attached. I added a build switch.

9:41 pm

Dara Navaei

Done

Done

9:39 pm

Dara Navaei

Done

Done

9:38 pm

Dara Navaei

Done

Done

9:36 pm

Dara Navaei

Done

Done

9:35 pm

Dara Navaei

Yes it is part of fwcommon. To review fwcommon, please review DG-DEN-5980 code review.

Yes it is part of fwcommon. To review fwcommon, please review DG-DEN-5980 code review.

9:34 pm

Dara Navaei

The calibration data is validated in NVDataMgmt driver.

The calibration data is validated in NVDataMgmt driver.

8:45 pm

qnguyen  (deleted user)

HD-DEN-7347_DG HD Dev Post
HD-DEN-7347_DG HD Dev Post
8:41 pm

qnguyen  (deleted user)

Added specific fault for each check.

Added specific fault for each check.

8:37 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added fault for each self-test check

Options
    • -9
    • +20
    ./App/Controllers/BloodFlow.c
    • -10
    • +21
    ./App/Controllers/DialInFlow.c
    • -12
    • +8
    ./App/Controllers/PresOccl.c
    • -1
    • +1
    ./App/Controllers/PresOccl.h
    • -0
    • +1
    ./App/Modes/ConsumableSelfTest.c
    • -30
    • +12
    ./App/Modes/SelfTests.c
5:30 pm

pmontazemi  (deleted user)

Either add TODO or delete commented line.

Either add TODO or delete commented line.

5:24 pm

pmontazemi  (deleted user)

Not better to use this instead? bloodPumpMotorEdgeCount += (U16)(delta);

Not better to use this instead? bloodPumpMotorEdgeCount += (U16)(delta);

4:44 pm

qnguyen  (deleted user)

Removed. It seems nothing much we can do. The door switch is simple and just a GPIO read from FPGA.

Removed. It seems nothing much we can do. The door switch is simple and just a GPIO read from FPGA.

4:43 pm

qnguyen  (deleted user)

Straw door needs to be open for concentrate jugs' connection. Other than that, I am not aware of any flow path that requires closed door. Added TODO.

Straw door needs to be open for concentrate jugs' connection. Other than that, I am not aware of any flow path that requires closed door.
Added TODO.

4:41 pm

qnguyen  (deleted user)

Done.

Done.

4:41 pm

qnguyen  (deleted user)

Combined air trap and bubble detectors into one used cartridge check.

Combined air trap and bubble detectors into one used cartridge check.

4:41 pm

qnguyen  (deleted user)

Combined air trap and bubble detectors into one used cartridge check.

Combined air trap and bubble detectors into one used cartridge check.

4:40 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Addressed code review

Options
    • -1
    • +1
    ./App/Modes/ModePreTreat.c
    • -1
    • +1
    ./App/Modes/OperationModes.c
    • -4
    • +13
    ./App/Modes/SampleWater.c
    • -1
    • +1
    ./App/Modes/SampleWater.h
    • -97
    • +86
    ./App/Modes/SelfTests.c
3:44 pm

qnguyen  (deleted user)

Wrong valve state. Fixed.

Wrong valve state. Fixed.