hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 06 Apr 2021
9:24 am

Sean Nash

DEN-7117: Addressed code review feedback.

Options
    • -2
    • +2
    ./App/Modes/Dialysis.c
    • -1
    • +1
    ./App/Modes/ModeFault.c
    • -3
    • +3
    ./App/Services/FPGA.c
    • -2
    • +6
    ./App/Services/SystemComm.c
    • -10
    • +27
    ./App/Services/SystemCommMessages.c
    • -2
    • +5
    ./App/Services/SystemCommMessages.h
9:21 am

Sean Nash

Done.

Done.

9:21 am

Sean Nash

Done.

Done.

9:19 am

Sean Nash

Good catch. Fixed.

Good catch. Fixed.

9:19 am

qnguyen  (deleted user)

Done.

Done.

9:18 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Aligned doxygen comments

Options
    • -6
    • +6
    ./App/Modes/ModePostTreat.c
9:16 am

Sean Nash

Updated to match DEN-7091.

Updated to match DEN-7091.

9:07 am

pmontazemi  (deleted user)

In comments, replace ten and five with 10 and 5.

In comments, replace ten and five with 10 and 5.

9:01 am

Sean Nash

Done.

Done.

9:00 am

Sean Nash

Fixed.

Fixed.

8:59 am

Sean Nash

Done.

Done.

8:53 am

pmontazemi  (deleted user)

It would be helpful to say which syringe pump controller signal is being passed via all these channels instead of just a channel number.

It would be helpful to say which syringe pump controller signal is being passed via all these channels instead of just a channel number.

8:05 am

pmontazemi  (deleted user)

Comments start with capital letter.

Comments start with capital letter.

8:04 am

pmontazemi  (deleted user)

Spell out lc variable as loadCell.

Spell out lc variable as loadCell.

7:24 am

pmontazemi  (deleted user)

Align comments.

Align comments.

Monday 05 Apr 2021
5:05 pm

qnguyen  (deleted user)

This message should be MSG_ID_UI_INITIATE_TREATMENT_REQUEST.

This message should be MSG_ID_UI_INITIATE_TREATMENT_REQUEST.

4:54 pm

qnguyen  (deleted user)

This seems to be an incorrect message ID.

This seems to be an incorrect message ID.

4:01 pm

Sean Nash

DEN-7117: reviewed TODOs.

Options
    • -14
    • +0
    ./App/Controllers/AirTrap.c
    • -1
    • +0
    ./App/Controllers/AirTrap.h
    • -4
    • +0
    ./App/Controllers/BloodFlow.c
    • -3
    • +3
    ./App/Controllers/DGInterface.c
    • -4
    • +1
    ./App/Controllers/PresOccl.c
    • -7
    • +6
    ./App/Controllers/SyringePump.c
    • -2
    • +7
    ./App/Modes/ModeFault.c
    • -7
    • +3
    ./App/Modes/ModeStandby.c
    • -4
    • +1
    ./App/Modes/ModeTreatmentParams.c
    • -1
    • +1
    ./App/Modes/Rinseback.c
    • -47
    • +0
    ./App/Services/AlarmMgmt.c
    • -7
    • +3
    ./App/Services/FPGA.c
    • -35
    • +1
    ./App/Services/Interrupts.c
    • -2
    • +2
    ./App/Services/SystemComm.c
    • -6
    • +0
    ./App/Services/SystemCommMessages.c
    • -1
    • +0
    ./source/sys_main.c
1:39 pm

Sean Nash

DEN-7117: Fixed typo.

Options
    • -1
    • +1
    ./App/Controllers/SyringePump.c
12:01 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Changed drain reservoir management

Options
    • -0
    • +1
    ./App/HDCommon.h
    • -88
    • +72
    ./App/Modes/ModePostTreat.c
11:22 am

Sean Nash

DEN-7117: Merged staging to local. Fixed merge conflicts.

Options
    • -2
    • +2
    ./App/Modes/Dialysis.c
    • -2
    • +18
    ./App/Services/FPGA.c
    • -0
    • +2
    ./App/Services/FPGA.h
    • -0
    • +7
    ./App/Services/SystemComm.c
    • -6
    • +99
    ./App/Services/SystemCommMessages.c
    • -0
    • +10
    ./App/Services/SystemCommMessages.h
    • -1
    • +5
    ./App/Tasks/TaskPriority.c
    • -0
    • +2
    ./source/sys_main.c
11:16 am

Sean Nash

DEN-7117: added TODO.

Options
    • -0
    • +2
    ./App/Controllers/SyringePump.c
9:26 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Home valves when complete no cartridge self-test

Options
    • -0
    • +4
    ./App/Modes/SelfTests.c
12:12 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Added post-treatment state broadcast

Options
    • -0
    • +1
    ./App/HDCommon.h
    • -3
    • +18
    ./App/Modes/ModePostTreat.c
    • -1
    • +25
    ./App/Services/SystemCommMessages.c
    • -0
    • +3
    ./App/Services/SystemCommMessages.h
12:00 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Change treatment log data msg to request/response

Options
    • -3
    • +17
    ./App/Modes/ModePostTreat.c
    • -0
    • +1
    ./App/Modes/ModePostTreat.h
    • -0
    • +4
    ./App/Services/SystemComm.c
    • -5
    • +28
    ./App/Services/SystemCommMessages.c
    • -3
    • +6
    ./App/Services/SystemCommMessages.h
Friday 02 Apr 2021
4:49 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Added disposable removal confirm response

Options
    • -1
    • +11
    ./App/Modes/ModePostTreat.c
    • -1
    • +50
    ./App/Services/SystemCommMessages.c
    • -1
    • +4
    ./App/Services/SystemCommMessages.h
3:10 pm

Sean Nash

Merge branch 'DEN-7117-hd_dev-hd-heparin-delivery' into develop

Options
    • -10
    • +4
    ./App/Services/SystemCommMessages.c
    • -2
    • +2
    ./App/Services/SystemCommMessages.h
3:05 pm

Sean Nash

DEN-7117: Addressed code review comments. Fixed UF auto-resume after saline bolus issue.

Options
    • -7
    • +15
    ./App/Controllers/SyringePump.c
    • -16
    • +4
    ./App/Modes/Dialysis.c
10:41 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.