firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-7605: Fixed typo.

The clearAlarmCondition() function will check if the alarm is active or not and only clears if the alarm has been raised.

The clearAlarmCondition() function will check if the alarm is active or not and only clears if the alarm has been raised.

Typecasting the variables is not needed here. The macro typecasts them.

Typecasting the variables is not needed here. The macro typecasts them.

Should probably go to normal state on fail as well - otherwise you get stuck here in self-test state.

Should probably go to normal state on fail as well - otherwise you get stuck here in self-test state.

Can we clear this alarm when it is raised? If no, do we need this else statement? Because if the alarm has not been raised, we do not need to clear it either.

Can we clear this alarm when it is raised? If no, do we need this else statement? Because if the alarm has not been raised, we do not need to clear it either.

I think better to use self test status enum (mentioned in .h comment). This enum will have pass/fail/in progress. I think if we're still in INIT, zero, or self-test state, in-progress is appropriat...

I think better to use self test status enum (mentioned in .h comment). This enum will have pass/fail/in progress. I think if we're still in INIT, zero, or self-test state, in-progress is appropriate return value. I think you should have a BOOL variable defined to remember whether self-test passed or failed (instead of inferring from current state). Then if in normal state, return pass if self-test passed, failed if not.

Recommend typecasting bloodLeakState to (U32)bloodLeakState. Outside of this driver the enums are only U32s until they are converted to states again in Dialin.

Recommend typecasting bloodLeakState to (U32)bloodLeakState. Outside of this driver the enums are only U32s until they are converted to states again in Dialin.

Same comment as above re: timeout.

Same comment as above re: timeout.

Should AND this bit off from register so we don't interfere with other bits that may have been set by other drivers (e.g. bubble detector). Should be something like fpgaActuatorSetPoints.fpgaSensor...

Should AND this bit off from register so we don't interfere with other bits that may have been set by other drivers (e.g. bubble detector).
Should be something like fpgaActuatorSetPoints.fpgaSensorTest &= ~FPGA_BLOOD_LEAK_SELF_TEST_CMD;

Should AND this bit off from register so we don't interfere with other bits that may have been set by other drivers (e.g. bubble detector). Should be something like fpgaActuatorSetPoints.fpgaSensor...

Should AND this bit off from register so we don't interfere with other bits that may have been set by other drivers (e.g. bubble detector).
Should be something like fpgaActuatorSetPoints.fpgaSensorTest &= ~FPGA_BLOOD_LEAK_ZERO_CMD;

Should OR ( |= instead of = ) this bit into register so we don't interfere with other bits that may have been set by other drivers (e.g. bubble detector).

Should OR ( |= instead of = ) this bit into register so we don't interfere with other bits that may have been set by other drivers (e.g. bubble detector).

Should OR ( |= instead of = ) this bit into register so we don't interfere with other bits that may have been set by other drivers (e.g. bubble detector).

Should OR ( |= instead of = ) this bit into register so we don't interfere with other bits that may have been set by other drivers (e.g. bubble detector).

Consider checking for the Zero each time we execute this state (not just after timeout). Consider moving timeout to the alarm below (give zero time to happen, alarm if timeout). Consider giving ala...

Consider checking for the Zero each time we execute this state (not just after timeout).
Consider moving timeout to the alarm below (give zero time to happen, alarm if timeout).
Consider giving alarm a little more than 10 ms (maybe 20 or 30ms) as 10ms is how long it will take to go from init to zero state (i.e. 10ms timeout will occur as soon as we get here).

I would say this function requests that the blood leak detector be zeroed (and self-tested). Zero does not happen right here in this function.

I would say this function requests that the blood leak detector be zeroed (and self-tested). Zero does not happen right here in this function.

There is a SELF_TEST_STATUS_T enum (pass/fail) defined in fwcommon Common.h. Consider returning this type instead of BOOL.

There is a SELF_TEST_STATUS_T enum (pass/fail) defined in fwcommon Common.h. Consider returning this type instead of BOOL.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

Addressed.

DEN-7395: Addressed code review comments

    • -105
    • +114
    ./App/Controllers/BloodLeak.c
    • -18
    • +10
    ./App/Services/SystemCommMessages.c