hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 25 Apr 2021
10:32 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Addressed code reviews

Options
    • -34
    • +34
    ./App/Controllers/DGInterface.h
    • -17
    • +1
    ./App/Controllers/PresOccl.c
    • -3
    • +3
    ./App/Controllers/SyringePump.c
    • -6
    • +24
    ./App/Modes/ModePostTreat.c
    • -1
    • +1
    ./App/Modes/ModePreTreat.c
    • -0
    • +1
    ./App/Services/AlarmMgmt.h
10:22 pm

qnguyen  (deleted user)

Changed to return none.

Changed to return none.

10:21 pm

qnguyen  (deleted user)

Done.

Done.

10:21 pm

qnguyen  (deleted user)

Done.

Done.

10:17 pm

qnguyen  (deleted user)

EMPTY_RESERVOIR_VOLUME_ML is defined as 0.

EMPTY_RESERVOIR_VOLUME_ML is defined as 0.

10:14 pm

qnguyen  (deleted user)

Added.

Added.

10:12 pm

qnguyen  (deleted user)

I think the variable will be used in future to detect incorrect direction. Sean Nash Please elaborate more.

I think the variable will be used in future to detect incorrect direction.
Sean Nash Please elaborate more.

10:10 pm

qnguyen  (deleted user)

Done.

Done.

10:10 pm

qnguyen  (deleted user)

Done.

Done.

10:09 pm

qnguyen  (deleted user)

The function has been removed.

The function has been removed.

10:08 pm

qnguyen  (deleted user)

Done.

Done.

8:24 pm

Dara Navaei

This function does not return anything.

This function does not return anything.

7:34 pm

Dara Navaei

This function needs a header.

This function needs a header.

7:33 pm

Dara Navaei

Is this function in charge of completely draining a reservoir? If yes, why should we provide a target parameter? Why not drain to 0 automatically?

Is this function in charge of completely draining a reservoir? If yes, why should we provide a target parameter? Why not drain to 0 automatically?

7:28 pm

Dara Navaei

This function needs a header.

This function needs a header.

7:05 pm

Dara Navaei

Do we need a fault here?

Do we need a fault here?

6:59 pm

Dara Navaei

Do we not need a fault here?

Do we not need a fault here?

6:44 pm

Dara Navaei

Will this variable be ever used?

Will this variable be ever used?

6:37 pm

Dara Navaei

For consistency, I recommend reversing the second part of and in the if statement.

For consistency, I recommend reversing the second part of and in the if statement.

6:37 pm

Dara Navaei

For consistency, I recommend reversing the second part of and in the if statement.

For consistency, I recommend reversing the second part of and in the if statement.

6:30 pm

Dara Navaei

As per our design decision, reverse the second part of the and.

As per our design decision, reverse the second part of the and.

6:20 pm

Dara Navaei

Inputs and outputs are missing.

Inputs and outputs are missing.

6:15 pm

Dara Navaei

All these structures need doxygen comments.

All these structures need doxygen comments.

Friday 23 Apr 2021
5:37 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Fixed pre-treatment reservoir management when reservoir is already empty

Options
    • -7
    • +9
    ./App/Modes/ModePreTreat.c
5:11 pm

Sean Nash

.

Options
    • -1
    • +1
    ./App/HDCommon.h
4:43 pm

Sean Nash

Fixed merge conflicts.

Options
    • -4
    • +4
    ./App/Modes/Dialysis.c
4:42 pm

Sean Nash

DEN-7605: Added persistence to syringe pump ADC fault. Fixed Heparin pre-stop logic.

Options
    • -2
    • +13
    ./App/Controllers/SyringePump.c
    • -4
    • +4
    ./App/Modes/Dialysis.c
2:43 pm

Sean Nash

Added persistence to syringe pump ADC read fault. Will add to DEN-7605.

Options
    • -2
    • +13
    ./App/Controllers/SyringePump.c
    • -3
    • +3
    ./App/HDCommon.h
11:10 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Sent target dialysate temp to DG upon transition to pre-treatment

Options
    • -7
    • +7
    ./App/Modes/ModePreTreat.c
10:47 am

Quang Nguyen <qnguyen@diality.com>

DEN-7347: Moved blood leak detector self-test into wet self-test

Options
    • -34
    • +35
    ./App/Modes/SelfTests.c