hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 17 May 2021
1:44 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-7860: Addressed code review comments

Options
    • -1
    • +1
    ./App/Controllers/Bubble.c
    • -12
    • +12
    ./App/Services/FPGA.c
1:39 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:39 pm

pmontazemi  (deleted user)

Corrected comments for HD Fluid Leak, HD Blood Leak, and HD Air Bubbles Sean Nash TODO Please correct header comment for DG Fluid Leak.

Corrected comments for HD Fluid Leak, HD Blood Leak, and HD Air Bubbles

Sean Nash TODO Please correct header comment for DG Fluid Leak.

1:39 pm

pmontazemi  (deleted user)

Corrected for both HD Blood Leak and HD Air Bubbles.

Corrected for both HD Blood Leak and HD Air Bubbles.

1:32 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:32 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:31 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:25 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-7860: Addressed code review comments

Options
    • -0
    • +3
    ./App/Controllers/BloodLeak.c
    • -0
    • +3
    ./App/Controllers/FluidLeak.c
    • -1
    • +1
    ./App/Services/FPGA.c
1:24 pm

pmontazemi  (deleted user)

We have not done this for any of the following features. After talking to Sean Nash, below is the TODO list. *HD Air Trap (TODO Sean Nash) *DG/HD Fluid Leak (DG TODO Sean Nash, HD TODO [~pmontaz...

We have not done this for any of the following features. After talking to Sean Nash, below is the TODO list.

  • HD Air Trap (TODO Sean Nash)
  • DG/HD Fluid Leak (DG TODO Sean Nash, HD TODO [~pmontazemi])
  • HD Blood Leak (TODO [~pmontazemi])
  • HD ADA/ADV Air Bubbles (TODO [~pmontazemi])
11:17 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:57 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

Dara Navaei

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:56 am

Peman Montazemi <pmontazemi@diality.com>

DEN-7860: Addressed code review comments

Options
    • -1
    • +4
    ./App/Controllers/Bubble.c
10:56 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:55 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:54 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:54 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:53 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:53 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:53 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:53 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:52 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:50 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:49 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:47 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:47 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:41 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

pmontazemi  (deleted user)

We plan on doing self-test as part of priming, so we confirm the bubble detector reads air on a new cartridge, then we check that we read fluid when we have completed priming. I need to add these c...

We plan on doing self-test as part of priming, so we confirm the bubble detector reads air on a new cartridge, then we check that we read fluid when we have completed priming. I need to add these checks. The air bubble detector alarm, however, should only be active during treatment (includes blood prime and rinseback), and outside of that we just monitor the detectors but never alarm. Therefore, we do not need to do the self-test in POST and it is fine to keep handleInitBubbleState(...) as is.

Note: No code change to handleInitBubbleState(...).