hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 26 Jul 2021
9:53 am

Sean Nash

Seems like the two states given as data are not very meaningful. Consider just setting before/after data to zero for this event.

Seems like the two states given as data are not very meaningful. Consider just setting before/after data to zero for this event.

9:50 am

Sean Nash

Not sure this variable (and related get function) are needed.

Not sure this variable (and related get function) are needed.

9:49 am

Sean Nash

User may not have changed all 4 settings. Should we only send events for those that actually changed?

User may not have changed all 4 settings. Should we only send events for those that actually changed?

9:41 am

Sean Nash

I think this will be the time we initiate a treatment. Is that what we want? Or should we move this to transition function to capture time of treatment start?

I think this will be the time we initiate a treatment. Is that what we want? Or should we move this to transition function to capture time of treatment start?

9:39 am

Sean Nash

Are there ever any reject reasons? Is this message requested by UI or sent unsolicited when ready?

Are there ever any reject reasons? Is this message requested by UI or sent unsolicited when ready?

9:34 am

Sean Nash

I think we set UF volume to zero in TreatmentParams mode, so this condition should not be necessary.

I think we set UF volume to zero in TreatmentParams mode, so this condition should not be necessary.

9:32 am

Sean Nash

Why not zero record here? I see it is zeroed just prior to creation at end of treatment, but that means this record may have prior treatment's data until current treatment is over.

Why not zero record here? I see it is zeroed just prior to creation at end of treatment, but that means this record may have prior treatment's data until current treatment is over.

9:18 am

Sean Nash

If typical h/w response is very quick (e.g. < 1ms) and worst case is still pretty quick (e.g. < 5ms), then I think this is ok with the t/o there to prevent getting stuck in loop forever. Also, batt...

If typical h/w response is very quick (e.g. < 1ms) and worst case is still pretty quick (e.g. < 5ms), then I think this is ok with the t/o there to prevent getting stuck in loop forever.
Also, battery monitor is called from background task so we can be a little more relaxed about this.

9:12 am

Sean Nash

Why would we zero it when no AC detected?

Why would we zero it when no AC detected?

9:08 am

Sean Nash

Why are DG definitions in HDDefs.h? If needed by both stacks, should we create a FWDefs.h common to both f/w stacks?

Why are DG definitions in HDDefs.h? If needed by both stacks, should we create a FWDefs.h common to both f/w stacks?

Sunday 25 Jul 2021
4:10 pm

Dara Navaei

HD-DEN-9054_DG HD Switches
HD-DEN-9054_DG HD Switches
Saturday 24 Jul 2021
4:06 pm

Dara Navaei

Does the payload length does not match with the payload? In the payload, you have 1 U32 and 2 F32s so should not the length be U32 + 2 * F32?

Does the payload length does not match with the payload? In the payload, you have 1 U32 and 2 F32s so should not the length be U32 + 2 * F32?

3:54 pm

Dara Navaei

Do we not need a battery remaining percent override function for testing?

Do we not need a battery remaining percent override function for testing?

3:51 pm

Dara Navaei

The name of the function does not match with the actual name.

The name of the function does not match with the actual name.

3:49 pm

Dara Navaei

Is it safe to stay in while loop until the hardware responds? I understand that you have a timeout but I thought we still should not do that.

Is it safe to stay in while loop until the hardware responds? I understand that you have a timeout but I thought we still should not do that.

3:34 pm

Dara Navaei

How do you get the status of the battery charge in the self test before you check the whether it is in range?

How do you get the status of the battery charge in the self test before you check the whether it is in range?

3:28 pm

Dara Navaei

I recommend to explicitly name the input and output variables.

I recommend to explicitly name the input and output variables.

3:26 pm

Dara Navaei

Reverse the order of the condition.

Reverse the order of the condition.

3:25 pm

Dara Navaei

Why do you need an else here to zero the counter? Do you not need to 0 it anyways?

Why do you need an else here to zero the counter? Do you not need to 0 it anyways?

Wednesday 21 Jul 2021
10:26 pm

qnguyen  (deleted user)

HD-DEN-8679_HD Dev Treatment Log
HD-DEN-8679_HD Dev Treatment Log
Wednesday 07 Jul 2021
5:21 pm

Dara Navaei

10:47 am

qnguyen  (deleted user) and Sean Nash

10:45 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 06 Jul 2021
10:02 pm

Dara Navaei

I will address this comment in DEN-9054 (switches) branch.

I will address this comment in DEN-9054 (switches) branch.

Monday 05 Jul 2021
7:27 pm

Dara Navaei

Done

Done