hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Dec 2021
7:13 pm

Dara Navaei

DEN-11114 addressed the code review comments. DEN-11364 removed the 1 second fans monitor interval

Options
    • -13
    • +8
    ./App/Controllers/BloodLeak.c
    • -1
    • +1
    ./App/Controllers/BloodLeak.h
    • -47
    • +39
    ./App/Controllers/Fans.c
1:14 pm

Sean Nash

Update message list with latest data details.

Update message list with latest data details.

1:13 pm

Sean Nash

Update message list with latest broadcast msg data details.

Update message list with latest broadcast msg data details.

1:09 pm

Sean Nash

We don't need to calculate digit count - just use strlen(tempCharBuffer) after sprintf creates your string.

We don't need to calculate digit count - just use strlen(tempCharBuffer) after sprintf creates your string.

1:08 pm

Sean Nash

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buf...

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buffer to populate - otherwise it will overwrite memory.

1:03 pm

Sean Nash

.crc?

.crc?

1:00 pm

Sean Nash

1 and 0 is not clear. Better to say FIFO send and reset.

1 and 0 is not clear. Better to say FIFO send and reset.

12:43 pm

Sean Nash

Create and trigger new alarm.

Create and trigger new alarm.

12:42 pm

Sean Nash

.crc?

.crc?

12:40 pm

Sean Nash

Recommend changing > to >= and then removing the - 1.

Recommend changing > to >= and then removing the - 1.

12:28 pm

Sean Nash

Please update message list details for this broadcast msg.

Please update message list details for this broadcast msg.

12:24 pm

Sean Nash

If h/w component is not required to have a calibration, we shouldn't alarm here - right?

If h/w component is not required to have a calibration, we shouldn't alarm here - right?

12:23 pm

Sean Nash

We should verify bufferLength is >= to cal section byte size before doing this memcpy - otherwise, we will be overwriting memory.

We should verify bufferLength is >= to cal section byte size before doing this memcpy - otherwise, we will be overwriting memory.

12:21 pm

Sean Nash

Is CRC check on individual cal section done elsewhere or should it be considered here as well?

Is CRC check on individual cal section done elsewhere or should it be considered here as well?

10:00 am

Dara Navaei

Done.

Done.

9:55 am

Sean Nash

Recommend moving this rate to be with the others above.

Recommend moving this rate to be with the others above.

9:52 am

Sean Nash

STEADY_VOLUME_COUNT_SEC is a number of seconds of stability indicating volume is steady. This only works because sampling time above is once per second. If somebody changes the sampling time, this ...

STEADY_VOLUME_COUNT_SEC is a number of seconds of stability indicating volume is steady. This only works because sampling time above is once per second. If somebody changes the sampling time, this condition will not be right.

9:49 am

Sean Nash

Make 0.5 a #define.

Make 0.5 a #define.

9:43 am

Sean Nash

Can we please use available alarm IDs above before adding a new one?

Can we please use available alarm IDs above before adding a new one?

Wednesday 29 Dec 2021
11:16 pm

Dara Navaei

DEN-11114, DEN-11364 worked on the blood leak calibration and removed the fans clear the alarm if the RPM was in range again

Options
    • -10
    • +55
    ./App/Controllers/BloodLeak.c
    • -1
    • +3
    ./App/Controllers/BloodLeak.h
    • -9
    • +0
    ./App/Controllers/Fans.c
    • -1
    • +1
    ./App/Controllers/Fans.h
    • -1
    • +1
    ./App/HDCommon.h
    • -0
    • +6
    ./App/Modes/ModeInitPOST.c
Wednesday 22 Dec 2021
4:14 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/HDCommon.h
4:14 pm

Dara Navaei

Merged DEN-11114

Options
    • -1
    • +1
    ./App/Controllers/Fans.h
4:13 pm

Dara Navaei

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' into develop

Options
    • -31
    • +52
    ./App/Controllers/BloodLeak.c
    • -8
    • +9
    ./App/Controllers/Fans.c
4:12 pm

Dara Navaei

DEN-11114 added a publication to the fans

Options
    • -31
    • +52
    ./App/Controllers/BloodLeak.c
    • -8
    • +9
    ./App/Controllers/Fans.c
    • -0
    • +1
    ./App/Controllers/Fans.h
    • -1
    • +2
    ./App/Services/AlarmMgmt.c
    • -1
    • +1
    ./App/Services/FPGA.h
Tuesday 21 Dec 2021
2:03 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/HDCommon.h
1:58 pm

Dara Navaei

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' into develop

Options
    • -26
    • +118
    ./App/Controllers/BloodLeak.c
    • -18
    • +93
    ./App/Controllers/Fans.c
    • -0
    • +4
    ./App/Services/SystemComm.c
    • -0
    • +33
    ./App/Services/SystemCommMessages.c
1:56 pm

Dara Navaei

DEN-11114, DEN-11542 updated the fans RPM alarm

Options
    • -9
    • +13
    ./App/Controllers/BloodLeak.c
    • -1
    • +1
    ./App/Controllers/Fans.c
    • -1
    • +1
    ./App/Services/SystemComm.c
10:13 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/HDCommon.h
10:13 am

Dara Navaei

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

Options
    • -1
    • +1
    ./App/HDCommon.h
10:13 am

Dara Navaei

Diabled prime swithces

Options
    • -7
    • +7
    ./App/HDCommon.h