hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 03 Mar 2022
1:31 pm

Dara Navaei

DEN-11750 addressed the code review comments

Options
    • -1
    • +2
    ./App/Modes/BloodPrime.c
    • -1
    • +2
    ./App/Modes/Rinseback.c
1:29 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:29 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:28 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:27 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:26 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:26 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:25 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:24 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

1:24 pm

Michael Garthwaite

RESOVLED IN CODE WALKTHROUGH.

RESOVLED IN CODE WALKTHROUGH.

12:51 pm

Dara Navaei

DEN-11750 addressed the code review comments

Options
    • -1
    • +1
    ./App/Controllers/SyringePump.c
    • -1
    • +2
    ./App/Controllers/Temperatures.c
    • -3
    • +0
    ./App/Modes/ModeInitPOST.c
    • -98
    • +102
    ./App/Services/SystemCommMessages.c
    • -1
    • +0
    ./App/Services/SystemCommMessages.h
12:50 pm

Dara Navaei

Done.

Done.

12:48 pm

Dara Navaei

Done.

Done.

Wednesday 02 Mar 2022
8:49 pm

Dara Navaei

Done.

Done.

8:48 pm

Dara Navaei

No, this should be removed. If this is in an else, in a release build it is not going to compile sine the if will be ignored.

No, this should be removed. If this is in an else, in a release build it is not going to compile sine the if will be ignored.

5:20 pm

Sean Nash

These appear to be Dialin message functions. They should be down in the Dialin section below the TEST SUPPORT FUNCTIONS banner.

These appear to be Dialin message functions. They should be down in the Dialin section below the TEST SUPPORT FUNCTIONS banner.

5:10 pm

Sean Nash

Check payload length is at least 12.

Check payload length is at least 12.

5:09 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

5:02 pm

Sean Nash

This can be uninitialized. It is initialized in the init function below.

This can be uninitialized. It is initialized in the init function below.

4:43 pm

Sean Nash

Should this be in an else below?

Should this be in an else below?

4:36 pm

Sean Nash

There should be 2 blank lines above and below the TEST SUPPORT FUNCTIONS banner below.

There should be 2 blank lines above and below the TEST SUPPORT FUNCTIONS banner below.

4:34 pm

Dara Navaei

Done.

Done.

4:34 pm

Sean Nash

Can leave uninitialized here. It is initialized in init function below.

Can leave uninitialized here. It is initialized in init function below.

4:34 pm

Dara Navaei

Done.

Done.

4:31 pm

Dara Navaei

It has been removed.

It has been removed.

4:27 pm

Sean Nash

Add TODO to remove later.

Add TODO to remove later.

4:26 pm

Sean Nash

Add TODO to remove.

Add TODO to remove.

4:24 pm

Sean Nash

Add one more blank line here.

Add one more blank line here.

4:05 pm

Dara Navaei

Yes, there might be other release issues. We have not built release in a long time but we can resolve them once we decided to have a release build.

Yes, there might be other release issues. We have not built release in a long time but we can resolve them once we decided to have a release build.

3:56 pm

Sean Nash

It doesn't appear to build for me.

It doesn't appear to build for me.