firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-12224 updated the blood leak emebedded mode

    • -3
    • +36
    ./App/Services/SystemCommMessages.c
Done

Done

Done

Done

Done

Done

Done

Done

DEN-12441 Code review comment updates 2.

DEN-12441 Code review comment updates.

Yes. setupForBloodRecirculationState() does this on Init and entry to Blood Recirculation.

Yes. setupForBloodRecirculationState() does this on Init and entry to Blood Recirculation.

This was a place holder for NVRAM saving of Treatment Time. I removed it.

This was a place holder for NVRAM saving of Treatment Time. I removed it.

DEN-12441 Remove place holder for saving Treatment Time to NVRAM. No longer part of this task set.

Is this timer reset to 0 when we go to states where blood is recirculating? I think it should be.

Is this timer reset to 0 when we go to states where blood is recirculating? I think it should be.

Put spaces between parenthesis and inner condition code. Prefer literals be on right side of compare operators except for "==".

Put spaces between parenthesis and inner condition code. Prefer literals be on right side of compare operators except for "==".

Consider reading these blocked flags into local booleans so you don't have to keep calling these functions (and avoid possibility that function returns different value in subsequent call).

Consider reading these blocked flags into local booleans so you don't have to keep calling these functions (and avoid possibility that function returns different value in subsequent call).

I think syringe pump is stopped in every scenario so maybe this should stay here instead of in various setup functions.

I think syringe pump is stopped in every scenario so maybe this should stay here instead of in various setup functions.

I think VDi and VDo valves are closed in every scenario so maybe they should just be set here instead of in the various setup functions.

I think VDi and VDo valves are closed in every scenario so maybe they should just be set here instead of in the various setup functions.

DEN-12224 updated the blood leak embedded mode

    • -141
    • +186
    ./App/Controllers/BloodLeak.c
    • -4
    • +10
    ./App/Services/SystemCommMessages.c
What is the purpose of this new code? Should have a comment above to make clear. Need to address TODOs.

What is the purpose of this new code? Should have a comment above to make clear.
Need to address TODOs.

HD-DEN-12441_SW Dev Sprint 67 Darren
HD-DEN-12441_SW Dev Sprint 67 Darren
Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Merge branch 'develop' of ssh://dvm-linux02:7999/hd/hdfirmware into develop

    • -1
    • +116
    ./App/Services/SystemCommMessages.c
DEN-12441 Resolve conflicts for merge with Develop.

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Fixed merge conflicts.

    • -96
    • +323
    ./App/Controllers/BloodLeak.c
    • -1
    • +116
    ./App/Services/SystemCommMessages.c
DEN-12224: Fixes to Tx log event logging.

DEN-12224: Added message support for UI to request going to service mode. Allow faults to be minimized.

    • -1
    • +66
    ./App/Services/SystemCommMessages.c
DEN-12224 updated the blood leak embedded mode driver

    • -23
    • +179
    ./App/Controllers/BloodLeak.c
Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' of ssh://dvm-linux02:7999/hd/hdfirmware into DEN-12224-dg_hd_dev-switches-monitor

DEN-12224 updated the blood leak embedded mode commands

    • -97
    • +168
    ./App/Controllers/BloodLeak.c
    • -0
    • +50
    ./App/Services/SystemCommMessages.c