hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 23 May 2022
4:48 pm

Dara Navaei

DEN-12224 addressed the code review comments

Options
    • -28
    • +28
    ./App/Controllers/BloodLeak.c
    • -1
    • +1
    ./App/Services/SystemCommMessages.c
4:44 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:43 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:42 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:41 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:40 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:40 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:39 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:37 pm

Dara Navaei

We have to make sure the enable/disable feature in the software releases is not available in the release.

We have to make sure the enable/disable feature in the software releases is not available in the release.

3:13 pm

Sean Nash

Why only DG?

Why only DG?

3:11 pm

Sean Nash

Remove blank line.

Remove blank line.

3:10 pm

Sean Nash

Don't we still want to know if it's valid - and revert to defaults if not?

Don't we still want to know if it's valid - and revert to defaults if not?

3:09 pm

Sean Nash

Don't we still want to know if it's valid - and revert to defaults if not?

Don't we still want to know if it's valid - and revert to defaults if not?

3:05 pm

Dara Navaei

DEN-12224 merged staging

Options
    • -2
    • +4
    ./App/Controllers/SyringePump.c
    • -1
    • +1
    ./App/HDCommon.h
    • -1
    • +3
    ./App/Modes/Dialysis.c
    • -1
    • +1
    ./App/Modes/ModeTreatment.c
    • -2
    • +16
    ./App/Modes/SelfTests.c
    • -2
    • +2
    ./App/Modes/TreatmentEnd.c
    • -42
    • +230
    ./App/Modes/TreatmentStop.c
    • -3
    • +24
    ./App/Services/AlarmMgmt.c
    • -2
    • +4
    ./App/Services/AlarmMgmt.h
    • -1
    • +2
    ./App/Services/SystemCommMessages.c
1:36 pm

Dara Navaei

DEN-12224 addressed the code review comments

Options
    • -2
    • +2
    ./App/Controllers/BloodLeak.c
    • -2
    • +1
    ./App/Controllers/DialOutFlow.c
    • -2
    • +2
    ./App/Controllers/Fans.c
    • -0
    • +3
    ./App/Modes/TreatmentEnd.c
    • -3
    • +0
    ./App/Modes/TreatmentStop.c
1:28 pm

Dara Navaei

Done.

Done.

1:20 pm

Dara Navaei

Done.

Done.

1:17 pm

Dara Navaei

There will not be any alarms for the software configurations.

There will not be any alarms for the software configurations.

1:17 pm

Dara Navaei

There will not be any alarms for the software configurations.

There will not be any alarms for the software configurations.

11:10 am

Dara Navaei

Thanks Michael, fixed it.

Thanks Michael, fixed it.

11:02 am

Michael Garthwaite

Not yet.

Not yet.

10:56 am

Michael Garthwaite

couldnt we simplify this and compare it to a struct of the payload? (ex: UI_VERSIONS_T)

couldnt we simplify this and compare it to a struct of the payload? (ex: UI_VERSIONS_T)

10:35 am

Dara Navaei

Done.

Done.

10:34 am

Dara Navaei

Not if the #define is used by other modules. In this case, this #define is used by ModeInitPOST.c

Not if the #define is used by other modules. In this case, this #define is used by ModeInitPOST.c

10:33 am

Dara Navaei

Michael Garthwaite do you have the latest tolerances after your testings?

Michael Garthwaite do you have the latest tolerances after your testings?

10:32 am

Dara Navaei

We should keep this state until we are sure it is no longer needed.

We should keep this state until we are sure it is no longer needed.

10:31 am

Dara Navaei

Done.

Done.

10:29 am

Dara Navaei

Done.

Done.

10:25 am

Dara Navaei

Done.

Done.

10:25 am

Dara Navaei

Done.

Done.