firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-12224 addressed the code review comments

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

We have to make sure the enable/disable feature in the software releases is not available in the release.

We have to make sure the enable/disable feature in the software releases is not available in the release.

Why only DG?

Why only DG?

Remove blank line.

Remove blank line.

Don't we still want to know if it's valid - and revert to defaults if not?

Don't we still want to know if it's valid - and revert to defaults if not?

Don't we still want to know if it's valid - and revert to defaults if not?

Don't we still want to know if it's valid - and revert to defaults if not?

DEN-12224 merged staging

DEN-12224 addressed the code review comments

Done.

Done.

Done.

Done.

There will not be any alarms for the software configurations.

There will not be any alarms for the software configurations.

There will not be any alarms for the software configurations.

There will not be any alarms for the software configurations.

Thanks Michael, fixed it.

Thanks Michael, fixed it.

Not yet.

Not yet.

couldnt we simplify this and compare it to a struct of the payload? (ex: UI_VERSIONS_T)

couldnt we simplify this and compare it to a struct of the payload? (ex: UI_VERSIONS_T)

Done.

Done.

Not if the #define is used by other modules. In this case, this #define is used by ModeInitPOST.c

Not if the #define is used by other modules. In this case, this #define is used by ModeInitPOST.c

Michael Garthwaite do you have the latest tolerances after your testings?

Michael Garthwaite do you have the latest tolerances after your testings?

We should keep this state until we are sure it is no longer needed.

We should keep this state until we are sure it is no longer needed.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.