Activity hdfirmware/firmware

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	17
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 14 Oct 2022

10:33 am

Michael Garthwaite

More
f36eb93
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 309 more HD-DEN-14101-1

DEN-14101: Code cleanup and formatting.

- -22
- +4
./App/Controllers/SyringePump.c
- History
- Source
- Diff
./App/Controllers/SyringePump.c

10:30 am

Michael Garthwaite

More
d6709b7
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 309 more HD-UCOMMITS-20

DEN-14101: syringe pump dac fixes. implemented retry procedure for error bits. Moved error bit detection to be the first check.

- -6
- +59
./App/Controllers/SyringePump.c
- History
- Source
- Diff
./App/Controllers/SyringePump.c

10:25 am

Dara Navaei

More
Re: HD-DEN-13834-1
replied to Sean Nash

This is in fwcommon so it has to be able to cover both stacks.

This is in fwcommon so it has to be able to cover both stacks.

10:11 am

Dara Navaei

Disabled the #define.

Disabled the #define.

10:10 am

Dara Navaei

More
Re: HD-DEN-13834-1
replied to Sean Nash

Done.

Done.

10:09 am

Dara Navaei

More
88e9ed0
changed 1 file
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 311 more HD-DEN-13834-1

DEN-13834 addressed the code review comment

- -0
- +1
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c

9:48 am

Dara Navaei

More
5c7b301
changed 5 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 311 more HD-DEN-13834-1

Merge branch 'staging' into DEN-13834-dg_hd_dev-hd_dg_dvt-update-part-3

- -2
- +3
./App/Controllers/DialOutFlow.h
- History
- Source
- Diff
./App/Controllers/DialOutFlow.h
- -1
- +1
./App/HDCommon.h
- History
- Source
- Diff
./App/HDCommon.h
- -2
- +14
./App/Services/SystemComm.c
- History
- Source
- Diff
./App/Services/SystemComm.c
- -2
- +83
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c
- -2
- +11
./App/Services/SystemCommMessages.h
- History
- Source
- Diff
./App/Services/SystemCommMessages.h

9:44 am

Dara Navaei

More
Re: HD-DEN-13834-1
replied to wbracken (deleted user)

Done.

Done.

9:36 am

Dara Navaei

More
Re: HD-DEN-13834-1
replied to Sean Nash

This was changed to be consistent with the rest of the FAPI if statements.

This was changed to be consistent with the rest of the FAPI if statements.

9:34 am

Dara Navaei

More
Re: HD-DEN-13834-1
replied to Sean Nash

Done.

Done.

9:33 am

Dara Navaei

More
2140a55
changed 3 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 311 more HD-DEN-13834-1

DEN-13834 addressed the code review comments

- -7
- +9
./App/Drivers/SafetyShutdown.c
- History
- Source
- Diff
./App/Drivers/SafetyShutdown.c
- -1
- +1
./App/HDCommon.h
- History
- Source
- Diff
./App/HDCommon.h
- -18
- +17
./App/Services/WatchdogMgmt.c
- History
- Source
- Diff
./App/Services/WatchdogMgmt.c

Thursday 13 Oct 2022

11:58 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:58 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:53 pm

Sean Nash

Still below operation modes exec.

Still below operation modes exec.

11:50 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:34 pm

Sean Nash

More
Re: HD-DEN-13903-2
commented on review

Why are we setting BP speed here? Wouldn't BP already be setup prior to this state? What does fluid at lower level have to do with BP speed?

Why are we setting BP speed here? Wouldn't BP already be setup prior to this state? What does fluid at lower level have to do with BP speed?

11:33 pm

Sean Nash

More
Re: HD-DEN-13903-2
commented on review

Wouldn't we set primeFirstPurgePass to FALSE here (we've just completed first pass and we're leaving)? And so shouldn't we just set BP to the faster rate now?

Wouldn't we set primeFirstPurgePass to FALSE here (we've just completed first pass and we're leaving)? And so shouldn't we just set BP to the faster rate now?

11:30 pm

Sean Nash

More
08675a1
changed 2 files
DEN-10155-treatment-end-paused-state-not-displaying-resume-option, DEN-13154-heparin-syringe-empty-position-incorrect and 313 more HD-DEN-14000-1

Addressed code review comments.

- -0
- +1
./App/Controllers/DialInFlow.c
- History
- Source
- Diff
./App/Controllers/DialInFlow.c
- -2
- +1
./App/Services/SystemCommMessages.c
- History
- Source
- Diff
./App/Services/SystemCommMessages.c

11:29 pm

Sean Nash

More
Re: HD-DEN-14000-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:28 pm

Sean Nash

More
Re: HD-DEN-14000-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:27 pm

Sean Nash

More
Re: HD-DEN-14000-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:27 pm

Sean Nash

More
Re: HD-DEN-14000-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:26 pm

Sean Nash

More
Re: HD-DEN-14000-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:23 pm

Sean Nash

More
Re: HD-DEN-14000-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:22 pm

Sean Nash

More
Re: HD-DEN-14000-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-02-13 01:06 -0800