hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 08 Nov 2022
9:24 am

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Update DialInFlow.c

Options
    • -3
    • +0
    ./App/Controllers/DialInFlow.c
9:05 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:02 am

Sean Nash

Remove extra blank line. Should only be 1 blank line between functions.

Remove extra blank line. Should only be 1 blank line between functions.

8:56 am

Sean Nash

It is not technically a boolean - it is a BOOL which is our implementation of a boolean (TRUE = 1, FALSE = 0). If we don't explicitly compare a BOOL to TRUE, compiler will consider any non-zero val...

It is not technically a boolean - it is a BOOL which is our implementation of a boolean (TRUE = 1, FALSE = 0).
If we don't explicitly compare a BOOL to TRUE, compiler will consider any non-zero value to be TRUE. So if memory is overwritten/corrupted to a random non-zero value, it would satisfy "if ( isSyringePumpPreLoaded() )" and s.w would do the wrong thing.
For extra safety, we prefer to compare to TRUE (1) or FALSE (0) depending on what would be safer.
For example, in this case we are deciding whether to seek plunger or alarm. We only seek plunger if the syringe pump was pre-loaded. It is safer to check pre-loaded flag is TRUE (1) to seek and ANY OTHER VALUE would alarm.
Also, when using the "==" compare operator, we will put the literal first. It looks awkward, but if we accidently use the "=" operator by mistake the compiler will give us a syntax error which saves us from having a tricky bug to fix later.

Monday 07 Nov 2022
6:25 pm

Darren Cox <darren_m@cox.net>

DEN-14170 Remove check for Syringe in Preload request. Preload function does this test and sets alarm properly.

Options
    • -1
    • +1
    ./App/Controllers/SyringePump.c
2:33 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Update DialInFlow.c

Options
    • -2
    • +2
    ./App/Controllers/DialInFlow.c
2:08 pm

Dong Nguyen

Done. I move the alarm ALARM_ID_HD_DIAL_IN_FLOW_CHECK_FAILURE check to the function checkDialInPumpFlowRate(), which calls function getMeasuredDialInFlowRate() and function getDGDialysateFlowRateLM...

Done.
I move the alarm ALARM_ID_HD_DIAL_IN_FLOW_CHECK_FAILURE check to the function checkDialInPumpFlowRate(), which calls function getMeasuredDialInFlowRate() and function getDGDialysateFlowRateLMin() instead of using filteredDialinFlowMeterReading.

1:51 pm

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Update DialInFlow.c

Options
    • -15
    • +18
    ./App/Controllers/DialInFlow.c
11:27 am

Dara Navaei

This is here so both stacks can use it.

This is here so both stacks can use it.

11:27 am

Dara Navaei

Done.

Done.

11:04 am

Dong Nguyen

Done. Now use the function getMeasuredDialInFlowRate() instead of using filteredDialinFlowMeterReading.

Done. Now use the function getMeasuredDialInFlowRate() instead of using filteredDialinFlowMeterReading.

10:56 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:55 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:52 am

Dara Navaei

DEN-14175 merged staging and resolved the conflicts

Options
    • -3
    • +4
    ./App/Controllers/DGInterface.c
    • -3
    • +14
    ./App/Controllers/PresOccl.c
    • -48
    • +155
    ./App/Modes/ModePreTreat.c
    • -2
    • +2
    ./App/Modes/Prime.c
    • -76
    • +217
    ./App/Modes/SelfTests.c
10:52 am

Michael Garthwaite and wbracken  (deleted user)

10:52 am

Dong Nguyen <dnguyen@diality.com>

DEN-14150: Update DialInFlow.c

Options
    • -1
    • +0
    ./App/Controllers/DialInFlow.c
10:48 am

Dong Nguyen

Removed.

Removed.

10:45 am

Dong Nguyen

I already removed the test code (at line 116). I just checked and it was removed in my local version. I already pushed DEN-14150. Please pull it gain to see if the test code is still there. Thank you.

I already removed the test code (at line 116).
I just checked and it was removed in my local version. I already pushed DEN-14150.
Please pull it gain to see if the test code is still there.
Thank you.

10:44 am

Sean Nash

Why is this in utilities module? Doesn't it make more sense in fpga module?

Why is this in utilities module? Doesn't it make more sense in fpga module?

10:43 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:42 am

Sean Nash

Remove blank line.

Remove blank line.

10:41 am

Sean Nash

None of these structures appear to require packing - all 32-bit fields.

None of these structures appear to require packing - all 32-bit fields.

10:40 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:40 am

Sean Nash

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:34 am

Dara Navaei

DEN-14175 addressed the code review comments

Options
    • -2
    • +0
    ./App/Modes/ModePreTreat.c
    • -2
    • +3
    ./App/Modes/TreatmentEnd.c
10:28 am

Michael Garthwaite

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:26 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:25 am

Sean Nash

Remove test code.

Remove test code.