Activity hdfirmware/firmware

2:02 pm

Dara Navaei

More
HD-DEN-13154-1
started review

HD-DEN-13154_Heparin Syringe Empty Position Incorrect

12:01 pm

Dara Navaei

More
HD-DEN-14457-2
started review

HD-DEN-14457_Reservoir Drains Before Treatment With Pre Treatment Build Flags Off

2:39 pm

Sean Nash , Dara Navaei and Michael Garthwaite

More
HD-DEN-14790-1
finished reviewing

2:05 pm

Dara Navaei

More
HD-DEN-14790-1
started review

HD-DEN-14790_Alarm 199 Occurs Intermittently During Blood Prime And Treatment

11:38 am

Sean Nash and Dara Navaei

More
HD-DEN-14459-1
finished reviewing

11:01 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

10:46 am

Michael Garthwaite

More
Re: HD-DEN-14459-1
replied to Sean Nash

Fixed. Thanks!

10:34 am

Are there any other ways to exit this state without zeroing this counter (e.g. going to manual control in first if above)? Generally difficult to get all of the places where exiting a state. Safer ...

Are there any other ways to exit this state without zeroing this counter (e.g. going to manual control in first if above)? Generally difficult to get all of the places where exiting a state. Safer to reset things on entry (i.e. line 359 above).

10:28 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

10:24 am

Michael Garthwaite

More
Re: HD-DEN-14459-1
replied to Sean Nash

This is the only position where its unassigned (changed due to revert below). The counter itself is more controller level than driver level as the persistence counter may be different in other mode...

This is the only position where its unassigned (changed due to revert below). The counter itself is more controller level than driver level as the persistence counter may be different in other modes of operation. This counter is specifically here to hold the air pump on 100ms after upper level is detecting air. Should this check be moved to airpump.c?

10:21 am

Michael Garthwaite

Reverted. Thanks!

10:11 am

Michael Garthwaite

More
Re: HD-DEN-14459-1
replied to Sean Nash

it would take one state cycle ( 50ms ) to do that. The air pump can't drive the fluid level that fast. We can keep it for redundancy but the system would have much bigger problems going on for that...

it would take one state cycle ( 50ms ) to do that. The air pump can't drive the fluid level that fast. We can keep it for redundancy but the system would have much bigger problems going on for that to happen.

10:08 am

Sean Nash

More
Re: HD-DEN-14459-1
commented on review

Unlikely that we would go from Liq/Liq to Air/Air, but if we did, we would no longer turn the air pump off with this code removed. Should we keep it?

10:06 am

Sean Nash

More
Re: HD-DEN-14459-1
commented on review

Safer to zero this when you turn the pump on (could be done in one place in setAirPumpState function) - that way you don't have to worry about zeroing it everywhere you stop the pump.

4:43 pm