hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 08 Mar 2023
9:44 am

Sean Nash

DEN-13154: Addressed code review comments.

Options
    • -1
    • +1
    ./App/Controllers/BloodFlow.c
    • -1
    • +1
    ./App/Controllers/BloodFlow.h
    • -1
    • +1
    ./App/Controllers/DialInFlow.c
    • -1
    • +1
    ./App/Controllers/DialInFlow.h
9:42 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/HDCommon.h
9:42 am

Michael Garthwaite

FALSE will be determined by our automagic script to be ACK_REQUIRED in the excel sheet. This will cause discrepancies between the readers of that sheet and what the FW does.

FALSE will be determined by our automagic script to be ACK_REQUIRED in the excel sheet. This will cause discrepancies between the readers of that sheet and what the FW does.

9:41 am

Sean Nash

Fixed.

Fixed.

9:41 am

Sean Nash

Variable is also updated by receipts of DG flow broadcasts. I believe it is overridable on DG side.

Variable is also updated by receipts of DG flow broadcasts. I believe it is overridable on DG side.

9:38 am

Sean Nash

Concern was originally just for retract due to highest speed. We ended up reducing retract speed to reduce likelihood of stalls. Still a good idea to check for it though and since retract, preload ...

Concern was originally just for retract due to highest speed. We ended up reducing retract speed to reduce likelihood of stalls. Still a good idea to check for it though and since retract, preload and seek all share same relatively high speed, these are the ops that have the check. For bolus and continuous, should not stall at these speeds and would catch with rate alarm if it did.

9:36 am

Michael Garthwaite

Merge branch 'DEN-14689-messaging-bugs' into develop

Options
    • -18
    • +18
    ./App/Services/SystemCommMessages.c
9:36 am

Michael Garthwaite

DEN-14689: updated naming msg_id naming in relation to common changes

Options
    • -7
    • +7
    ./App/Services/SystemComm.c
    • -18
    • +18
    ./App/Services/SystemCommMessages.c
9:33 am

Sean Nash

Fixed.

Fixed.

9:32 am

Sean Nash

Fixed.

Fixed.

9:30 am

Sean Nash

Fixed.

Fixed.

9:01 am

Michael Garthwaite

Merge branch 'staging' into DEN-14689-messaging-bugs

Options
    • -13
    • +48
    ./App/Modes/ModePreTreat.c
    • -5
    • +5
    ./App/Services/SystemCommMessages.c
Tuesday 07 Mar 2023
4:55 pm

Michael Garthwaite

Fixed?

Fixed?

4:53 pm

Michael Garthwaite

To answer this and comment below: above_high_safety_range = temp > 46 above_low_safety_range = temp > 42 above_target_temp = target + 4 below_target_temp = target - 4 below_low_safety_range = temp...

To answer this and comment below:

above_high_safety_range = temp > 46
above_low_safety_range = temp > 42
above_target_temp = target + 4
below_target_temp = target - 4
below_low_safety_range = temp < 33

I did not see any specification regarding to separate or not to separate. Original functionality had separate triggers. Respective PRS's state OR between the two triggers.
I think it would be clear to for us in terms of debugging to see which alarm is triggered since on the low side, temp - 4 would be lower than 33, (31).

Wording may be unclear. Im up for suggestions to help clarify the alarm differences.

4:42 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

4:35 pm

Michael Garthwaite

Shouldnt this be set to 0U instead of 0.0F?

Shouldnt this be set to 0U instead of 0.0F?

4:35 pm

Michael Garthwaite

This should be U32.

This should be U32.

4:35 pm

Michael Garthwaite

This should be U32.

This should be U32.

4:34 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:33 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

4:32 pm

Michael Garthwaite

Should we check for stall in bolus & continuous states?

Should we check for stall in bolus & continuous states?

4:27 pm

Michael Garthwaite

seems odd to create a variable just for it to be returned. Is this value supposed to be overridable?

seems odd to create a variable just for it to be returned. Is this value supposed to be overridable?

4:25 pm

Michael Garthwaite

Shouldnt this be set to 0U instead of 0.0F?

Shouldnt this be set to 0U instead of 0.0F?

4:01 pm

Dara Navaei

HD-DEN-14906_Dialyzer DE Prime
HD-DEN-14906_Dialyzer DE Prime
3:47 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/HDCommon.h
3:40 pm

Sean Nash

Fixed merge conflict.

Options
    • -10
    • +33
    ./App/Controllers/DGInterface.c
    • -13
    • +3
    ./App/Controllers/DGInterface.h
    • -6
    • +5
    ./App/Controllers/DialInFlow.c
    • -0
    • +8
    ./App/Controllers/SyringePump.c
    • -1
    • +1
    ./App/Services/SystemCommMessages.c
3:14 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/HDCommon.h
3:13 pm

Michael Garthwaite

Merge branch 'DEN-14830-incorrect-dialysate-temperature-alarm-triggered' into develop

Options
    • -20
    • +53
    ./App/Controllers/DGInterface.c
    • -11
    • +12
    ./App/Controllers/DGInterface.h
    • -6
    • +10
    ./App/Modes/ModeInitPOST.c
    • -13
    • +48
    ./App/Modes/ModePreTreat.c
    • -2
    • +2
    ./App/Services/SystemCommMessages.c
3:13 pm

Michael Garthwaite

more compiler fixes

Options
    • -0
    • +1
    ./App/Controllers/DGInterface.h
3:10 pm

Michael Garthwaite

DEN-14830: compiler fixes for develop.

Options
    • -0
    • +10
    ./App/Controllers/DGInterface.h