hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 May 2023
11:03 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-15104-hd-fpga-communications

# Conflicts:

# firmware/App/Controllers/BloodFlow.c

Options
    • -9
    • +5
    ./App/Controllers/BloodFlow.c
    • -9
    • +5
    ./App/Controllers/DialInFlow.c
    • -3
    • +3
    ./App/Controllers/PresOccl.c
    • -4
    • +6
    ./App/Controllers/Valves.c
    • -3
    • +3
    ./App/Services/AlarmMgmtSWFaults.h
11:02 am

Sean Nash

Remove blank line.

Remove blank line.

11:01 am

Sean Nash

Use enums instead of literals.

Use enums instead of literals.

11:01 am

Sean Nash

Don't we have an enum for these values?

Don't we have an enum for these values?

10:58 am

Sean Nash

Is there more to be done here (TODO)?

Is there more to be done here (TODO)?

10:56 am

Sean Nash

I think these variable declarations should stay here. Why move to function?

I think these variable declarations should stay here. Why move to function?

10:55 am

dcox  (deleted user)

it is done in the next state - user confirm. May be a better idea to move this pump & heater on to that state after user confirm.

it is done in the next state - user confirm. May be a better idea to move this pump & heater on to that state after user confirm.

10:55 am

Sean Nash

This is HD f/w. Why are you looking at DG mode?

This is HD f/w. Why are you looking at DG mode?

10:54 am

dcox  (deleted user)

I did not want to have the pump turning on/off if opened more than once. Stop while the user performs the action, then turn on when they are done. Maybe wait to turn on until user confirm.

I did not want to have the pump turning on/off if opened more than once. Stop while the user performs the action, then turn on when they are done. Maybe wait to turn on until user confirm.

10:53 am

Sean Nash

Why aren't these declared at top of file and initialized in init function like everything else.

Why aren't these declared at top of file and initialized in init function like everything else.

10:46 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

DEN-15014 Changes to support FPGA testing. Move FE and OE SCI faults to FPGA communications alarm.

Options
    • -1172
    • +1172
    ./App/Controllers/BloodFlow.c
    • -2
    • +12
    ./App/Controllers/BloodLeak.c
    • -1204
    • +1204
    ./App/Controllers/DialInFlow.c
    • -1
    • +1
    ./App/Controllers/PresOccl.c
    • -52
    • +49
    ./App/Controllers/Valves.c
    • -2
    • +2
    ./App/Services/AlarmMgmtSWFaults.h
    • -0
    • +38
    ./App/Services/FPGA.c
    • -16
    • +24
    ./App/Services/Interrupts.c
    • -0
    • +2
    ./App/Services/Interrupts.h
10:46 am

Michael Garthwaite

DIAL-251: reworked events for operation status and operation state transitions

Options
    • -1
    • +1
    ./App/Modes/ConsumableSelfTest.c
    • -0
    • +3
    ./App/Modes/Dialysis.c
    • -0
    • +1
    ./App/Modes/ModeFault.c
    • -1
    • +2
    ./App/Modes/ModePostTreat.c
    • -0
    • +9
    ./App/Modes/ModePreTreat.c
    • -0
    • +1
    ./App/Modes/ModeService.c
    • -0
    • +2
    ./App/Modes/ModeStandby.c
    • -0
    • +1
    ./App/Modes/ModeTreatment.c
    • -5
    • +2
    ./App/Modes/ModeTreatmentParams.c
    • -4
    • +29
    ./App/Modes/OperationModes.c
    • -0
    • +3
    ./App/Modes/OperationModes.h
    • -0
    • +1
    ./App/Modes/PreTreatmentRecirc.c
    • -0
    • +1
    ./App/Modes/Prime.c
    • -0
    • +1
    ./App/Modes/Rinseback.c
    • -0
    • +1
    ./App/Modes/SampleWater.c
  16. … 4 more files in changeset.
10:35 am

Sean Nash

Why is this in two places? And why set every 10ms when it appears to be constant?

Why is this in two places? And why set every 10ms when it appears to be constant?

10:34 am

Sean Nash

This doesn't seem to ever change. Why not just initialize this value once on reset?

This doesn't seem to ever change. Why not just initialize this value once on reset?

10:33 am

Sean Nash

Make U32.

Make U32.

10:25 am

Sean Nash

Should we have an else to turn pump and heater back on when door is closed?

Should we have an else to turn pump and heater back on when door is closed?

10:24 am

Sean Nash

Since pump is going to be on and next state is not calling your door check function, should we call doorClosedRequired( TRUE, TRUE ) here? Or next state could call your door check function to handl...

Since pump is going to be on and next state is not calling your door check function, should we call doorClosedRequired( TRUE, TRUE ) here? Or next state could call your door check function to handle it.

10:07 am

Sean Nash

I think this whole function should be moved down into test support functions section.

I think this whole function should be moved down into test support functions section.

10:03 am

Sean Nash

I think there are cases where rsrvrCmd is not set and so we should not be calling this function in those cases.

I think there are cases where rsrvrCmd is not set and so we should not be calling this function in those cases.

10:02 am

Sean Nash

case body should be indented.

case body should be indented.

10:00 am

Sean Nash

Use new #define from comment above.

Use new #define from comment above.

9:59 am

Sean Nash

If res 1 is active, you will not set rsrvrCmd to anything but you are still sending command below.

If res 1 is active, you will not set rsrvrCmd to anything but you are still sending command below.

9:57 am

Sean Nash

Use new #define (from comment above).

Use new #define (from comment above).

9:56 am

Sean Nash

FULL volume is 1500. Unlikely to be less than 1500 as fills tend to overshoot a little (they don't stop until at least 1500). Add new #define for a max start value - maybe 1575 and use that instead.

FULL volume is 1500. Unlikely to be less than 1500 as fills tend to overshoot a little (they don't stop until at least 1500). Add new #define for a max start value - maybe 1575 and use that instead.

9:49 am

Sean Nash

Update inputs

Update inputs

9:47 am

Sean Nash

Comment for what we're doing here.

Comment for what we're doing here.

9:43 am

Sean Nash

Put this prototype declaration last w/ blank line before.

Put this prototype declaration last w/ blank line before.

8:43 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/HDCommon.h
8:43 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Drivers/Battery.c
8:40 am

Michael Garthwaite