firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Not sure we need this in this state if we require door to be closed in this state.

Not sure we need this in this state if we require door to be closed in this state.

Once we leave this state, we've done the door open/close that we were looking for - so should start requiring door to be closed from this point forward.

Once we leave this state, we've done the door open/close that we were looking for - so should start requiring door to be closed from this point forward.

I think we still want to get credit for opening the door in this state - and so need to be okay with door opening (not required to be closed) and so probably should be calling your door handler here.

I think we still want to get credit for opening the door in this state - and so need to be okay with door opening (not required to be closed) and so probably should be calling your door handler here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Moved to here from function.

Moved to here from function.

Done

Done

Done

Done

Done

Done

I changed the code.

I changed the code.

Done

Done

Done

Done

I was thinking to send the command anyways. If the active reservoir is what we need, it will be ignored. But I changed the code.

I was thinking to send the command anyways. If the active reservoir is what we need, it will be ignored. But I changed the code.

Done

Done

Done. This indentation was picked by Code Composer Studios though.

Done. This indentation was picked by Code Composer Studios though.

Done

Done

No longer needed.

No longer needed.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Per my other comment, please avoid in-function static variables.

Per my other comment, please avoid in-function static variables.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.