Activity hdfirmware/firmware

Tree
Accordion

Stats

Commits this week: 3

Total Committers:	17
Last Commit:	29 Apr
Commits this week:	3

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 16 May 2023

9:57 am

Michael Garthwaite

More
139d7ba
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 224 more HD-DEN-15196-2

Merge branch 'staging' into DEN-15196-DIAL-251

- -3
- +3
./App/Modes/SelfTests.c
- History
- Source
- Diff
./App/Modes/SelfTests.c

9:32 am

wbracken (deleted user) , jtaylor (deleted user) and Michael Garthwaite

More
HD-DIAL-252-1
finished reviewing

9:17 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Sean Nash

More
Re: HD-DEN-15229-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:13 am

Sean Nash

More
Re: HD-DEN-15229-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:12 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:56 am

Sean Nash

More
HD-DEN-15229-1
finished reviewing

8:34 am

Dara Navaei

More
6aa0022
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 223 more HD-DEN-15274-1

DEN-15274 fixed a typo

- -1
- +1
./App/Modes/ModePreTreat.c
- History
- Source
- Diff
./App/Modes/ModePreTreat.c

8:33 am

Dara Navaei

More
602eb07
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
./App/HDCommon.h
- History
- Source
- Diff
./App/HDCommon.h

8:33 am

Dara Navaei

More
dd092a4
changed 1 file
develop

Merge branch 'DEN-15274-hd_dg_test_configuration_setup' into develop

- -88
- +74
./App/Modes/ModePreTreat.c
- History
- Source
- Diff
./App/Modes/ModePreTreat.c

8:30 am

Dara Navaei

More
f9c0896
changed 2 files
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 223 more HD-DEN-15274-1

Merge branch 'staging' into DEN-15274-hd_dg_test_configuration_setup

- -54
- +50
./App/Controllers/Valves.c
- History
- Source
- Diff
./App/Controllers/Valves.c
- -3
- +3
./App/Modes/SelfTests.c
- History
- Source
- Diff
./App/Modes/SelfTests.c

Monday 15 May 2023

8:58 pm

Dara Navaei

More
b6899d1
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
./App/HDCommon.h
- History
- Source
- Diff
./App/HDCommon.h

8:15 pm

Dara Navaei

More
b341967
changed 2 files
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 223 more HD-DEN-15274-1

DEN-15274 addressed the code review comment

- -3
- +4
./App/Controllers/Valves.c
- History
- Source
- Diff
./App/Controllers/Valves.c
- -88
- +74
./App/Modes/ModePreTreat.c
- History
- Source
- Diff
./App/Modes/ModePreTreat.c

8:15 pm

Dara Navaei

More
Re: HD-DEN-15274-1
replied to Sean Nash

Done

Done

8:14 pm

Dara Navaei

More
Re: HD-DEN-15274-1
replied to Sean Nash

Done

Done

6:03 pm

Dara Navaei

More
HD-DIAL-252-1
started review

HD-DIAL-252_Request Create Dialin Command TO Enable Air Bubble Alarm IN Service Mode Air Bubble

HD-DIAL-252_Request Create Dialin Command TO Enable Air Bubble Alarm IN Service Mode Air Bubble

5:30 pm

Dara Navaei

More
3f2f7d4
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
./App/HDCommon.h
- History
- Source
- Diff
./App/HDCommon.h

5:30 pm

Sean Nash

More
94af475
changed 2 files
develop

Fixed merge conflicts from DIAL-252.

- -2
- +2
./App/Controllers/PresOccl.c
- History
- Source
- Diff
./App/Controllers/PresOccl.c
- -1
- +30
./App/Modes/ModeStandby.c
- History
- Source
- Diff
./App/Modes/ModeStandby.c

5:25 pm

Sean Nash

More
80c4b42
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 225 more HD-DIAL-252-1

DIAL-252: Update to standby mode to handle alarms w/ stop property (will close valves).

- -1
- +30
./App/Modes/ModeStandby.c
- History
- Source
- Diff
./App/Modes/ModeStandby.c

4:40 pm

dcox (deleted user)

More
Re: HD-DEN-15229-1
replied to Sean Nash

Correct, no longer required. Removed.

Correct, no longer required. Removed.

4:35 pm

dcox (deleted user)

More
Re: HD-DEN-15229-1
replied to Sean Nash

Reset proper flag.

Reset proper flag.

4:32 pm

Darren Cox <darren_m@cox.net>

More
85c561f
changed 1 file
master, DEN-13865-fw-duplicate-alarms-occur-during-post-treatment-rinseback-and-block-workflow and 225 more HD-DEN-15229-1

DEN-15229 Code review changes. Clear flag, no need to check door when required to be shut.

- -3
- +1
./App/Modes/ModePreTreat.c
- History
- Source
- Diff
./App/Modes/ModePreTreat.c

4:16 pm

Sean Nash

More
Re: HD-DEN-15229-1
replied to dcox (deleted user)

We are (I think now) allowing door open in first 2 states (UF and invert dialyzer), so should not be getting door open alarm when UI is prompting user to invert dialyzer. When we get to 3rd state (...

We are (I think now) allowing door open in first 2 states (UF and invert dialyzer), so should not be getting door open alarm when UI is prompting user to invert dialyzer. When we get to 3rd state (where we start requiring door to be closed), we are looking for user to connect patient and confirm. UI should be following along with our states and showing appropriate screens.
RESOLVED in CODE WALKTHROUGH.

4:06 pm

Sean Nash

More
Re: HD-DEN-15229-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

4:06 pm

Sean Nash

More
Re: HD-DEN-15229-1
replied to dcox (deleted user)

Doesn't look removed. I'm talking about the call to handlePatientConnectionDoorOpened(). Do we need this now that door closed is required (as set in prior state)?

Doesn't look removed. I'm talking about the call to handlePatientConnectionDoorOpened(). Do we need this now that door closed is required (as set in prior state)?

4:01 pm

Sean Nash

More
Re: HD-DEN-15229-1
replied to dcox (deleted user)

Doesn't make sense to reset in previous state. You're resetting door opened flag there. I'm talking about patient connect confirm flag used in if statement above.

Doesn't make sense to reset in previous state. You're resetting door opened flag there. I'm talking about patient connect confirm flag used in if statement above.

3:59 pm

Sean Nash

More
Re: HD-DEN-15229-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:59 pm

Sean Nash

More
Re: HD-DEN-15229-1
replied to dcox (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:52 pm

Dara Navaei

More
4f83c79
changed 1 file
develop

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

- -1
- +1
./App/HDCommon.h
- History
- Source
- Diff
./App/HDCommon.h

3:51 pm

Dara Navaei

More
5003153
changed 1 file
develop

Merge branch 'DEN-15274-hd_dg_test_configuration_setup' into develop

- -2
- +2
./App/Modes/ModePreTreat.c
- History
- Source
- Diff
./App/Modes/ModePreTreat.c

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-30 08:23 -0700