hdfirmware

firmware

Clone Tools

Stats

Commits this week: 3
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 03 Aug 2023
4:23 pm

Sean Nash

I don't think you need to repeat @details Inputs: and @details Outputs:. Only need those for first row. See other functions for example.

I don't think you need to repeat @details Inputs: and @details Outputs:. Only need those for first row. See other functions for example.

3:28 pm

Sean Nash

Blank line before banner comment.

Blank line before banner comment.

3:24 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:24 pm

Sean Nash

Still more here than should be. Trimmer heater is being turned off twice now. DPo should already be stopped. And VBA/VBV should be handled by state machine I would think unless user stop requiremen...

Still more here than should be. Trimmer heater is being turned off twice now. DPo should already be stopped. And VBA/VBV should be handled by state machine I would think unless user stop requirement talks about valves too - and even if so, valves should only close when user stop alarm is active - nothing to do with recirc properties in alarms.

3:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:17 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:17 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:16 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:34 pm

jtaylor  (deleted user)

Done.

Done.

1:08 pm

jtaylor  (deleted user)

Change postponed for further testing. No change in BloodPumps. Done.

Change postponed for further testing. No change in BloodPumps.
Done.

1:07 pm

jtaylor  (deleted user)

Change postponed for further testing. No change in DialIn. Done.

Change postponed for further testing. No change in DialIn.
Done.

1:07 pm

jtaylor  (deleted user)

Change postponed for further testing. No change in DialOut. DONE.

Change postponed for further testing. No change in DialOut.
DONE.

1:06 pm

jtaylor  (deleted user)

Done.

Done.

12:57 pm

jtaylor  (deleted user)

Done.

Done.

12:57 pm

jtaylor  (deleted user)

BP is turned on in the resume from stop, and patient reconnect states, .100ml/min. Removed anything that is off, and stays off in recirculation. Done.

BP is turned on in the resume from stop, and patient reconnect states, .100ml/min. Removed anything that is off, and stays off in recirculation.
Done.

12:55 pm

jtaylor  (deleted user)

s/b recirculate. Done.

s/b recirculate. Done.

12:53 pm

jtaylor  (deleted user)

Done

Done

12:50 pm

jtaylor  (deleted user)

Done.

Done.

12:49 pm

Sean Nash

Agree that BP is on in the recirc state. Forget 2nd comment - focus on multiple function calls comment.

Agree that BP is on in the recirc state. Forget 2nd comment - focus on multiple function calls comment.

12:11 pm

jtaylor  (deleted user)

In treatment recirc, BP is turned on in the resume from stop, and patient reconnect states, .100ml/min. It seems as though the user stop should turn off both pumps.

In treatment recirc, BP is turned on in the resume from stop, and patient reconnect states, .100ml/min. It seems as though the user stop should turn off both pumps.

12:04 pm

Dara Navaei

HD-DEN-15927_Alarm 127 Low Venous Pressure Triggers Post Treatment
HD-DEN-15927_Alarm 127 Low Venous Pressure Triggers Post Treatment
11:16 am

Sean Nash

Add inputs.

Add inputs.

9:52 am

Sean Nash

9:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:47 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:46 am

Sean Nash

Why does this function return/set state? It is not a state handler function.

Why does this function return/set state? It is not a state handler function.

9:45 am

Sean Nash

Call these blocked functions once and save values to local vars. Use local vars throughout function so you don't have to keep calling the functions. Also, why are we looking at blood recirc at all...

Call these blocked functions once and save values to local vars. Use local vars throughout function so you don't have to keep calling the functions.

Also, why are we looking at blood recirc at all? BP is never on in recirc states so no need to manage blocking blood recirculation.

9:43 am

Sean Nash

Should not go to stopped state - let state machine manage state transitions. Just stop DPi and trimmer heater.

Should not go to stopped state - let state machine manage state transitions. Just stop DPi and trimmer heater.