hdfirmware

firmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 18 Aug 2023
8:00 am

Michael Garthwaite

DEN-16164: Removed reservoir weight check in fill settle state

Options
    • -1
    • +1
    ./App/Services/Reservoirs.c
Thursday 17 Aug 2023
6:45 pm

Michael Garthwaite

DEN-14706: HD pending ACK override message handling and implementation.

Options
    • -3
    • +64
    ./App/Services/SystemComm.c
    • -1
    • +3
    ./App/Services/SystemComm.h
    • -0
    • +32
    ./App/Services/SystemCommMessages.c
    • -0
    • +3
    ./App/Services/SystemCommMessages.h
6:05 pm

Dara Navaei

HD-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
HD-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked
2:21 pm

Michael Garthwaite

DEN-16164: code review comments.

Options
    • -3
    • +3
    ./App/Modes/SelfTests.c
2:21 pm

Michael Garthwaite

dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

dryPressureTestsCompleted is already in this header. dryPressureTestsCompleted was added to setupForSelfTestStop() header.

1:44 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:12 pm

wbracken  (deleted user)

Add dryPressureTestsCompleted to header.

Add dryPressureTestsCompleted to header.

1:01 pm

Sean Nash

12:56 pm

Michael Garthwaite

Updated to handle any active alarm if we havent passed pressure tests. I also modified the logic to where this valve change should only happen in d.s.p.t.

Updated to handle any active alarm if we havent passed pressure tests. I also modified the logic to where this valve change should only happen in d.s.p.t.

12:55 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:54 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/HDCommon.h
12:54 pm

Michael Garthwaite

DEN-16164: compiler fixes.

Options
    • -1
    • +1
    ./App/Modes/SelfTests.c
11:28 am

Michael Garthwaite

DEN-16164: Code review comments. Changed stop state for handle all alarms for depressurized Inverse logic for setting VBA to Pos B during dry self test failures and ensure HD only does it during dry self test.

Options
    • -8
    • +11
    ./App/Modes/SelfTests.c
10:59 am

jtaylor  (deleted user)

10:58 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/HDCommon.h
10:58 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./App/Modes/Rinseback.c
9:40 am

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/HDCommon.h
9:39 am

James Walter Taylor <jtaylor@diality.com>

Merge remote-tracking branch 'origin/DEN-15630-vtchd-598-transitions-not-found' into develop

Options
    • -11
    • +9
    ./App/Controllers/BloodLeak.c
    • -2
    • +2
    ./App/Controllers/PresOccl.c
    • -1
    • +1
    ./App/Controllers/SyringePump.c
    • -1
    • +1
    ./App/Modes/Dialysis.c
    • -2
    • +35
    ./App/Services/SystemCommMessages.c
    • -2
    • +5
    ./App/Services/SystemCommMessages.h
9:35 am

James Walter Taylor <jtaylor@diality.com>

DEN-15630-vtchd-598-transitions-not-found

Added code in pre-treatment prime state to allow pause in start state.

Options
    • -2
    • +6
    ./App/Modes/Prime.c
9:10 am

Sean Nash

9:10 am

Sean Nash

8:35 am

Sean Nash

8:35 am

Sean Nash

8:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:22 am

jtaylor  (deleted user)

As you pointed out earlier, rinsebackTimerCtr is set to zero in states where BP is running, so the if condition would only be TRUE (rinsebackTimerCtr > 0) if BP is not running.

As you pointed out earlier, rinsebackTimerCtr is set to zero in states where BP is running, so the if condition would only be TRUE (rinsebackTimerCtr > 0) if BP is not running.

Wednesday 16 Aug 2023
4:42 pm

Sean Nash

You removed the if (great), but I don't see that you replaced it with BP stopped check. I don't think we want a countdown if BP is running (blood not sitting).

You removed the if (great), but I don't see that you replaced it with BP stopped check. I don't think we want a countdown if BP is running (blood not sitting).

3:46 pm

Dara Navaei

Bamboo Commit: Updated HDCommon.h with build versions from Bamboo

Options
    • -1
    • +1
    ./App/HDCommon.h
3:37 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Simplification.

Options
    • -8
    • +4
    ./App/Modes/Rinseback.c
3:34 pm

dcox  (deleted user)

3:34 pm

James Walter Taylor <jtaylor@diality.com>

DEN-15994-rinseback-5-minute-timer-does-not-count-down

Updated for CR comments.

Options
    • -1
    • +2
    ./App/Modes/Rinseback.c