compounds

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
It is a little bit concerning: Could you please test/describe the following scenarios: *What if we have more than one Heparin type supported? *What if none (incorrectly) has been defined in the c...

It is a little bit concerning:
Could you please test/describe the following scenarios:

  • What if we have more than one Heparin type supported?
  • What if none (incorrectly) has been defined in the configuration (do we get an index out of bounds)?
We will address this later on code modularizations. RESOLVED.

We will address this later on code modularizations.
RESOLVED.

I believe any related view could have provided a timer since they are inherited from QObject. That is fine for now but consider using our C++ view codes for such a thing.

I believe any related view could have provided a timer since they are inherited from QObject.
That is fine for now but consider using our C++ view codes for such a thing.

Thank you .

Thank you .

pop(null) will unwind the stack and go back to main treatment. I tested and added a comment in code as well

pop(null) will unwind the stack and go back to main treatment. I tested and added a comment in code as well

updated to statusColor

updated to statusColor

added

added

used for the 1 min user activity timeout to move back to main treatment from heparin.. Its a requirement LEAHI-PRS-666

used for the 1 min user activity timeout to move back to main treatment from heparin.. Its a requirement LEAHI-PRS-666

updated

updated

updated

updated

yes good catch. updated

yes good catch. updated

moved

moved

removed

removed

done

done

Please align.

Please align.

Please use the mainTreatment screen as the default. If necessary, could you create a specific enum to clean up the stack (which I do not believe is needed.)

Please use the mainTreatment screen as the default.
If necessary, could you create a specific enum to clean up the stack (which I do not believe is needed.)

You no longer need this after you move the heparin screen from the sections folder.

You no longer need this after you move the heparin screen from the sections folder.

Shouldn't ""Unfractionated 1000"" come from the configurations?

Shouldn't ""Unfractionated 1000"" come from the configurations?

We should add the qsTr()

We should add the qsTr()

Move this outside of the sections folder, since it is no longer a section and has its own dedicated screen.

Move this outside of the sections folder, since it is no longer a section and has its own dedicated screen.

We should use "min" for minutes and not "mins". Same for "hrs" => "hr".

We should use "min" for minutes and not "mins".
Same for "hrs" => "hr".

What is this file used for? And please add a brief description for the file comment.

What is this file used for?
And please add a brief description for the file comment.

Please put comments for your division number.

Please put comments for your division number.

statusColor is so general, but is bound to the heparinStatusColor. Please either change the status color to be heparin only or change the heparinStatus Color name to be more general. The latter is ...

statusColor is so general, but is bound to the heparinStatusColor.
Please either change the status color to be heparin only or change the heparinStatus Color name to be more general.
The latter is better.

okay will do

okay will do

okay acknowledged

okay acknowledged

No Action For Now: Same for the vError param: https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-2727-1CFR-76762

No Action For Now:
Same for the vError param:
https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-2727-1CFR-76762

No Action For Now: Please always use mError, since it is local to the script function, to be consistent with the rest. Also, usually it is a number, not a bool. It is fine for now, but later we sh...

No Action For Now:
Please always use mError, since it is local to the script function, to be consistent with the rest.
Also, usually it is a number, not a bool.

It is fine for now, but later we should create a decorator to cover these types of similarities.

LDT-2825-institutional

Stashed work

    • -0
    • +201
    ./InstitutionalContainer.qml
    • -0
    • +157
    ./ValueAdjusterCustom.qml
  1. … 55 more files in changeset.
LEAHI-APPLICATION-LDT-2957_Heparin - SW - 01 - R&I
LEAHI-APPLICATION-LDT-2957_Heparin - SW - 01 - R&I