Activity leahi-application/sources/gui/qml/dialogs/diagnostics/DiagnosticsTD.qml

5:18 pm

Tiffany Mejia

More
ceb3d29
changed 3 files
LDT-2428-Onboarding-Test-Message-and-Diag-Screen-View LEAHI-APPLICATION-LDT-2428-1

LDT-2428: Onboarding Test Message & Diag Screen View

- Make change for visibility in diagnostics screen

- Remove comments in model.

- -4
- +2
./DiagnosticsTD.qml
- History
- Source
- Diff
./DiagnosticsTD.qml
… 2 more files in changeset.

4:17 pm

Tiffany Mejia

More
62d2c59
changed 13 files
LDT-2428-Onboarding-Test-Message-and-Diag-Screen-View LEAHI-APPLICATION-LDT-2428-1

LDT-2428: Onboarding Test Message & Diag Screen View

- add model and view for message 0x7000

- Add to TD diagnostics screen and able to get output

- working on conditional view when message is received.

- -0
- +16
./DiagnosticsTD.qml
- History
- Source
- Diff
./DiagnosticsTD.qml
… 12 more files in changeset.

10:04 am

Dara Navaei

More
LEAHI-APPLICATION-LDT-2428-1
started review

LEAHI-APPLICATION-LDT-2428_Onboarding Test Message & Diag Screen View

5:25 pm

Stephen Quong

More
57ea732
changed 38 files
feature/LDT-2359-software-upgrade-qt-6-lts LEAHI-APPLICATION-LDT-2359-1

LDT-2364: Software Upgrade - SW - 01 - Qt6-LTS Investigation - R&I - 05: DEV - Feature Implementation

- Updated to build with Qt 6.8.3

- -1
- +1
./DiagnosticsTD.qml
- History
- Source
- Diff
./DiagnosticsTD.qml
… 37 more files in changeset.

4:03 pm

Dara Navaei

More
LEAHI-APPLICATION-LDT-2359-1
started review

LEAHI-APPLICATION-LDT-2359_Software Upgrade - SW - 01 - Qt6-LTS Investigation - R&I

3:06 pm

Tiffany Mejia

3:03 pm

Stephen Quong and Nicholas Ramirez

More
LEAHI-APPLICATION-LDT-926-1
finished reviewing

2:09 pm

Stephen Quong

RESOLVED

3:28 pm

Nicholas Ramirez

RESOLVED

3:23 pm

Tiffany Mejia

fixed, thanks!

3:23 pm

Tiffany Mejia

More
e18180f
changed 1 file
LDT-2428-Onboarding-Test-Message-and-Diag-Screen-View, develop and 15 more LEAHI-APPLICATION-LDT-926-1

LDT-931: Main Treatment Screen - SW - Diagnostics Screen-FP - 05: DEV - Feature Implementation

-Fix typo on TD diagnostics title

- -1
- +1
./DiagnosticsTD.qml
- History
- Source
- Diff
./DiagnosticsTD.qml

3:07 pm

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-926-1
commented on review

this looks like this will error.. Should be title: qsTr("Treatment Delivery & Blood Handling")

this looks like this will error.. Should be

    title: qsTr("Treatment Delivery & Blood Handling")

3:04 pm

Nicholas Ramirez

RESOLVED

1:49 pm

Tiffany Mejia

More
Re: LEAHI-APPLICATION-LDT-926-1
commented on review

Understood, will consider in a future story to adjust all models

1:48 pm

Tiffany Mejia

addressed

1:48 pm

Tiffany Mejia

More
d18aafa
changed 3 files
LDT-2428-Onboarding-Test-Message-and-Diag-Screen-View, develop and 15 more LEAHI-APPLICATION-LDT-926-1

LDT-931: Main Treatment Screen - SW - Diagnostics Screen-FP - 05: DEV - Feature Implementation

- Add qsTr to all diagnostic titles to be consistent

- -1
- +1
./DiagnosticsTD.qml
- History
- Source
- Diff
./DiagnosticsTD.qml
… 2 more files in changeset.

9:56 am

Stephen Quong

More
Re: LEAHI-APPLICATION-LDT-926-1
commented on review

For the models, in their infoText functions, use QStringLiteral when generating the string that is getting returned, if possible. (https://doc.qt.io/archives/qt-5.15/qstring.html#QStringLiteral)

For the models, in their infoText functions, use QStringLiteral when generating the string that is getting returned, if possible.
(https://doc.qt.io/archives/qt-5.15/qstring.html#QStringLiteral)

4:51 pm

Stephen Quong

More
LEAHI-APPLICATION-LDT-926-1
joined review

1:43 pm

Nicholas Ramirez

More
Re: LEAHI-APPLICATION-LDT-926-1
commented on review

probably do not need to translate because its a diagnostics page but to keep consistent with all other user facing texts in this file please translate.

9:44 pm