LEAHI-APPLICATION-LDT-926-1 LEAHI-APPLICATION-LDT-926_Feature/Ldt 926 Main Treatment Screen SW 01 Diagnostics Screen FP

closed on 29 Aug

Author

Moderator

Reviewers

LEAHI-APPLICATION-LDT-926_Feature/Ldt 926 Main Treatment Screen SW 01...

Activity

Details
Objectives
General Comments 3
Unresolved
Resolved
Number of files included: 53

leahi-application 0
- Folder sources 0
  - Folder canbus 0
    - File FrameInterface.cpp 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
    - File MessageInterpreter.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder dialogs/diagnostics 0
        
        File DiagnosticsDD.qml 0 Remove
        
        File DiagnosticsFP.qml 3 Remove
        
        File DiagnosticsSwipe.qml 0 Remove
        
        File DiagnosticsTD.qml 3 Remove
      - File main.qml 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
  - Folder model 0
    - Folder fp 0
      - Folder adjustment/settings 0
        
        File MAdjustFPVersionsResponse.cpp 0 Remove
        
        File MAdjustFPVersionsResponse.h 0 Remove
      - Folder data 0
        
        File MFPBoostPumpData.cpp 0 Remove
        
        File MFPBoostPumpData.h 0 Remove
        
        File MFPConductivityData.cpp 0 Remove
        
        File MFPConductivityData.h 0 Remove
        
        File MFPFlowData.cpp 0 Remove
        
        File MFPFlowData.h 0 Remove
        
        File MFPLevelData.cpp 0 Remove
        
        File MFPLevelData.h 0 Remove
        
        File MFPPressuresData.cpp 0 Remove
        
        File MFPPressuresData.h 0 Remove
        
        File MFPROPumpData.cpp 0 Remove
        
        File MFPROPumpData.h 0 Remove
        
        File MFPTemperatureData.cpp 0 Remove
        
        File MFPTemperatureData.h 0 Remove
        
        File MFPValvesStatesData.cpp 0 Remove
        
        File MFPValvesStatesData.h 0 Remove
    - File MAbstract.h 0 Remove
    - File MModel.h 0 Remove
  - Folder view 0
    - Folder fp/data 0
      - File VFPBoostPumpData.cpp 0 Remove
      - File VFPBoostPumpData.h 0 Remove
      - File VFPConductivityData.cpp 0 Remove
      - File VFPConductivityData.h 0 Remove
      - File VFPFlowData.cpp 0 Remove
      - File VFPFlowData.h 0 Remove
      - File VFPLevelData.cpp 0 Remove
      - File VFPLevelData.h 0 Remove
      - File VFPPressuresData.cpp 0 Remove
      - File VFPPressuresData.h 0 Remove
      - File VFPROPumpData.cpp 0 Remove
      - File VFPROPumpData.h 0 Remove
      - File VFPTemperatureData.cpp 0 Remove
      - File VFPTemperatureData.h 0 Remove
      - File VFPValvesStatesData.cpp 0 Remove
      - File VFPValvesStatesData.h 0 Remove
    - Folder settings 0
      - File VAdjustmentVersions.cpp 0 Remove
      - File VAdjustmentVersions.h 0 Remove
    - File VView.h 0 Remove
- File leahi.pro 0 Remove
- File leahi.qrc 0 Remove
leahi-dialin 0
- Folder leahi_dialin/ui 0
  - File fp_messaging.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Tiffany Mejia	Author & Moderator	47m	3	fixed, thanks!
Sean Nash	Reviewer - 0% reviewed
Michael Garthwaite	Reviewer - 0% reviewed
Dara Navaei	Reviewer - 0% reviewed	10m
Behrouz NematiPour	Reviewer - 13% reviewed	23h 43m
Daniel Ho	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 0% reviewed
Nicholas Ramirez	Reviewer - Complete	47m	4	RESOLVED
jpaguio (deleted user)	Reviewer - 0% reviewed
Stephen Quong	Reviewer - Complete	57m	2	RESOLVED
Total		26h 26m	9

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Stephen Quong

For the models, in their infoText functions, use QStringLiteral when generati...

For the models, in their infoText functions, use QStringLiteral when generating the string that is getting returned, if possible.
(https://doc.qt.io/archives/qt-5.15/qstring.html#QStringLiteral)

19 Aug

Stephen Quong

Resolved

29 Aug

Tiffany Mejia

Understood, will consider in a future story to adjust all models

28 Aug

Stephen Quong

RESOLVED

29 Aug

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-APPLICATION-LDT-926-1

LEAHI-APPLICATION-LDT-926_Feature/Ldt 926 Main Treatment Screen SW 01...

LEAHI-APPLICATION-LDT-926-1 9

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Stephen Quong

Tiffany Mejia

Stephen Quong

Log time

LEAHI-APPLICATION-LDT-926_Feature/Ldt 926 Main Treatment Screen SW 01...

LEAHI-APPLICATION-LDT-926-1 9

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Stephen Quong

Tiffany Mejia

Stephen Quong

Log time