leahi-dialin

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-4221 NON-FEATURE: SW Misc & Enhc - SW - 01 - Create Rx - Final Flag Prm - R&I - 08: DEV - Dialin Implementation

remove fijnal rejection reason

LDT-4221 NON-FEATURE: SW Misc & Enhc - SW - 01 - Create Rx - Final Flag Prm - R&I - 08: DEV - Dialin Implementation

update to add final flag

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

LEVEL_OFFSET?

LEVEL_OFFSET?

LDT-3984 fix for conductivie level sensors d46, d63,d98

LDT-4169 Post-Treatment - SW - 01 - TxReview - R&I - 08: DEV - Dialin Implementation

push dialin updated

    • -2
    • +164
    /leahi_dialin/ui/td_messaging.py
LEAHI-DIALIN-LDT-4213_NON-FEATURE: SW Misc & Enhc - SW - 01 - Create Rx - Final Flag Prm - R&I
LEAHI-DIALIN-LDT-4213_NON-FEATURE: SW Misc & Enhc - SW - 01 - Create Rx - Final Flag Prm - R&I
Merge branch LDT-3984-dd-sw-d46-reads-0-with-and-with into develop

Should this be an enumeration somewhere?

Should this be an enumeration somewhere?

LDT-3984 conductive level sensor dialin implementation

Merge branch 'LDT-3352-dd---revisit-d3-level-control-l' into staging

LEAHI-DIALIN-LDT-4161_Post-Treatment - SW - 01 - TxReview - R&I
LEAHI-DIALIN-LDT-4161_Post-Treatment - SW - 01 - TxReview - R&I
LDT-3940 Post-Treatment - SW - 01 - Foundation - R&I - 08: DEV - Dialin Implementation

fix messag id

LDT-4169 Post-Treatment - SW - 01 - TxReview - R&I - 08: DEV - Dialin Implementation

add fw message ids

Merge branch 'LDT-3352-dd---revisit-d3-level-control-l' into develop

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LDT-3984 aligning D46 with DD firmware

Merge remote-tracking branch 'origin/staging' into feature/LDT-3932-post-treatment-foundation

    • -45
    • +162
    /leahi_dialin/ui/td_messaging.py
Merge branch 'feature/LDT-3855-sw-enhc-general-alarm' into staging