Activity td-firmware/

4 hrs ago

Vendor - TEL - Suresh Dharnala

More
f4da3db
changed 2 files
LDT-4050-post-treatment---fw-implementat LEAHI-TD-FIRMWARE-LDT-4050-1

LDT-4050:updated DD goto postgen and standby call

- -52
- +25
/firmware/App/Modes/ModePostTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePostTreat.c
- -84
- +81
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c

6:02 pm

Vendor - TEL - Praneeth Bunne

More
81e5d76
changed 8 files
LDT-3992-disposable-tube-set-auto-priming LEAHI-TD-FIRMWARE-LDT-3992-7

LDT-3992: Merge latest staging & reolve merge conflicts

- -94
- +325
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -2
- +7
/firmware/App/Modes/ModePreTreat.h
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.h
- -120
- +246
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -15
- +45
/firmware/App/Modes/StatePreTxRecirculate.c
- History
- Source
- Diff
/firmware/App/.../StatePreTxRecirculate.c
- -8
- +11
/firmware/App/Services/AlarmMgmtSWFaults.h
- History
- Source
- Diff
/firmware/App/.../AlarmMgmtSWFaults.h
- -2
- +33
/firmware/App/Services/DDInterface.c
- History
- Source
- Diff
/firmware/App/Services/DDInterface.c
- -2
- +3
/firmware/App/Services/DDInterface.h
- History
- Source
- Diff
/firmware/App/Services/DDInterface.h
- -6
- +4
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

5:58 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-5624-1
replied to Vendor - TEL - Praneeth Bunne

I don't have a good option. If we're going to change it to pull approach later, can't we just ignore rate changes when doing fluid bolus with sub fluid until you implement the pull approach? Are we...

I don't have a good option. If we're going to change it to pull approach later, can't we just ignore rate changes when doing fluid bolus with sub fluid until you implement the pull approach? Are we even able to do sub fluid bolus yet? Do we have HDF tube sets?

5:48 pm

Vendor - TEL - Praneeth Bunne

Sure

5:44 pm

Vendor - TEL - Praneeth Bunne

I'll implement the pull approach later, this is temporary fix. We need to run Sub pump at Qb rate, if Qb is updated, how can we increase Qsub?

I'll implement the pull approach later, this is temporary fix.
We need to run Sub pump at Qb rate, if Qb is updated, how can we increase Qsub?

5:37 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-5624-1
commented on review

Should we check to see if blood sitting timer has not exceeded time limit before we resume (similar to what we do from rinseback stop state before we start an additional)?

5:30 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-5624-1
commented on review

So we will command BP every 50ms for saline (okay, but not the pull approach we talked about) and send DD Qsub commands every 50ms for sub fluid (probably not a good idea)?

5:06 pm

Vendor - TEL - Praneeth Bunne

More
5ace054
changed 4 files
LDT-5624-td-sw-ui-screen-goes-to-main-lo LEAHI-TD-FIRMWARE-LDT-5624-1

LDT-5624: Fixed rinseback & fluid bolus related bugs

- -0
- +4
/firmware/App/Modes/ModeTreatment.c
- History
- Source
- Diff
/firmware/App/Modes/ModeTreatment.c
- -0
- +6
/firmware/App/Modes/StateTxDialysis.c
- History
- Source
- Diff
/firmware/App/Modes/StateTxDialysis.c
- -58
- +64
/firmware/App/Modes/StateTxRinseback.c
- History
- Source
- Diff
/firmware/App/Modes/StateTxRinseback.c
- -4
- +13
/firmware/App/Services/StateServices/FluidBolus.c
- History
- Source
- Diff
/firmware/App/.../StateServices/FluidBolus.c

10:26 am

Vendor - TEL - Varshini Nagabooshanam

Those transitions to send the pressure result event. That was carried over from the previous implementation. Since the state changes are already reported through the common sub-state/operation-stat...

Those transitions to send the pressure result event. That was carried over from the previous implementation. Since the state changes are already reported through the common sub-state/operation-status events, I'll remove the pressure result event from those individual transitions for consistency.

9:53 am

Michael Garthwaite

More
Re: LEAHI-TD-FIRMWARE-LDT-5613-1
commented on review

Need the TDDef.h changes that include the enum naming updates

9:49 am

Vendor - TEL - Suresh Dharnala

More
a57af27
changed 5 files
LDT-4050-post-treatment---fw-implementat LEAHI-TD-FIRMWARE-LDT-4050-1

LDT-4050:Added one single command to DD disinfection options

- -13
- +40
/firmware/App/Modes/ModePostTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePostTreat.c
- -21
- +16
/firmware/App/Modes/ModeStandby.c
- History
- Source
- Diff
/firmware/App/Modes/ModeStandby.c
- -10
- +45
/firmware/App/Services/DDInterface.c
- History
- Source
- Diff
/firmware/App/Services/DDInterface.c
- -1
- +3
/firmware/App/Services/DDInterface.h
- History
- Source
- Diff
/firmware/App/Services/DDInterface.h
- -0
- +1
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

9:47 am

Michael Garthwaite

More
LEAHI-TD-FIRMWARE-LDT-4050-1
resumed reviewing

9:42 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-5613-1
commented on review

Should reset happen when transitioning out of this state (into next state)? I think we want to allow time for pressure to stabilize while open to atmosphere after we open these valves before we res...

Should reset happen when transitioning out of this state (into next state)? I think we want to allow time for pressure to stabilize while open to atmosphere after we open these valves before we reset the offsets.

9:40 am