Added

Updated

Updated

Yes, removed

Yes, moved to different place

Yes, updated

Used in handle function

added

Yes added

SW fault here?

Do we need this state if all it's doing is going to IDLE?

Might have to wait for module to not be busy before getting the data.

I think we may need to give a get data command here.

Look for request flag to give measure command and transition to measure state.

Write private handle functions for each state and call them in each case.

Should we also check whether bpMeasurementReady is TRUE?

Same.

Same. Set a request flag to TRUE (for Peds this time) and let the state machine do the rest.

Don't change state from outside signal. We should just set a requestBPMeasurement flag to TRUE in this function (if current state is IDLE) and then when the state machine runs next, the IDLE state should look for this flag to be TRUE and transition to MEASURE state (by doing all of these things you have here in this function).

Change comment to "Number of BP driver states."

Not really, I can change this to private

Add a 5th enum for NUM_OF_BP_DRIVER_STATES.
And, does this need to be public?

if syrPumpDACControl is U16 (2 bytes), then nibpCtl should be at 42.

Remove extra blank line.

Yes Noe said to replace with new register

Updated

Sure

If we don't set this pwm time anymore, we don't need this. Please make sure we really don't need this anymore though.

I don't think these definitions need to be public. Some of these should probably be inside the FpgaTD.c and some should probably be inside your driver's .c file.