Added

Updated

Updated

Yes, removed

Yes, moved to different place

Yes, updated

Used in handle function

added

Yes added

· /firmware/App/Controllers/BPModule.c	(-35, +196)	| History	| Source	| Diff
· /firmware/App/Controllers/BPModule.h	(-0, +6)	| History	| Source	| Diff
· /firmware/App/Drivers/BPDriver.c	(-40, +106)	| History	| Source	| Diff

]]> Wed, 20 May 2026 15:19:40 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29258 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29258 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4033-1

SW fault here?

Do we need this state if all it's doing is going to IDLE?

Might have to wait for module to not be busy before getting the data.

I think we may need to give a get data command here.

Look for request flag to give measure command and transition to measure state.

Write private handle functions for each state and call them in each case.

Should we also check whether bpMeasurementReady is TRUE?

Same.

Same. Set a request flag to TRUE (for Peds this time) and let the state machine do the rest.

Don't change state from outside signal. We should just set a requestBPMeasurement flag to TRUE in this function (if current state is IDLE) and then when the state machine runs next, the IDLE state should look for this flag to be TRUE and transition to MEASURE state (by doing all of these things you have here in this function).

Change comment to "Number of BP driver states."

· /firmware/App/Controllers/BPModule.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Drivers/BPDriver.c	(-0, +10)	| History	| Source	| Diff

]]> Wed, 20 May 2026 14:50:03 -0700 Vendor - TEL - Varshini Nagabooshanam https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29246 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29246 Vendor - TEL - Varshini Nagabooshanam replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4033-1

Not really, I can change this to private

Add a 5th enum for NUM_OF_BP_DRIVER_STATES.
And, does this need to be public?

· /firmware/App/Controllers/BPModule.c	(-0, +199)	| History	| Source
· /firmware/App/Controllers/BPModule.h	(-0, +45)	| History	| Source
· /firmware/App/Drivers/BPDriver.c	(-0, +216)	| History	| Source
· /firmware/App/Drivers/BPDriver.h	(-0, +68)	| History	| Source

]]> Wed, 20 May 2026 13:26:00 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29240 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4033-1/#c29240 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4033-1

if syrPumpDACControl is U16 (2 bytes), then nibpCtl should be at 42.

Remove extra blank line.

Yes Noe said to replace with new register

Updated