td-firmware / firmware / App / Modes

StatePreTxRecirculate.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 2
Last Commit: 18 Jun
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
4 hrs ago

Vendor - TEL - Vijay Pamula

Wednesday 17 Jun
12:03 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./StatePreTxRecirculate.c
  2. … 4 more files in changeset.
Friday 12 Jun
11:07 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

2:03 pm

Vendor - TEL - Arpita Srivastava

align the comment part

align the comment part

10:45 am

Sean Nash

This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now. For now, comment out this line with a TODO to restore when patient connectio...

This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now.
For now, comment out this line with a TODO to restore when patient connection state is implemented and add a temporary line of code to request treatment mode here.

Thursday 11 Jun
4:53 pm

Vendor - TEL - Vijay Pamula

LDT-4027:Updated Pre-treatment Recirculate state

Options
    • -3
    • +3
    ./StatePreTxRecirculate.c
  2. … 2 more files in changeset.
3:10 pm

Vendor - TEL - Vijay Pamula

LDT-4027: Addressed Code review comments for Pre-Treatment Recirculate State

Options
    • -9
    • +6
    ./StatePreTxRecirculate.c
Tuesday 09 Jun
2:38 pm

Sean Nash

You only addressed the first part of my comment above.

You only addressed the first part of my comment above.

2:36 pm

Sean Nash

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

9:52 am

Vendor - TEL - Arpita Srivastava

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested Remove from output: recircMediumAlarmGiven and recircResumeRequested

Remove from input: preTxRecircStartTime, recircMediumAlarmGiven and recircResumeRequested
Remove from output: recircMediumAlarmGiven and recircResumeRequested

9:50 am

Vendor - TEL - Arpita Srivastava

Output should be none.

Output should be none.

9:36 am

Vendor - TEL - Arpita Srivastava

Just curious, at what condition we leave this state? It looks like, once we enter this state, we stay.

Just curious, at what condition we leave this state?
It looks like, once we enter this state, we stay.

Monday 08 Jun
4:13 pm

Vendor - TEL - Vijay Pamula

LDT-4027: Addressed review comments for pre-treatment recirculate state

Options
    • -22
    • +15
    ./StatePreTxRecirculate.c
  2. … 1 more file in changeset.
Friday 05 Jun
1:23 pm

Vendor - TEL - Arpita Srivastava

Please add Alarm ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

Please add Alarm
ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

1:19 pm

Vendor - TEL - Arpita Srivastava

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

1:16 pm

Vendor - TEL - Arpita Srivastava

Please add currentPreTreatmentState to inputs.

Please add currentPreTreatmentState to inputs.

1:07 pm

Vendor - TEL - Arpita Srivastava

currentPreTxRecircState looks like an input.

currentPreTxRecircState looks like an input.

Thursday 04 Jun
1:44 pm

Sean Nash

Put recirc state after Rx state (both here in switch statement and also in enumeration).

Put recirc state after Rx state (both here in switch statement and also in enumeration).

1:43 pm

Sean Nash

Put in alphabetical order (before Timers.h).

Put in alphabetical order (before Timers.h).

1:39 pm

Sean Nash

Dialysate rate should be set to the Qd user setting (from Tx params).

Dialysate rate should be set to the Qd user setting (from Tx params).

1:32 pm

Sean Nash

Add /// doxygen comment for this enumeration and ///< doxygen comments to right of each enum in the list.

Add /// doxygen comment for this enumeration and ///< doxygen comments to right of each enum in the list.

Wednesday 03 Jun
4:59 pm

Vendor - TEL - Vijay Pamula

LDT-4027: Implementation Pre-Treatment Recirculate State

Options
    • -0
    • +277
    ./StatePreTxRecirculate.c
  2. … 3 more files in changeset.
2:01 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4027_Pre-Treatment - FW Implementation - 2/6:
LEAHI-TD-FIRMWARE-LDT-4027_Pre-Treatment - FW Implementation - 2/6: