I don't see you changing the GoalL. Recommend you use local presUFVolumeMl instead.

2 lines above/below banner

remove blank line.

use response.x for these.

use response.duration.

Already set this above.

I don't think we should change this.

Not sure this makes sense. Time is in minutes. min * mL/min = mL (makes sense). min * L/hr = minL/hr (does not make sense).
Talk to Raghu about UF rate units and when we should use mL/min vs. L/hr.

· /firmware/App/Monitors/Pressures.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +3)	| History	| Source	| Diff
· /firmware/App/TDCommon.h	(-2, +2)	| History	| Source	| Diff

]]> Thu, 30 Apr 2026 15:57:21 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28771 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28771 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

I don't think you want stored (old) value here. You want value from first message before confirmation.

· /firmware/App/Monitors/Pressures.c	(-4, +4)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +0)	| History	| Source	| Diff
· /firmware/App/TDCommon.h	(-0, +2)	| History	| Source	| Diff

]]> Wed, 29 Apr 2026 11:02:20 -0700 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=e9e339870c5ed01230963f00d400331ab879c91f https://devapps.diality.us/changelog/td-firmware?cs=e9e339870c5ed01230963f00d400331ab879c91f Dara Navaei committed e9e3398 on branch LDT-1886-blood-set-auto-load-and-auto-ej, LDT-2240-disposable-tube-set-self-test and 10 more in td-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxDialysis.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/AlarmMgmtSWFaults.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/DDInterface.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/TDCommon.h	(-2, +2)	| History	| Source	| Diff

]]> Wed, 29 Apr 2026 10:57:14 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 Raghu Kallala Closed LEAHI-TD-FIRMWARE-LDT-473-3 ]]> Wed, 29 Apr 2026 10:44:00 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 Vinayakam Mani finished reviewing LEAHI-TD-FIRMWARE-LDT-473-3 LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation ]]> Wed, 29 Apr 2026 09:57:28 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28742 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3970-1/#c28742 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-3970-1

Keep 2 blank lines above the banner below.

Is this still needed?

You moved this to TxParams.h and I think that's right. I also think all of these other edit treatment parameters message payloads will also need to be moved as well.

Keep 2 blank lines above the test support functions banner.

Not sure why you are making changes to this function.
This function handles message from UI to pause or resume ultrafiltration.
This is not a treatment parameter edit message, so I don't think it's part of your assignment.

No longer needed?

· /firmware/App/Modes/StateTxDialysis.c	(-6, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.h	(-1, +0)	| History	| Source	| Diff

]]> Tue, 28 Apr 2026 20:33:51 -0700 Vendor - TEL - Vijay Pamula https://devapps.diality.us/changelog/td-firmware?cs=421336466eff4ba9fef0ca5416043e5d83c63841 https://devapps.diality.us/changelog/td-firmware?cs=421336466eff4ba9fef0ca5416043e5d83c63841 Vendor - TEL - Vijay Pamula committed 4213364 on branch LDT-3970-edit-treatment-parameters-during-treatment in td-firmware LDT-3970: Adressed code review comments

· /firmware/App/Modes/ModeTreatment.c	(-225, +0)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.h	(-3, +0)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxDialysis.c	(-41, +41)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.c	(-169, +0)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.h	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.h	(-65, +0)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-0, +428)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.h	(-0, +62)	| History	| Source	| Diff

]]> Tue, 28 Apr 2026 18:13:22 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-473-3 LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation ]]> Tue, 28 Apr 2026 14:31:18 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28733 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28733 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

???

Do we need a parameter for confirmation?

We can set bolus volume here now. These functions should be moved to TxParams where all of these settings exist and can be updated.

Why does confirm msg have duration again? If UI resends duration, we have to validate it again. If UI just sends confirmation of previously sent duration, we don't have to validate it again.

These are already in TxParams I believe.