Align =

Should modality be an enum type?

Align =

Should this be an enum type?

· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/FluidBolus.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-8, +8)	| History	| Source	| Diff

]]> Wed, 01 Jul 2026 13:36:09 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c30318 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c30318 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-4013-2

What is the 3rd modality?

Return type should be an enum (TREATMENT_TYPE_T).

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

Move after Modes so they are alphabetized.

Remove extra ;

Can we align comments?

Where did this get moved to?

Missing pinch valves (H1 and H19).

Remove this blank line.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

· /firmware/App/Modes/ModeStandby.c	(-3, +66)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.h	(-0, +11)	| History	| Source	| Diff
· /firmware/App/Modes/StateTxPaused.c	(-5, +2)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/FluidBolus.c	(-25, +5)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/FluidBolus.h	(-1, +0)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/TubeSetInstall.c	(-0, +35)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/TubeSetInstall.h	(-1, +2)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-9, +18)	| History	| Source	| Diff

]]> Fri, 26 Jun 2026 09:51:02 -0700 Vendor - TEL - Vijay Pamula https://devapps.diality.us/changelog/td-firmware?cs=ce9145f506c3b7b970285bf2ab2e464b66f83bab https://devapps.diality.us/changelog/td-firmware?cs=ce9145f506c3b7b970285bf2ab2e464b66f83bab Vendor - TEL - Vijay Pamula committed ce9145f on branch LDT-4028-pre-treatment---fw-implementation in td-firmware LDT-4028:Addressed code review commens for Pre-Tx Install State

· /firmware/App/Modes/ModePreTreat.c	(-8, +8)	| History	| Source	| Diff
· /firmware/App/Modes/ModeStandby.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Modes/ModeTreatment.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Monitors/Pressures.c	(-2, +2)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/TubeSetInstall.c	(-4, +5)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/TubeSetInstall.h	(-3, +3)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.c	(-11, +11)	| History	| Source	| Diff
· /firmware/App/Services/TxParams.h	(-2, +2)	| History	| Source	| Diff

]]> Wed, 24 Jun 2026 14:42:21 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4028-2/#c30131 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4028-2/#c30131 Vendor - TEL - Arpita Srivastava commented on LEAHI-TD-FIRMWARE-LDT-4028-2

please add message id.

We should set all TD actuators here, not just blood pump.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

Change "SetupConnection" to "SetupTubingSetConnection"

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

· /firmware/App/Services/AlarmMgmtTD.c	(-343, +343)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/TubeSetInstall.c	(-12, +13)	| History	| Source	| Diff

]]> Mon, 22 Jun 2026 15:49:12 -0700 Vendor - TEL - Vijay Pamula https://devapps.diality.us/changelog/td-firmware?cs=06462a7f903d6ac4835125746b6b6394be4601ae https://devapps.diality.us/changelog/td-firmware?cs=06462a7f903d6ac4835125746b6b6394be4601ae Vendor - TEL - Vijay Pamula committed 06462a7 on branch LDT-4028-pre-treatment---fw-implementation in td-firmware LDT-4028:Install State Implementation

· /firmware/App/Modes/ModePreTreat.c	(-9, +58)	| History	| Source	| Diff
· /firmware/App/Services/Messaging.c	(-0, +1)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/TubeSetInstall.c	(-12, +96)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/TubeSetInstall.h	(-0, +2)	| History	| Source	| Diff

]]> Mon, 15 Jun 2026 14:32:04 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4028-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4028-2 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-4028-2 ]]> Mon, 15 Jun 2026 12:26:30 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/changelog/td-firmware?cs=da286decac70b8da5b369ccca36c05fb5bdb7c73 https://devapps.diality.us/changelog/td-firmware?cs=da286decac70b8da5b369ccca36c05fb5bdb7c73 Vendor - TEL - Praneeth Bunne committed da286de on branch LDT-4013-fluid-bolus-1, develop, staging in td-firmware LDT-4013-1: Addressed CR comments

· /firmware/App/Modes/StateTxPaused.c	(-1, +1)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/FluidBolus.c	(-4, +8)	| History	| Source	| Diff
· /firmware/App/Services/StateServices/TubeSetInstall.c	(-0, +1)	| History	| Source	| Diff

]]> Mon, 15 Jun 2026 11:36:28 -0700 Vendor - TEL - Arpita Srivastava https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29916 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-4013-2/#c29916 Vendor - TEL - Arpita Srivastava replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-4013-2

Thank you for the clarification!