td-firmware

firmware

Clone Tools

Stats

Commits this week: 69
Total Committers: 17
Last Commit: 31 Jul
Commits this week: 69

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 27 Jul
9:53 am

Vendor - TEL - Varshini Nagabooshanam

Changes

Options
    • -7
    • +7
    ./App/Services/FpgaTD.c
9:53 am

Sean Nash

I think we should have handle functions that return next state for each of these cases (just like mode state machines).

I think we should have handle functions that return next state for each of these cases (just like mode state machines).

9:51 am

Sean Nash

Remove extra blank lines and comment.

Remove extra blank lines and comment.

9:50 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

9:50 am

Vendor - TEL - Varshini Nagabooshanam

Changes

Options
    • -26
    • +42
    ./App/Controllers/Valves.c
9:50 am

Sean Nash

Remove this comment?

Remove this comment?

9:49 am

Sean Nash

Just have a comment here that says "Ok - do nothing."

Just have a comment here that says "Ok - do nothing."

9:49 am

Sean Nash

If we don't need this code, remove it.

If we don't need this code, remove it.

9:48 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:48 am

Sean Nash

Add a TODO comment to restore this when Noe fixes FPGA

Add a TODO comment to restore this when Noe fixes FPGA

9:47 am

Sean Nash

Remove blank line.

Remove blank line.

9:46 am

Sean Nash

Why commented out?

Why commented out?

9:44 am

Sean Nash

Missing /// comment.

Missing /// comment.

9:44 am

Sean Nash

Use /// comment.

Use /// comment.

9:44 am

Sean Nash

Use a /// comment so doxygen sees it.

Use a /// comment so doxygen sees it.

9:42 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:42 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:40 am

Sean Nash

not homed state.

not homed state.

9:39 am

Sean Nash

Remove obsolete states from switch statement.

Remove obsolete states from switch statement.

9:37 am

Sean Nash

Why is home command commented out?

Why is home command commented out?

9:37 am

Sean Nash

We should initialize your new driver here.

We should initialize your new driver here.

9:36 am

Sean Nash

The driver is already included in Valves.h, so we don't need it here.

The driver is already included in Valves.h, so we don't need it here.

9:34 am

Vendor - TEL - Varshini Nagabooshanam

Changes

Options
    • -2
    • +1
    ./App/Drivers/BPDriver.c
    • -9
    • +10
    ./App/Services/FpgaTD.c
9:23 am

Sean Nash

Add a blank line between declarations and code.

Add a blank line between declarations and code.

9:23 am

Vendor - TEL - Varshini Nagabooshanam

Changes in Controller

Options
    • -4
    • +3
    ./App/Controllers/Valves.c
9:22 am

Sean Nash

Move details down to its own line.

Move details down to its own line.

9:22 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:21 am

Sean Nash

Fix comment. Should say "in mL/min."

Fix comment. Should say "in mL/min."

Sunday 26 Jul
8:37 pm

Sean Nash

Should this be the "Load Syringe" alarm that you just added?

Should this be the "Load Syringe" alarm that you just added?

Saturday 25 Jul
9:55 pm

suresh

LDT-4063: Resolved conflicts

Options
    • -2
    • +19
    ./App/Services/Messaging.c
    • -43
    • +11
    ./App/Services/Messaging.h
    • -141
    • +142
    ./App/Services/SystemCommTD.c