testsuites / simulator / plugins / ultrafiltration

ultrafiltration.ui

Clone Tools

Stats

Commits this week: 0
Total Committers: 1
Last Commit: 20 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 08 Dec 2020
10:02 pm

Behrouz NematiPour

Thursday 03 Dec 2020
2:01 pm

pmontazemi  (deleted user) and plucia  (deleted user)

11:53 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:52 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:52 am

plucia  (deleted user)

RESOLVED. As per our conversation today, these uncovered issues will be addressed as part of the squish migration.

RESOLVED.
As per our conversation today, these uncovered issues will be addressed as part of the squish migration.

11:48 am

Behrouz NematiPour

done

done

10:41 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

10:41 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

10:41 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

10:40 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

10:40 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

10:19 am

plucia  (deleted user)

RESOLVED.

RESOLVED.

10:00 am

plucia  (deleted user)

This should be #4

This should be #4

Wednesday 02 Dec 2020
8:21 pm

Behrouz NematiPour

done

done

1:39 pm

plucia  (deleted user)

Basically, you're calling waitForObjectExists on a component that will always exist. It will be visible and enabled too, so waitForObject wouldn't help you. What would help you is to wait for the o...

Basically, you're calling waitForObjectExists on a component that will always exist. It will be visible and enabled too, so waitForObject wouldn't help you. What would help you is to wait for the object to exist that distinguishes it from the object being waited for in previous calls to test_state. The dictionary, names.o_treatmentStart_HeparinSection, is not unique with each call, but if you set the buttonText property of that dictionary on each call, then it will be unique. So that property needs to be part of the object you're waiting for in order for repeated calls to waitForObjectExists to be useful. Using the helper function is up to you. I'm just letting you know of its existence and purpose should you choose to use it in the future once it's merged. Hope this clarifies things

Tuesday 01 Dec 2020
1:55 pm

Behrouz NematiPour

DEN-5928: Investigation on the ultrafiltration founded bug Created a Bug for investigation put on next spring. Created a tag on this git commit. Put enough information in the bug description.

DEN-5928: Investigation on the ultrafiltration founded bug

Created a Bug for investigation put on next spring.
Created a tag on this git commit.
Put enough information in the bug description.

1:29 pm

Behrouz NematiPour

Done

Done

1:25 pm

Behrouz NematiPour

done, Sure from now on.

done,
Sure from now on.

1:25 pm

Behrouz NematiPour

done, Sure from now on.

done,
Sure from now on.

12:29 pm

Behrouz NematiPour

I'm not sure I see what's the issue to resolve here since I notice only a helper method for waitForObjectExists of SquishQt. And also I would strongly not want to play with SquishQt APIs so when an...

I'm not sure I see what's the issue to resolve here since I notice only a helper method for waitForObjectExists of SquishQt.
And also I would strongly not want to play with SquishQt APIs so when an error happens or when the test is not working I don't want to debug the helper or wrappers and want to only focus on the test.
Please use simple direct SquishQt API.
You are free to do any sophisticated logic in dialin but please keep the tests as simple as possible (just copy/paste if applicable) and only use SquishQt API unless it's absolutely necessary.

9:03 am

pmontazemi  (deleted user)

Same comment as above here.

Same comment as above here.

9:03 am

pmontazemi  (deleted user)

Please get with SYS Engineering and SeanN of FW to get to the bottom of this. Once you got an answer, please remove comment.

Please get with SYS Engineering and SeanN of FW to get to the bottom of this. Once you got an answer, please remove comment.

9:02 am

pmontazemi  (deleted user)

"notices" instead of "notice"

"notices" instead of "notice"

9:02 am

pmontazemi  (deleted user)

"change" instead of "chane", also replace "I'm" with "I am", basically no informal language in code comments, only formal language.

"change" instead of "chane", also replace "I'm" with "I am", basically no informal language in code comments, only formal language.

9:02 am

pmontazemi  (deleted user)

"change" instead of "chane", also replace "I'm" with "I am", basically no informal language in code comments, only formal language.

"change" instead of "chane", also replace "I'm" with "I am", basically no informal language in code comments, only formal language.

Monday 30 Nov 2020
11:49 am

Behrouz NematiPour

Thanks for the comment. I replied to the same comment.

Thanks for the comment.
I replied to the same comment.

11:40 am

Behrouz NematiPour

I agree, but I wanted to keep this naming consistent with Tx, Uf only in two letters.

I agree, but I wanted to keep this naming consistent with Tx, Uf only in two letters.

10:24 am

plucia  (deleted user)

isSalineBolusInProgress is clearer

isSalineBolusInProgress is clearer

10:20 am

plucia  (deleted user)

Same comment about waitForObjectExists as in here: http://dvm-linux02:8060/cru/#UI-DEN-5736-1CFR-20566

Same comment about waitForObjectExists as in here: http://dvm-linux02:8060/cru/#UI-DEN-5736-1CFR-20566

10:16 am

plucia  (deleted user)

The object being waited for will always exist. Instead, the buttonText should be added to the object that is being waited for. e.g. your_var = names.o_treatmentStart_heparinSection your_var["but...

The object being waited for will always exist.

Instead, the buttonText should be added to the object that is being waited for. e.g.

 
your_var = names.o_treatmentStart_heparinSection
your_var["buttonText"] =  "{} DELIVERY".format(vText) 
waitForObjectExists(your_var)

To address this problem, in my current Dialin Branch I've created a dict_update convenience function that allows you to add or update a dictionary's key and value. It will return a new dictionary object without modifying the original. The default python update call modifies the original and doesn't return a new object. So, using dict_update allows a simple one-liner for situations like these.

Once merged with my branch, you can use 

ui.utils.dict_update

and this operation can be simplified to a one-liner:

waitForObjectExists(dict_update(names.o_treatmentStart_heparinSection, "buttonText", "{} DELIVERY".format(vText)))