UI-DEN-5736-1 UI-DEN-5736_UI Heparin Bolus

closed on 08 Dec 20

Author

Reviewers

UI-DEN-5736_UI Heparin Bolus

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 76

application 0
- Folder sources 0
  - Folder canbus 0
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
  - Folder gui 0
    - Folder qml/pages/treatment 0
      - Folder adjustments 0
        
        File TreatmentAdjustmentUltrafiltrationEdit.qml 15 Remove
      - Folder sections 0
        
        File TreatmentFluid.qml 0 Remove
        
        File TreatmentHeparin.qml 0 Remove
        
        File TreatmentUltrafiltration.qml 0 Remove
      - File TreatmentStack.qml 3 Remove
      - File TreatmentStart.qml 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiGlobals.h 0 Remove
  - Folder model 0
    - Folder hd 0
      - Folder adjustment 0
        
        File MTreatmentAdjustHeparinResponse.cpp 0 Remove
        
        File MTreatmentAdjustHeparinResponse.h 0 Remove
        
        File MTreatmentAdjustRequests.h 0 Remove
      - Folder data 0
        
        File MTreatmentHeparinData.cpp 0 Remove
        
        File MTreatmentHeparinData.h 0 Remove
        
        File MTreatmentStatesData.cpp 0 Remove
        
        File MTreatmentStatesData.h 3 Remove
    - File MModel.h 0 Remove
  - Folder storage 0
    - File Logger.h 0 Remove
  - Folder view 0
    - Folder hd 0
      - Folder adjustment 0
        
        File VTreatmentAdjustmentHeparin.cpp 0 Remove
        
        File VTreatmentAdjustmentHeparin.h 0 Remove
        
        File VTreatmentAdjustmentSaline.cpp 0 Remove
      - Folder data 0
        
        File VHDTreatmentStatesData.cpp 0 Remove
        
        File VHDTreatmentStatesData.h 0 Remove
        
        File VTreatmentHeparinData.cpp 0 Remove
        
        File VTreatmentHeparinData.h 0 Remove
    - File VPriming.h 0 Remove
    - File VView.h 0 Remove
- Folder unittests 0
  - File tst_messaging.cpp 0 Remove
  - File tst_messaging.h 0 Remove
  - File tst_models.cpp 0 Remove
  - File tst_models.h 0 Remove
- File cppcheck.err 0 Remove
- File cppcheck.log 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
testsuites 0
- Folder shared/scripts 0
  - File names.py 0 Remove
- Folder simulator 0
  - Folder plugins 0
    - Folder heparin 0
      - File heparin.py 0 Remove
      - File heparin.ui 0 Remove
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder inlinebloodpressures 0
      - File inlinebloodpressures.py 0 Remove
      - File inlinebloodpressures.ui 0 Remove
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
    - Folder salinebolus 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
      - File salinebolus.py 0 Remove
      - File salinebolus.ui 0 Remove
    - Folder treatmentranges 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
      - File treatmentranges.py 0 Remove
      - File treatmentranges.ui 0 Remove
    - Folder treatmentstates 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
      - File treatmentstates.py 0 Remove
      - File treatmentstates.ui 0 Remove
    - Folder ultrafiltration 0
      - File interface.ui 0 Remove
      - File loader.py 0 Remove
      - File ultrafiltration.py 0 Remove
      - File ultrafiltration.ui 0 Remove
    - File __init__.py 0 Remove
  - File Simulator.ui 0 Remove
  - File run.py 0 Remove
  - File runtimewidget.py 0 Remove
  - File simulator.ui 0 Remove
- Folder tst_Internals 0
  - File test.py 0 Remove
- Folder tst_TreatmentHeparineData 0
  - File test.py 3 Remove
- Folder tst_TreatmentSalineData 0
  - File test.py 0 Remove
- Folder tst_TreatmentStatesData 0
  - File test.py 0 Remove
- Folder tst_Treatment_Adjustment_Heparin 0
  - File test.py 4 Remove
- Folder tst_Treatment_Adjustment_Ultrafiltration 0
  - File test.py 0 Remove
- File suite.conf 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author	1h 31m	9	done
plucia (deleted user)	Reviewer - Complete	2h 16m	9	RESOLVED
pmontazemi (deleted user)	Reviewer - Complete	14m	10	RESOLVED.
Total		4h 3m	28

Linked issues
- DEN-5736

#permalink

Objectives

Application:

Implemented Heparin request/response/data.
Saline progress bar not moving fixed.
Ultrafiltration suspected bug has been fixed but commented out since no one ever complained.

TestSuites:

Made the Duration slider work.
Made the simulator MDI layout
Made the simulator a little bit more plugin-based to be able to add more sections easier.
It still needs work to load/register the plugins automatically.
Added Heparin plugin
Renamed all the .py and .ui to loader.py and interface.ui to be one step closer to load dynamically
Fixed the API bug when implementing the request.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/simulator/.../inlinebloodpressures/inlinebloodpressures.py Deleted

Click to load diff

/simulator/.../inlinebloodpressures/inlinebloodpressures.ui Deleted

Click to load diff

/simulator/.../salinebolus/salinebolus.py Deleted

Click to load diff

/simulator/.../salinebolus/salinebolus.ui Deleted

Click to load diff

/simulator/.../treatmentranges/treatmentranges.py Deleted

Click to load diff

/simulator/.../treatmentranges/treatmentranges.ui Deleted

Click to load diff

/simulator/.../treatmentstates/treatmentstates.py Deleted

Click to load diff

/simulator/.../treatmentstates/treatmentstates.ui Deleted

Click to load diff

/simulator/.../ultrafiltration/ultrafiltration.py Deleted

Click to load diff

/simulator/.../ultrafiltration/ultrafiltration.ui Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-5736-1

UI-DEN-5736_UI Heparin Bolus

UI-DEN-5736-1 28

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-5736_UI Heparin Bolus

UI-DEN-5736-1 28

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time