Fisheye on leahi-fwcommon/ https://devapps.diality.us/changelog/~br%3DBambooSetup/leahi-fwcommon Recent activity in "leahi-fwcommon" under directory / LEAHI-DD-FIRMWARE-LDT-3676-1: reviewers finished Mon, 06 Apr 2026 11:01:44 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3676-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3676-1 Michael Garthwaite and Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-3676-1 LEAHI-DD-FIRMWARE-LDT-3676_Request: add SW config to enable booster pump control in the IOFP FW ]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Align comments." Mon, 06 Apr 2026 11:01:41 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28237 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28237 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Align comments.

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Can we just remove this?" Mon, 06 Apr 2026 10:57:42 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28236 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28236 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Can we just remove this?

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Can we just remove this?" Mon, 06 Apr 2026 10:57:26 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28235 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28235 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Can we just remove this?

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "F suffix." Mon, 06 Apr 2026 10:56:14 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28234 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28234 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

F suffix.

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Is bicarbonate also a conversion factor?" Mon, 06 Apr 2026 10:52:06 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28233 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28233 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Is bicarbonate also a conversion factor?

]]> LEAHI-TD-FIRMWARE-LDT-473-3: comment by Sean Nash "Can we just remove the old enum now?" Mon, 06 Apr 2026 10:49:32 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28232 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3/#c28232 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-473-3

Can we just remove the old enum now?

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Not sure these min/max are right here either." Mon, 06 Apr 2026 10:30:32 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28230 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28230 Sean Nash replied to Vinayakam Mani in LEAHI-DD-FIRMWARE-LDT-3352-1

Not sure these min/max are right here either.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "So we have all temp sensors getting averaged no..." Mon, 06 Apr 2026 10:27:34 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28229 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28229 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Remove extra blank lines." Mon, 06 Apr 2026 10:24:54 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28227 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28227 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Remove extra blank lines.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: reviewers finished Mon, 06 Apr 2026 10:23:49 -0700 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1 Sean Nash finished reviewing LEAHI-DD-FIRMWARE-LDT-1477-1 LEAHI-DD-FIRMWARE-LDT-1477_Ultrafiltration - DD - 04: DEV - Feature Implementation ]]> LEAHI-TD-FIRMWARE-LDT-473-3: started by Dara Navaei Mon, 06 Apr 2026 10:16:18 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-3 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-473-3 ]]> LEAHI-TD-FIRMWARE-LDT-473-2: closed by Raghu Kallala Mon, 06 Apr 2026 10:04:42 -0700 Raghu Kallala https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-2 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-473-2 Raghu Kallala Closed LEAHI-TD-FIRMWARE-LDT-473-2 ]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Fri, 03 Apr 2026 15:35:04 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28219 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28219 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done" Fri, 03 Apr 2026 15:34:48 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28218 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28218 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Fri, 03 Apr 2026 15:34:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28217 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28217 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Same comment." Fri, 03 Apr 2026 13:20:23 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28216 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28216 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Same comment.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Having much larger P coeff is likely to cause a..." Fri, 03 Apr 2026 13:18:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28215 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28215 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "Input is d78TempAvgC" Fri, 03 Apr 2026 13:14:56 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28214 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28214 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

Input is d78TempAvgC

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Sean Nash "I don't think these min/max (for control output..." Fri, 03 Apr 2026 13:11:46 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28213 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28213 Sean Nash commented on LEAHI-DD-FIRMWARE-LDT-3352-1

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:43:57 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28210 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28210 Vinayakam Mani replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Just following the current style of code implem..." Thu, 02 Apr 2026 15:42:21 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28209 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28209 Vinayakam Mani replied to Vendor - TEL - Sameer Poyil in LEAHI-DD-FIRMWARE-LDT-3352-1

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:40:23 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28208 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28208 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:39:59 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28207 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28207 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3352-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:39:30 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28206 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3352-1/#c28206 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-3352-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:28:25 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28205 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28205 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:28:17 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28204 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28204 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:27:47 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28203 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28203 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-1477-1: comment by Vinayakam Mani "Done." Thu, 02 Apr 2026 15:27:38 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28202 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-1477-1/#c28202 Vinayakam Mani replied to Sean Nash in LEAHI-DD-FIRMWARE-LDT-1477-1

Done.

]]> LEAHI-DD-FIRMWARE-LDT-3103-1: closed by Vinayakam Mani Thu, 02 Apr 2026 10:35:27 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1 https://devapps.diality.us/cru/LEAHI-DD-FIRMWARE-LDT-3103-1 Vinayakam Mani Closed LEAHI-DD-FIRMWARE-LDT-3103-1 ]]>