Fisheye on td-firmware/firmware/App/Controllers/AirTrap.c https://devapps.diality.us/changelog/~br%3DBambooSetup/td-firmware/firmware/App/Controllers/AirTrap.c Recent activity in "td-firmware" under directory /firmware/App/Controllers/AirTrap.c LEAHI-TD-FIRMWARE-LDT-1903-10: started by Dara Navaei Wed, 25 Mar 2026 06:46:59 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-10 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-10 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-1903-10 ]]> LEAHI-TD-FIRMWARE-LDT-1903-9: closed by Vendor - TEL - Sameer Poyil Mon, 23 Mar 2026 17:37:19 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9 Vendor - TEL - Sameer Poyil Closed LEAHI-TD-FIRMWARE-LDT-1903-9 ]]> LEAHI-TD-FIRMWARE-LDT-1903-9: reviewers finished Mon, 23 Mar 2026 10:30:28 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9 Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-1903-9 LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation ]]> LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Vendor - TEL - Sameer Poyil "reverted back" Tue, 17 Mar 2026 23:05:22 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c28110 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c28110 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-9

reverted back

]]> LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Vendor - TEL - Sameer Poyil "This code is removed and not required" Tue, 17 Mar 2026 23:05:09 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c28109 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c28109 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-9

This code is removed and not required

]]> LEAHI-TD-FIRMWARE-LDT-3600-1: closed by Vendor - TEL - Praneeth Bunne Fri, 13 Mar 2026 15:21:43 -0700 Vendor - TEL - Praneeth Bunne https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 Vendor - TEL - Praneeth Bunne Closed LEAHI-TD-FIRMWARE-LDT-3600-1 ]]> LEAHI-TD-FIRMWARE-LDT-3600-1: reviewers finished Fri, 13 Mar 2026 14:47:47 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 Vinayakam Mani , Vendor - TEL - Jashwant Gantyada and Sean Nash finished reviewing LEAHI-TD-FIRMWARE-LDT-3600-1 LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD ]]> LEAHI-TD-FIRMWARE-LDT-3600-1: reviewers added to LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Con... Fri, 13 Mar 2026 14:23:39 -0700 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 Sean Nash added Vendor - TEL - Jashwant Gantyada and Vinayakam Mani to LEAHI-TD-FIRMWARE-LDT-3600-1 LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD ]]> LEAHI-TD-FIRMWARE-LDT-3600-1: comment by Vinayakam Mani "Can we remove the empty lines after if / else i..." Fri, 13 Mar 2026 13:45:19 -0700 Vinayakam Mani https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1/#c28029 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1/#c28029 Vinayakam Mani commented on LEAHI-TD-FIRMWARE-LDT-3600-1

Can we remove the empty lines after if / else if blocks in this function?

]]> LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Sean Nash "You are calling setAirPumpState in if and else...." Wed, 11 Mar 2026 17:40:08 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27899 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27899 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-9

You are calling setAirPumpState in if and else. Consider just calling once after the if/else.

]]> LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Sean Nash "Add space between if and (" Wed, 11 Mar 2026 17:30:35 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27897 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27897 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-9

Add space between if and (

]]> LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Vendor - TEL - Sameer Poyil "Fixed" Wed, 11 Mar 2026 16:55:15 -0700 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27896 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27896 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-9

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-3600-1: started by Dara Navaei Wed, 11 Mar 2026 15:31:36 -0700 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-3600-1 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-3600-1 ]]> LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Sean Nash "Comment to right no longer makes sense." Tue, 10 Mar 2026 13:58:06 -0700 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27864 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27864 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-9

Comment to right no longer makes sense.

]]> LEAHI-TD-FIRMWARE-LDT-1903-9: comment by Sean Nash "Should this event be TD_EVENT_AIR_TRAP_FILL?" Fri, 06 Mar 2026 14:26:19 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27853 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9/#c27853 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-9

Should this event be TD_EVENT_AIR_TRAP_FILL?

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: closed by Vendor - TEL - Sameer Poyil Wed, 04 Mar 2026 20:22:26 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 Vendor - TEL - Sameer Poyil Closed LEAHI-TD-FIRMWARE-LDT-1903-8 ]]> LEAHI-TD-FIRMWARE-LDT-1903-9: started by Dara Navaei Wed, 04 Mar 2026 04:01:28 -0800 Dara Navaei https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-9 Dara Navaei started review LEAHI-TD-FIRMWARE-LDT-1903-9 ]]> LEAHI-TD-FIRMWARE-LDT-1903-8: reviewers resumed Mon, 02 Mar 2026 20:46:01 -0800 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8 Sean Nash resumed reviewing LEAHI-TD-FIRMWARE-LDT-1903-8 LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation ]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "fixed in latest code" Mon, 02 Mar 2026 11:54:51 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27695 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27695 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

fixed in latest code

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "implemented" Mon, 02 Mar 2026 11:53:34 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27694 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27694 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

implemented

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "fixed" Mon, 02 Mar 2026 11:53:26 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27693 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27693 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

fixed

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "I think this would be a TD s/w fault (alarm alr..." Mon, 02 Mar 2026 09:52:52 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27674 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27674 Sean Nash replied to Vendor - TEL - Sameer Poyil in LEAHI-TD-FIRMWARE-LDT-1903-8

I think this would be a TD s/w fault (alarm already define). Just need a new TD s/w fault ID in AlarmMgmtSWFaults.h.

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "This structure doesn't seem necessary - it's ju..." Mon, 02 Mar 2026 09:50:52 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27673 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27673 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "Fixed" Mon, 02 Mar 2026 07:42:05 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27671 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27671 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

Fixed

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "removed from here" Mon, 02 Mar 2026 07:37:03 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27670 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27670 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

removed from here

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "fixed" Mon, 02 Mar 2026 07:36:38 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27669 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27669 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

fixed

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Vendor - TEL - Sameer Poyil "We need new alarm . That should be included in ..." Fri, 27 Feb 2026 14:54:56 -0800 Vendor - TEL - Sameer Poyil https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27665 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27665 Vendor - TEL - Sameer Poyil replied to Sean Nash in LEAHI-TD-FIRMWARE-LDT-1903-8

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Add blank line after declarations." Fri, 27 Feb 2026 13:32:31 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27664 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27664 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Add blank line after declarations.

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:32:13 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27663 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27663 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]> LEAHI-TD-FIRMWARE-LDT-1903-8: comment by Sean Nash "Alarm should be handled inside of setAirPumpSta..." Fri, 27 Feb 2026 13:31:55 -0800 Sean Nash https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27662 https://devapps.diality.us/cru/LEAHI-TD-FIRMWARE-LDT-1903-8/#c27662 Sean Nash commented on LEAHI-TD-FIRMWARE-LDT-1903-8

Alarm should be handled inside of setAirPumpState().

]]>