Fisheye on td-firmware/firmware/App/Drivers/LevelSensors.h https://devapps.diality.us/changelog/~br%3DBambooSetup/td-firmware/firmware/App/Drivers/LevelSensors.h Recent activity in "td-firmware" under directory /firmware/App/Drivers/LevelSensors.h td-firmware (BambooSetup): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Sat, 21 Feb 2026 15:49:20 -0800 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=e86a7442c1178ab1bc556e2a87b693572f288d33 https://devapps.diality.us/changelog/td-firmware?cs=e86a7442c1178ab1bc556e2a87b693572f288d33 Dara Navaei committed e86a744 on branch BambooSetup in td-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/AirPump.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/AirTrap.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/AirTrap.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/AlarmAudio.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/AlarmAudio.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/AlarmLamp.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/AlarmLamp.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/BloodFlow.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/BloodFlow.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Ejector.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Ejector.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/BubbleDetector.c (-1, +1) | History | Source | Diff
… 76 more files in changeset.
]]> td-firmware (BambooSetup): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces Wed, 26 Nov 2025 20:35:29 -0800 Dara Navaei https://devapps.diality.us/changelog/td-firmware?cs=fe136dbf5161816828648ddc0a0f5576305aa626 https://devapps.diality.us/changelog/td-firmware?cs=fe136dbf5161816828648ddc0a0f5576305aa626 Dara Navaei committed fe136db on branch BambooSetup in td-firmware Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /firmware/App/Controllers/AirPump.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/AirPump.h (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/AirTrap.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/AirTrap.h (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/AlarmAudio.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/AlarmAudio.h (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/AlarmLamp.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/AlarmLamp.h (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/BloodFlow.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/BloodFlow.h (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/Ejector.c (-4, +4) | History | Source | Diff
· /firmware/App/Controllers/Ejector.h (-4, +4) | History | Source | Diff
· /firmware/App/Controllers/Valves.c (-5, +5) | History | Source | Diff
· /firmware/App/Controllers/Valves.h (-5, +5) | History | Source | Diff
· /firmware/App/Drivers/BubbleDetector.c (-4, +4) | History | Source | Diff
… 76 more files in changeset.
]]> TD-LEAH-838-1: closed by Sean Nash Mon, 24 Feb 2025 15:26:06 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1 Sean Nash Closed TD-LEAH-838-1 ]]> TD-LEAH-838-1: reviewers finished Mon, 24 Feb 2025 13:46:57 -0800 https://devapps.diality.us/cru/TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1 Vinayakam Mani and Michael Garthwaite finished reviewing TD-LEAH-838-1 TD-LEAH-838_FW TD Gas Liquid Transfer Pump ]]> TD-LEAH-838-1: started by Sean Nash Mon, 24 Feb 2025 13:22:23 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1 https://devapps.diality.us/cru/TD-LEAH-838-1 Sean Nash started review TD-LEAH-838-1 ]]> td-firmware (LDT-2240-disposable-tube-set-self-test): LEAH-838: Addressed code review feedback. Fri, 21 Feb 2025 15:03:33 -0800 Sean Nash https://devapps.diality.us/changelog/td-firmware?cs=285b5d82539c96524c93703d52a66fff76fb64fc https://devapps.diality.us/changelog/td-firmware?cs=285b5d82539c96524c93703d52a66fff76fb64fc Sean Nash committed 285b5d8 on branch BambooSetup, LDT-1394-blood-flow-rate-h4-rotor-count and 54 more in td-firmware LEAH-838: Addressed code review feedback.

· /firmware/App/Controllers/AirPump.c (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/AirTrap.c (-22, +20) | History | Source | Diff
· /firmware/App/Controllers/AirTrap.h (-1, +1) | History | Source | Diff
· /firmware/App/Controllers/BloodFlow.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/GLXferPump.c (-8, +11) | History | Source | Diff
· /firmware/App/Drivers/GLXferPump.h (-0, +1) | History | Source | Diff
· /firmware/App/Drivers/LevelSensors.c (-2, +2) | History | Source | Diff
· /firmware/App/Drivers/LevelSensors.h (-1, +1) | History | Source | Diff
· /firmware/App/Drivers/Valve3Way.c (-10, +10) | History | Source | Diff
· /firmware/App/Drivers/Valve3Way.h (-2, +2) | History | Source | Diff
· /firmware/App/Modes/ModeFault.c (-13, +13) | History | Source | Diff
· /firmware/App/Modes/ModeInitPOST.c (-8, +8) | History | Source | Diff
· /firmware/App/Modes/ModeService.c (-1, +1) | History | Source | Diff
· /firmware/App/Modes/ModeStandby.c (-8, +8) | History | Source | Diff
· /firmware/App/Monitors/Pressures.c (-3, +3) | History | Source | Diff
… 3 more files in changeset.
]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 15:02:48 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21541 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21541 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Fixed." Fri, 21 Feb 2025 14:42:41 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21540 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21540 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Fixed.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:42:03 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21539 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21539 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:38:59 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21538 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21538 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:36:32 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21537 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21537 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:34:20 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21536 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21536 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:32:27 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21535 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21535 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:30:50 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21534 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21534 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "I would say we are required to explicitly typec..." Fri, 21 Feb 2025 14:27:09 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21533 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21533 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

I would say we are required to explicitly typecast if any of the following are true:
1) compiler warning if you don't
2) byte count/mem size matters (e.g. message payload) and might not match desired size if you don't cast it

I don't think either is true in this case.

]]> TD-LEAH-838-1: comment by Sean Nash "Removed TODO." Fri, 21 Feb 2025 14:25:09 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21532 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21532 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Removed TODO.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:23:51 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21531 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21531 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:14:51 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21530 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21530 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:13:11 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21529 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21529 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:11:07 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21528 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21528 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Yes. Done." Fri, 21 Feb 2025 14:10:35 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21527 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21527 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Yes. Done.

]]> TD-LEAH-838-1: comment by Sean Nash "Change has not happened yet in Denali. I will ..." Fri, 21 Feb 2025 14:09:41 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21526 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21526 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Change has not happened yet in Denali. I will follow up with Dara after change is made.

]]> TD-LEAH-838-1: comment by Sean Nash "Done." Fri, 21 Feb 2025 14:00:38 -0800 Sean Nash https://devapps.diality.us/cru/TD-LEAH-838-1/#c21525 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21525 Sean Nash replied to Vinayakam Mani in TD-LEAH-838-1

Done.

]]> TD-LEAH-838-1: comment by Vinayakam Mani "Do we want to change STATE_CLOSED to CMN_TO_NO_..." Thu, 20 Feb 2025 16:01:00 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21522 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21522 Vinayakam Mani commented on TD-LEAH-838-1

Do we want to change STATE_CLOSED to CMN_TO_NO_OPEN (or similar?), STATE_OPEN to CMN _TO_NC_OPEN?

]]> TD-LEAH-838-1: comment by Vinayakam Mani "3-way" Thu, 20 Feb 2025 15:57:07 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21521 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21521 Vinayakam Mani commented on TD-LEAH-838-1

3-way

]]> TD-LEAH-838-1: comment by Vinayakam Mani "May be add a check to validate the power level ..." Thu, 20 Feb 2025 15:51:20 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21520 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21520 Vinayakam Mani commented on TD-LEAH-838-1

May be add a check to validate the power level between 0 to 255.

]]> TD-LEAH-838-1: comment by Vinayakam Mani "No Alarm, Add Event ID." Thu, 20 Feb 2025 15:49:02 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21519 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21519 Vinayakam Mani commented on TD-LEAH-838-1

No Alarm, Add Event ID.

]]> TD-LEAH-838-1: comment by Vinayakam Mani "MotorState to MotorPowerLevel - across file." Thu, 20 Feb 2025 15:46:39 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21518 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21518 Vinayakam Mani commented on TD-LEAH-838-1

MotorState to MotorPowerLevel - across file.

]]> TD-LEAH-838-1: comment by Vinayakam Mani "Please adjust the alignment(few #defines)" Thu, 20 Feb 2025 15:38:12 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21517 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21517 Vinayakam Mani commented on TD-LEAH-838-1

Please adjust the alignment(few #defines)

]]> TD-LEAH-838-1: comment by Vinayakam Mani "isAutoControlling?" Thu, 20 Feb 2025 15:33:49 -0800 Vinayakam Mani https://devapps.diality.us/cru/TD-LEAH-838-1/#c21516 https://devapps.diality.us/cru/TD-LEAH-838-1/#c21516 Vinayakam Mani commented on TD-LEAH-838-1

isAutoControlling?

]]>