TD-LEAH-838-1 TD-LEAH-838_FW TD Gas Liquid Transfer Pump

closed on 24 Feb

Author

Moderator

Reviewers

TD-LEAH-838_FW TD Gas Liquid Transfer Pump

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 27

td-firmware 0
- Folder firmware/App 0
  - Folder Controllers 0
    - File AirPump.c 2 Remove
    - File AirPump.h 0 Remove
    - File AirTrap.c 18 Remove
    - File AirTrap.h 2 Remove
    - File BloodFlow.c 2 Remove
  - Folder Drivers 0
    - File GLXferPump.c 6 Remove
    - File GLXferPump.h 0 Remove
    - File GPIO.c 0 Remove
    - File GPIO.h 0 Remove
    - File LevelSensors.c 0 Remove
    - File LevelSensors.h 0 Remove
    - File Valve2Way.c 0 Remove
    - File Valve2Way.h 0 Remove
    - File Valve3Way.c 4 Remove
    - File Valve3Way.h 0 Remove
  - Folder Modes 0
    - File ModeFault.c 0 Remove
    - File ModeInitPOST.c 0 Remove
    - File ModeService.c 0 Remove
    - File ModeStandby.c 0 Remove
  - Folder Monitors 0
    - File Pressures.c 0 Remove
  - Folder Services 0
    - File AlarmMgmtSWFaults.h 0 Remove
    - File FpgaTD.c 0 Remove
    - File FpgaTD.h 0 Remove
    - File Messaging.c 0 Remove
  - Folder Tasks 0
    - File TaskGeneral.c 0 Remove
    - File TaskPriority.c 0 Remove
  - File TDCommon.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Sean Nash	Author & Moderator	26m	17	Done.
Michael Garthwaite	Reviewer - Complete	2m
Dara Navaei	Reviewer - 0% reviewed	13m
Vinayakam Mani	Reviewer - Complete	1h	17	Do we want to change STATE_CLOSED to CMN_TO_NO_OPEN (or s...
jpaguio (deleted user)	Reviewer - 0% reviewed
Total		1h 43m	34

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

TD-LEAH-838-1

TD-LEAH-838_FW TD Gas Liquid Transfer Pump

TD-LEAH-838-1 34

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

TD-LEAH-838_FW TD Gas Liquid Transfer Pump

TD-LEAH-838-1 34

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time