Fisheye on dialin/tests/peter/test_logging.py

DIALIN-DENBUG-280-4: closed by Michael Garthwaite

Michael Garthwaite — Wed, 06 Nov 2024 15:20:04 -0800

Michael Garthwaite Closed DIALIN-DENBUG-280-4

DIALIN-DENBUG-280-1: closed by Michael Garthwaite

Michael Garthwaite — Wed, 06 Nov 2024 15:19:54 -0800

Michael Garthwaite Closed DIALIN-DENBUG-280-1

DIALIN-DENBUG-280-4: reviewers finished

Mon, 04 Nov 2024 10:29:29 -0800

Sean Nash finished reviewing DIALIN-DENBUG-280-4

DIALIN-DENBUG-280_Issues With HD Broadcast P1

DIALIN-DENBUG-280-4: started by Dara Navaei

Dara Navaei — Sat, 02 Nov 2024 16:01:22 -0700

Dara Navaei started review DIALIN-DENBUG-280-4

DIALIN-DENBUG-280-1: reviewers joined DIALIN-DENBUG-280_Issues With HD Broadcast P1B

Thu, 31 Oct 2024 11:03:43 -0700

Dara Navaei joined DIALIN-DENBUG-280-1

DIALIN-DENBUG-280_Issues With HD Broadcast P1B

DIALIN-DENBUG-280-1: reviewers removed from DIALIN-DENBUG-280_Issues With HD Broadcast P1B

Thu, 31 Oct 2024 11:03:43 -0700

Dara Navaei removed Michael Garthwaite from DIALIN-DENBUG-280-1

DIALIN-DENBUG-280_Issues With HD Broadcast P1B

DIALIN-DENBUG-280-1: started by Dara Navaei

Dara Navaei — Thu, 31 Oct 2024 11:02:51 -0700

Dara Navaei started review DIALIN-DENBUG-280-1

DIALIN-DIAL-299-1: closed by Michael Garthwaite

Michael Garthwaite — Mon, 01 Jul 2024 10:16:48 -0700

Michael Garthwaite Closed DIALIN-DIAL-299-1

DIALIN-DIAL-299-1: comment by Michael Garthwaite "This CR should be closed due to bad branching. ..."

Michael Garthwaite — Mon, 01 Jul 2024 10:16:33 -0700

Michael Garthwaite commented on DIALIN-DIAL-299-1

This CR should be closed due to bad branching. Should have been branched out of p1_staging.

DIALIN-DIAL-299-1: started by Dara Navaei

Dara Navaei — Wed, 26 Jun 2024 12:01:20 -0700

Dara Navaei started review DIALIN-DIAL-299-1

DIALIN-DEN-8251-1: closed by plucia

plucia — Mon, 24 May 2021 13:13:39 -0700

plucia (deleted user) Closed DIALIN-DEN-8251-1

DIALIN-DEN-8251-1: reviewers finished

Mon, 24 May 2021 13:11:14 -0700

Sean Nash finished reviewing DIALIN-DEN-8251-1

DIALIN-DEN-8251_Sprint 44

DIALIN-DEN-8251-1: reviewers finished

Fri, 21 May 2021 16:38:43 -0700

qnguyen (deleted user) and pmontazemi (deleted user) finished reviewing DIALIN-DEN-8251-1

DIALIN-DEN-8251_Sprint 44

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Fri, 21 May 2021 16:37:31 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Fri, 21 May 2021 16:37:19 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Fri, 21 May 2021 16:36:40 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by plucia "If you select Edit Configuration -> "add conten..."

plucia — Fri, 21 May 2021 15:15:07 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

If you select Edit Configuration -> "add content roots" in PyCharm, it will automatically add /home/denali/Projects/dialin/ to your path before executing the script and there is no longer a need to append to the path in the script. I had selected this option and wasn't having issue running any script.
I've updated all the paths now to support execution from outside of PyCharm.

dialin (DEN-12358-sw_dev-sprint-67_mg): DEN-8251: Addressed code review comments

Fri, 21 May 2021 15:39:01 -0700

Peter Lucia committed 1508298 on branch Calibration_fixes, DEN-10206_BCuff_KnownBugs_OnlyPairWithOneBCuffAtATime and 221 more in dialin

DEN-8251: Addressed code review comments

· /tests/peter/test_blood_flow.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_calibration.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_can.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_data_logger.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_debug_text.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_demo.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_dg_thermistors.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_dg_valves.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_dg_valves_observer.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_fw_controller.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_gen_requirements.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_hd_dg_simulators.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_hd_fluid_leak.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_hd_reset.py

(-1, +1)

| History

| Source

| Diff

· /tests/peter/test_hd_simulator.py

(-1, +1)

| History

| Source

| Diff

… 7 more files in changeset.

DIALIN-DEN-8251-1: comment by plucia "Done"

plucia — Fri, 21 May 2021 15:16:11 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done

DIALIN-DEN-8251-1: comment by plucia "Done - just FYI I have added type hints in my S..."

plucia — Fri, 21 May 2021 15:18:06 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done - just FYI I have added type hints in my Sprint 45 branch for the dg classes. So it hasn't been updated almost everywhere inside the dg folder on this Sprint 44 branch

DIALIN-DEN-8251-1: comment by qnguyen "Will this path is enough to find dialin folder ..."

qnguyen — Fri, 21 May 2021 10:29:50 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Will this path is enough to find dialin folder since this has been moved into another folder?

DIALIN-DEN-8251-1: comment by qnguyen "This function and the one below needs to match ..."

qnguyen — Fri, 14 May 2021 10:50:16 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

This function and the one below needs to match the new style.

DIALIN-DEN-8251-1: comment by qnguyen "Change to return type to None and remove not ne..."

qnguyen — Fri, 14 May 2021 10:41:35 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Change to return type to None and remove not needed return 0 to keep consistency with other functions in this file.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Tue, 11 May 2021 13:46:15 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Tue, 11 May 2021 13:46:09 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by qnguyen "RESOLVED."

qnguyen — Tue, 11 May 2021 13:46:02 -0700

qnguyen (deleted user) replied to plucia (deleted user) in DIALIN-DEN-8251-1

RESOLVED.

DIALIN-DEN-8251-1: comment by plucia "Done"

plucia — Tue, 11 May 2021 12:17:27 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done

DIALIN-DEN-8251-1: comment by plucia "Done"

plucia — Tue, 11 May 2021 12:18:23 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done

DIALIN-DEN-8251-1: comment by plucia "Done"

plucia — Tue, 11 May 2021 12:19:08 -0700

plucia (deleted user) replied to qnguyen (deleted user) in DIALIN-DEN-8251-1

Done

DIALIN-DEN-8251-1: comment by qnguyen "Need file header."

qnguyen — Wed, 05 May 2021 23:08:38 -0700

qnguyen (deleted user) commented on DIALIN-DEN-8251-1

Need file header.