DIALIN-DIAL-299-1 DIALIN-DIAL-299_Air Trap Observer NO Longer Pub P1

closed on 01 Jul 24

Author

Moderator

Reviewers

DIALIN-DIAL-299_Air Trap Observer NO Longer Pub P1

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 196

dialin 0
- Folder dialin 0
  - Folder common 0
    - File alarm_defs.py 0 Remove
    - File alarm_priorities.py 0 Remove
    - File dg_defs.py 0 Remove
    - File hd_defs.py 0 Remove
    - File msg_defs.py 0 Remove
    - File msg_ids.py 0 Remove
    - File prs_defs.py 0 Remove
    - File test_config_defs.py 0 Remove
    - File ui_defs.py 0 Remove
  - Folder dg 0
    - File __init__.py 0 Remove
    - File accelerometer.py 0 Remove
    - File alarms.py 0 Remove
    - File calibration_record.py 0 Remove
    - File chemical_disinfect.py 0 Remove
    - File chemical_disinfect_flush.py 0 Remove
    - File concentrate_pumps.py 0 Remove
    - File conductivity_sensors.py 0 Remove
    - File constants.py 0 Remove
    - File cpld.py 0 Remove
    - File dg_test_configs.py 0 Remove
    - File dialysate_fill.py 0 Remove
    - File dialysate_generator.py 0 Remove
    - File drain.py 0 Remove
    - File drain_pump.py 0 Remove
    - File events.py 0 Remove
    - File fans.py 0 Remove
    - File flow_sensors.py 0 Remove
    - File fluid_leak.py 0 Remove
    - File flush.py 0 Remove
    - File gen_idle.py 0 Remove
    - File hd_proxy.py 0 Remove
    - File heat_disinfect.py 0 Remove
    - File heat_disinfect_active_cool.py 0 Remove
    - File heaters.py 0 Remove
    - File load_cells.py 0 Remove
    - File pressures.py 0 Remove
    - File reservoirs.py 0 Remove
    - File ro_permeate_sample.py 0 Remove
    - File ro_pump.py 0 Remove
    - File rtc.py 0 Remove
    - File samplewater.py 0 Remove
    - File scheduled_runs_record.py 0 Remove
    - File service_record.py 0 Remove
    - File sw_configs.py 0 Remove
    - File switches.py 0 Remove
    - File system_record.py 0 Remove
    - File temperatures.py 0 Remove
    - File thermistors.py 0 Remove
    - File usage_info_record.py 0 Remove
    - File uv_reactors.py 0 Remove
    - File valves.py 0 Remove
    - File voltages.py 0 Remove
    - File watchdog.py 0 Remove
  - Folder hd 0
    - File accelerometer.py 0 Remove
    - File air_bubbles.py 0 Remove
    - File air_pump.py 0 Remove
    - File air_trap.py 0 Remove
    - File alarms.py 0 Remove
    - File battery.py 0 Remove
    - File blood_flow.py 0 Remove
    - File blood_leak.py 0 Remove
    - File buttons.py 0 Remove
    - File calibration_record.py 0 Remove
    - File constants.py 0 Remove
    - File dg_proxy.py 0 Remove
    - File dialysate_inlet_flow.py 0 Remove
    - File dialysate_outlet_flow.py 0 Remove
    - File fans.py 0 Remove
    - File fluid_leak.py 0 Remove
    - File hd_events.py 0 Remove
    - File hd_test_configs.py 0 Remove
    - File hemodialysis_device.py 0 Remove
    - File institutional_record.py 0 Remove
    - File post_treatment.py 0 Remove
    - File pressure_occlusion.py 0 Remove
    - File pretreatment.py 0 Remove
    - File reservoirs.py 0 Remove
    - File rtc.py 0 Remove
    - File service_record.py 0 Remove
    - File sw_configs.py 0 Remove
    - File switches.py 0 Remove
    - File syringe_pump.py 0 Remove
    - File system_record.py 0 Remove
    - File temperatures.py 0 Remove
    - File treatment.py 0 Remove
    - File ui_proxy.py 0 Remove
    - File usage_info_record.py 0 Remove
    - File valves.py 0 Remove
    - File voltages.py 0 Remove
    - File watchdog.py 0 Remove
  - Folder protocols 0
    - File CAN.py 0 Remove
  - Folder ui 0
    - File crc.py 0 Remove
    - File dg_simulator.py 0 Remove
    - File hd_simulator.py 0 Remove
    - File hd_simulator_alarms.py 0 Remove
    - File messageBuilder.py 0 Remove
    - File unittests.py 0 Remove
    - File utils.py 0 Remove
  - Folder utils 0
    - File base.py 0 Remove
    - File checks.py 0 Remove
    - File conversions.py 0 Remove
    - File data_logger.py 0 Remove
    - File excel_ops.py 0 Remove
    - File helpers.py 0 Remove
    - File nv_ops_utils.py 0 Remove
    - File singleton.py 0 Remove
  - File version.py 0 Remove
- Folder docs/source 0
  - File conf.py 0 Remove
- Folder tests 0
  - Folder peter 0
    - File set_RTCs.py 0 Remove
    - File test_POST.py 0 Remove
    - File test_blood_flow.py 0 Remove
    - File test_can.py 0 Remove
    - File test_data_logger.py 0 Remove
    - File test_debug_text.py 0 Remove
    - File test_demo.py 0 Remove
    - File test_dg_records.py 0 Remove
    - File test_dg_thermistors.py 0 Remove
    - File test_dg_valves.py 0 Remove
    - File test_dg_valves_observer.py 0 Remove
    - File test_fw_controller.py 0 Remove
    - File test_gen_requirements.py 0 Remove
    - File test_hd_dg_simulators.py 0 Remove
    - File test_hd_fluid_leak.py 0 Remove
    - File test_hd_records.py 0 Remove
    - File test_hd_reset.py 0 Remove
    - File test_hd_simulator.py 0 Remove
    - File test_hd_valves.py 0 Remove
    - File test_listener.py 0 Remove
    - File test_logging.py 0 Remove
    - File test_print_version.py 0 Remove
    - File test_single_alarm.py 0 Remove
    - File test_temperature_sensors.py 0 Remove
    - File test_ui_proxy.py 0 Remove
  - Folder unit_tests 0
    - File run_all.sh 0 Remove
    - File test_constructors.py 0 Remove
    - File test_dg_temperature_sensors.py 0 Remove
    - File test_enums.py 0 Remove
    - File test_imports.py 0 Remove
    - File test_msg_ids.py 0 Remove
    - File test_ui_proxy.py 0 Remove
  - File DebugMsgCatcher.py 0 Remove
  - File air_trap_levels.py 0 Remove
  - File dg_hd_switches_test.py 0 Remove
  - File dg_heaters_test.py 0 Remove
  - File dg_nvm_scripts.py 0 Remove
  - File dg_tests.py 0 Remove
  - File dg_valves_test.py 0 Remove
  - File flow_sensor_data_processor.py 0 Remove
  - File hd_air_bubbles_data.py 0 Remove
  - File hd_blood_leak_data.py 0 Remove
  - File hd_fluid_leak_state.py 0 Remove
  - File hd_nvm_scripts.py 0 Remove
  - File hd_test_pumps_open_loop.py 0 Remove
  - File hd_valves_test.py 0 Remove
  - File set_accels_cal.py 0 Remove
  - File set_flow_sensors_cal.py 0 Remove
  - File test_alarms.py 0 Remove
  - File test_buttons.py 0 Remove
  - File test_can_xmit.py 0 Remove
  - File test_conductivity.py 0 Remove
  - File test_deprime.py 0 Remove
  - File test_dg_records.py 0 Remove
  - File test_dg_valves.py 0 Remove
  - File test_dialysate_flow_sensor.py 0 Remove
  - File test_flush.py 0 Remove
  - File test_hd.py 0 Remove
  - File test_hd_dg_fans.py 0 Remove
  - File test_hd_records.py 0 Remove
  - File test_hd_valves.py 0 Remove
  - File test_heparin.py 0 Remove
  - File test_heprin_bolus_target_rate.py 0 Remove
  - File test_lc.py 0 Remove
  - File test_nelson_labs_disinfect.py 0 Remove
  - File test_saline_bolus.py 0 Remove
  - File test_syringe.py 0 Remove
  - File test_tx_config_tests.py 0 Remove
  - File test_uf.py 0 Remove
  - File test_uv_reactors.py 0 Remove
  - File test_voltages.py 0 Remove
- Folder tools 0
  - File Code_Report.csv 0 Remove
  - File bring_can_interface_down.sh 0 Remove
  - File build_readme_pdf.sh 0 Remove
  - File cr_objectives.sh 0 Remove
  - File document.sh 0 Remove
  - File gen_common_defs.sh 0 Remove
  - File install_to_venv.sh 0 Remove
  - File run_reset_hd.sh 0 Remove
  - File run_static_code_analysis.sh 0 Remove
  - File run_unit_tests.sh 0 Remove
  - File setup_canbus.sh 0 Remove
  - File setup_environment.sh 0 Remove
  - File setup_virtual_can.sh 0 Remove
  - File start_env.sh 0 Remove
- File README.md 0 Remove
- File build.sh 0 Remove
- File setup.py 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Michael Garthwaite	Author & Moderator	0m	1	This CR should be closed due to bad branching. Should hav...
Sean Nash	Reviewer - 0% reviewed
Dara Navaei	Reviewer - 0% reviewed
Behrouz NematiPour	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - 0% reviewed
jpaguio (deleted user)	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 0% reviewed
Total		0m	1

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Michael Garthwaite

This CR should be closed due to bad branching. Should have been branched out ...

This CR should be closed due to bad branching. Should have been branched out of p1_staging.

01 Jul 24

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

DIALIN-DIAL-299-1

DIALIN-DIAL-299_Air Trap Observer NO Longer Pub P1

DIALIN-DIAL-299-1 1

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Michael Garthwaite

Log time

DIALIN-DIAL-299_Air Trap Observer NO Longer Pub P1

DIALIN-DIAL-299-1 1

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Michael Garthwaite

Log time