Fisheye on dialin/tests/test_hd_valves.py

DIALIN-DENBUG-280-4: closed by Michael Garthwaite

Michael Garthwaite — Wed, 06 Nov 2024 15:20:04 -0800

Michael Garthwaite Closed DIALIN-DENBUG-280-4

DIALIN-DENBUG-280-1: closed by Michael Garthwaite

Michael Garthwaite — Wed, 06 Nov 2024 15:19:54 -0800

Michael Garthwaite Closed DIALIN-DENBUG-280-1

DIALIN-DENBUG-280-4: reviewers finished

Mon, 04 Nov 2024 10:29:29 -0800

Sean Nash finished reviewing DIALIN-DENBUG-280-4

DIALIN-DENBUG-280_Issues With HD Broadcast P1

DIALIN-DENBUG-280-4: started by Dara Navaei

Dara Navaei — Sat, 02 Nov 2024 16:01:22 -0700

Dara Navaei started review DIALIN-DENBUG-280-4

DIALIN-DENBUG-280-1: reviewers joined DIALIN-DENBUG-280_Issues With HD Broadcast P1B

Thu, 31 Oct 2024 11:03:43 -0700

Dara Navaei joined DIALIN-DENBUG-280-1

DIALIN-DENBUG-280_Issues With HD Broadcast P1B

DIALIN-DENBUG-280-1: reviewers removed from DIALIN-DENBUG-280_Issues With HD Broadcast P1B

Thu, 31 Oct 2024 11:03:43 -0700

Dara Navaei removed Michael Garthwaite from DIALIN-DENBUG-280-1

DIALIN-DENBUG-280_Issues With HD Broadcast P1B

DIALIN-DENBUG-280-1: started by Dara Navaei

Dara Navaei — Thu, 31 Oct 2024 11:02:51 -0700

Dara Navaei started review DIALIN-DENBUG-280-1

DIALIN-DIAL-299-1: closed by Michael Garthwaite

Michael Garthwaite — Mon, 01 Jul 2024 10:16:48 -0700

Michael Garthwaite Closed DIALIN-DIAL-299-1

DIALIN-DIAL-299-1: comment by Michael Garthwaite "This CR should be closed due to bad branching. ..."

Michael Garthwaite — Mon, 01 Jul 2024 10:16:33 -0700

Michael Garthwaite commented on DIALIN-DIAL-299-1

This CR should be closed due to bad branching. Should have been branched out of p1_staging.

DIALIN-DIAL-299-1: started by Dara Navaei

Dara Navaei — Wed, 26 Jun 2024 12:01:20 -0700

Dara Navaei started review DIALIN-DIAL-299-1

DIALIN-DEN-15199-1: closed by Dara Navaei

Dara Navaei — Wed, 26 Apr 2023 15:01:50 -0700

Dara Navaei Closed DIALIN-DEN-15199-1

DIALIN-DEN-15199-1: reviewers finished

Wed, 26 Apr 2023 15:00:05 -0700

Michael Garthwaite and Sean Nash finished reviewing DIALIN-DEN-15199-1

DIALIN-DEN-15199_FW DN Sprint

DIALIN-DEN-15199-1: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Wed, 26 Apr 2023 11:04:05 -0700

Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-15199-1

RESOLVED.

DIALIN-DEN-15199-1: comment by Dara Navaei "This is here is because when they request the c..."

Dara Navaei — Wed, 26 Apr 2023 10:24:58 -0700

Dara Navaei replied to Michael Garthwaite in DIALIN-DEN-15199-1

This is here is because when they request the configs I set the dictionary to reset mode until the new values have been received from the firmware and then the dictionary is updated with the firmware values. Thanks I moved it to only execute it if the message was received successfully.

DIALIN-DEN-15199-1: comment by Michael Garthwaite "Shouldnt this reset be in cmd_reset_all_test_co..."

Michael Garthwaite — Wed, 26 Apr 2023 10:18:29 -0700

Michael Garthwaite commented on DIALIN-DEN-15199-1

Shouldnt this reset be in cmd_reset_all_test_configs()? It should also be executed after a successful message.

DIALIN-DEN-15199-1: comment by Sean Nash "RESOLVED."

Sean Nash — Wed, 26 Apr 2023 09:26:25 -0700

Sean Nash replied to Dara Navaei in DIALIN-DEN-15199-1

RESOLVED.

DIALIN-DEN-15199-1: comment by Sean Nash "RESOLVED."

Sean Nash — Wed, 26 Apr 2023 09:26:11 -0700

Sean Nash replied to Dara Navaei in DIALIN-DEN-15199-1

RESOLVED.

DIALIN-DEN-15199-1: comment by Sean Nash "RESOLVED."

Sean Nash — Wed, 26 Apr 2023 09:26:01 -0700

Sean Nash replied to Dara Navaei in DIALIN-DEN-15199-1

RESOLVED.

DIALIN-DEN-15199-1: comment by Dara Navaei "The file header will be added upon the staging ..."

Dara Navaei — Wed, 26 Apr 2023 09:08:25 -0700

Dara Navaei replied to Sean Nash in DIALIN-DEN-15199-1

The file header will be added upon the staging build.

DIALIN-DEN-15199-1: comment by Dara Navaei "The file heater will be added automatically in ..."

Dara Navaei — Wed, 26 Apr 2023 09:08:05 -0700

Dara Navaei replied to Sean Nash in DIALIN-DEN-15199-1

The file heater will be added automatically in upon the staging build.

DIALIN-DEN-15199-1: comment by Dara Navaei "This will be updated once we move to HD."

Dara Navaei — Wed, 26 Apr 2023 09:07:40 -0700

Dara Navaei replied to Sean Nash in DIALIN-DEN-15199-1

This will be updated once we move to HD.

DIALIN-DEN-15199-1: comment by Sean Nash "Add file header"

Sean Nash — Wed, 26 Apr 2023 08:23:12 -0700

Sean Nash commented on DIALIN-DEN-15199-1

Add file header

DIALIN-DEN-15199-1: comment by Sean Nash "Add file header"

Sean Nash — Wed, 26 Apr 2023 08:22:53 -0700

Sean Nash commented on DIALIN-DEN-15199-1

Add file header

DIALIN-DEN-15199-1: comment by Sean Nash "???"

Sean Nash — Wed, 26 Apr 2023 08:22:24 -0700

Sean Nash commented on DIALIN-DEN-15199-1

???

DIALIN-DEN-15199-1: started by Dara Navaei

Dara Navaei — Thu, 20 Apr 2023 16:01:48 -0700

Dara Navaei started review DIALIN-DEN-15199-1

dialin (DEN-12358-sw_dev-sprint-67_mg): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 20 Jun 2022 20:26:13 -0700

Dara Navaei committed 7ea4b93 on branch DEN-12358-sw_dev-sprint-67_mg, DEN-12931-dg_hd_dev-hd_dg_dvt-update and 185 more in dialin

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /dialin/common/dg_defs.py

(-2, +2)

| History

| Source

| Diff

· /dialin/common/hd_defs.py

(-2, +2)

| History

| Source

| Diff

· /dialin/common/msg_ids.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/chemical_disinfect.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/concentrate_pumps.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/conductivity_sensors.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/dialysate_generator.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/fans.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/flush.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/heaters.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/pressures.py

(-2, +2)

| History

| Source

| Diff

· /dialin/dg/sw_configs.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/switches.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/system_record.py

(-1, +1)

| History

| Source

| Diff

· /dialin/dg/usage_info_record.py

(-3, +3)

| History

| Source

| Diff

… 20 more files in changeset.

DIALIN-DEN-12224-1: closed by Dara Navaei

Dara Navaei — Mon, 20 Jun 2022 20:25:07 -0700

Dara Navaei Closed DIALIN-DEN-12224-1

DIALIN-DEN-12224-1: reviewers finished

Mon, 20 Jun 2022 20:21:00 -0700

Behrouz NematiPour and Michael Garthwaite finished reviewing DIALIN-DEN-12224-1

DIALIN-DEN-12224_DG HD Dev Switches Monitor

DIALIN-DEN-12224-1: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Mon, 20 Jun 2022 14:00:13 -0700

Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-12224-1

RESOLVED.

DIALIN-DEN-12224-1: comment by Michael Garthwaite "RESOLVED."

Michael Garthwaite — Mon, 20 Jun 2022 14:00:03 -0700

Michael Garthwaite replied to Dara Navaei in DIALIN-DEN-12224-1

RESOLVED.