Fisheye on application/sources/model/settings/MSettings.cpp

UI-LEAH-1924-3: closed by Dara Navaei

Dara Navaei — Tue, 19 Nov 2024 15:28:09 -0800

Dara Navaei Closed UI-LEAH-1924-3

UI-LEAH-1924-3: reviewers finished

Tue, 19 Nov 2024 14:31:29 -0800

Dara Navaei and Behrouz NematiPour finished reviewing UI-LEAH-1924-3

UI-LEAH-1924_Leahi/Features/Leah 1924 UI AM S4 Translation

UI-LEAH-1924-3: started by Dara Navaei

Dara Navaei — Mon, 18 Nov 2024 11:37:55 -0800

Dara Navaei started review UI-LEAH-1924-3

UI-DEN-15435-1: closed by Behrouz NematiPour

Behrouz NematiPour — Thu, 01 Jun 2023 15:46:00 -0700

Behrouz NematiPour Closed UI-DEN-15435-1

UI-DEN-15435-1: reviewers finished

Wed, 31 May 2023 10:54:24 -0700

jishii (deleted user) and Tiffany Mejia finished reviewing UI-DEN-15435-1

UI-DEN-15435_UI BN S98 Usability - [Ready]

UI-DEN-15435-1: started by Dara Navaei

Dara Navaei — Fri, 26 May 2023 20:01:47 -0700

Dara Navaei started review UI-DEN-15435-1

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 04 Jan 2023 16:48:39 -0800

Dara Navaei committed c9f8f8c on branch master, @Environement_Swith and 181 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /alarmMapping.sh

(-1, +1)

| History

| Source

| Diff

· /cppcheck.sh

(-2, +2)

| History

| Source

| Diff

· /cr_objectives.sh

(-1, +1)

| History

| Source

| Diff

· /imake.sh

(-1, +1)

| History

| Source

| Diff

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /remove-exra-emptylines.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/autostart

(-2, +2)

| History

| Source

| Diff

· /scripts/bluetooth_paired_clear.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/bluetooth_paired_query.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/brightness_get.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/brightness_set.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/date_time_set.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/export_logs.sh

(-1, +1)

| History

| Source

| Diff

· /scripts/globals.sh

(-3, +4)

| History

| Source

| Diff

· /scripts/run.sh

(-3, +3)

| History

| Source

| Diff

… 594 more files in changeset.

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Mon, 24 Oct 2022 09:51:37 -0700

Dara Navaei committed e961fc7 on branch master, @Environement_Swith and 188 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /cppcheck.sh

(-1, +1)

| History

| Source

| Diff

· /imake.sh

(-3, +3)

| History

| Source

| Diff

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationController.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/bluetooth/BluetoothInterface.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageDispatcher.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageDispatcher.h

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageInterpreter.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageInterpreter.h

(-1, +1)

| History

| Source

| Diff

· /sources/cloudsync/CloudSyncController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/device/DeviceController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/gui/GuiController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/gui/GuiController.h

(-1, +1)

| History

| Source

| Diff

… 32 more files in changeset.

UI-DEN-13965-3: closed by Behrouz NematiPour

Behrouz NematiPour — Fri, 21 Oct 2022 04:13:28 -0700

Behrouz NematiPour Closed UI-DEN-13965-3

UI-DEN-13965-3: reviewers finished

Tue, 11 Oct 2022 11:45:19 -0700

Tiffany Mejia and jishii (deleted user) finished reviewing UI-DEN-13965-3

UI-DEN-13965_UI BN S81

UI-DEN-13965-3: reviewers finished

Mon, 10 Oct 2022 17:30:10 -0700

Sean Nash finished reviewing UI-DEN-13965-3

UI-DEN-13965_UI BN S81

UI-DEN-13965-3: started by Dara Navaei

Dara Navaei — Thu, 06 Oct 2022 20:27:55 -0700

Dara Navaei started review UI-DEN-13965-3

application (bugfix/DEN-16597-UI-BN-S114): DEN-13965: UI/HD Generic User Confirmation [Message Mapping]]...

Behrouz NematiPour — Wed, 05 Oct 2022 19:08:07 -0700

Behrouz NematiPour committed 40c0995 on branch master, @Environement_Swith and 191 more in application

DEN-13965: UI/HD Generic User Confirmation [Message Mapping]]

- Fixed the issue with the kyeValue of different categories overwriting by adding the category as the top level.

- I still have issue in saving for the settings, which writes duplicate.

· /denali.pro.user	(-1, +1)	\| History	\| Source	\| Diff
· /sources/canbus/MessageInterpreter.cpp	(-3, +6)	\| History	\| Source	\| Diff
· /sources/model/hd/alarm/MAlarmMapping.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/model/settings/MSettings.cpp	(-54, +37)	\| History	\| Source	\| Diff
· /sources/model/settings/MSettings.h	(-17, +36)	\| History	\| Source	\| Diff
· /sources/storage/Settings.cpp	(-5, +10)	\| History	\| Source	\| Diff
· /sources/storage/StorageGlobals.cpp	(-0, +1)	\| History	\| Source	\| Diff
· /sources/storage/StorageGlobals.h	(-0, +1)	\| History	\| Source	\| Diff
· /sources/storage/TreatmentLog.cpp	(-5, +6)	\| History	\| Source	\| Diff
· /sources/view/VTreatmentCreate.cpp	(-4, +5)	\| History	\| Source	\| Diff
· /sources/view/hd/alarm/VAlarmStatus.cpp	(-29, +25)	\| History	\| Source	\| Diff
· /sources/view/settings/VSettings.cpp	(-7, +7)	\| History	\| Source	\| Diff

application (bugfix/DEN-16597-UI-BN-S114): Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Dara Navaei — Wed, 28 Sep 2022 16:41:05 -0700

Dara Navaei committed 265ce74 on branch master, @Environement_Swith and 191 more in application

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

· /main.cpp

(-1, +1)

| History

| Source

| Diff

· /scripts/run.sh

(-1, +1)

| History

| Source

| Diff

· /sources/AlarmGenerator.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/AlarmGenerator.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationController.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationController.h

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/ApplicationPost.h

(-1, +1)

| History

| Source

| Diff

· /sources/MainTimer.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/Threads.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/Threads.h

(-1, +1)

| History

| Source

| Diff

· /sources/bluetooth/BluetoothInterface.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/FrameInterface.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageDispatcher.cpp

(-1, +1)

| History

| Source

| Diff

· /sources/canbus/MessageDispatcher.h

(-1, +1)

| History

| Source

| Diff

… 81 more files in changeset.

UI-DEN-13198-1: closed by Behrouz NematiPour

Behrouz NematiPour — Wed, 28 Sep 2022 16:26:44 -0700

Behrouz NematiPour Closed UI-DEN-13198-1

UI-DEN-13198-1: reviewers finished

Mon, 26 Sep 2022 08:13:58 -0700

Tiffany Mejia finished reviewing UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1: comment by jishii "RESOLVED"

jishii — Mon, 26 Sep 2022 07:47:23 -0700

jishii (deleted user) replied to Behrouz NematiPour in UI-DEN-13198-1

RESOLVED

UI-DEN-13198-1: comment by jishii "RESOLVED"

jishii — Mon, 26 Sep 2022 07:47:06 -0700

jishii (deleted user) replied to Behrouz NematiPour in UI-DEN-13198-1

RESOLVED

UI-DEN-13198-1: comment by Behrouz NematiPour "A bug has been created for that. I need to wor..."

Behrouz NematiPour — Sun, 25 Sep 2022 21:56:56 -0700

Behrouz NematiPour replied to jishii (deleted user) in UI-DEN-13198-1

A bug has been created for that.
I need to work on it and test it.
Please resolve and will follow up under the bug: DEN-14006

UI-DEN-13198-1: comment by Behrouz NematiPour "A bug has been created for that. I need to wor..."

Behrouz NematiPour — Sun, 25 Sep 2022 21:56:26 -0700

Behrouz NematiPour replied to jishii (deleted user) in UI-DEN-13198-1

A bug has been created for that.
I need to work on it and test it.
Please resolve and will follow up under the bug: DEN-14006

UI-DEN-13198-1: reviewers finished

Fri, 23 Sep 2022 09:16:17 -0700

jishii (deleted user) finished reviewing UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1: comment by jishii "Missing square brackets around equality check"

jishii — Mon, 19 Sep 2022 15:58:13 -0700

jishii (deleted user) commented on UI-DEN-13198-1

Missing square brackets around equality check

UI-DEN-13198-1: comment by jishii "During installation last week was having issues..."

jishii — Mon, 19 Sep 2022 15:55:33 -0700

jishii (deleted user) commented on UI-DEN-13198-1

During installation last week was having issues where this check seems to be looking for $CLOUDSYNC_FOLDER in root directory, whereas instructions say to install cloudsync folder in home directory, if I'm understanding correctly the condition should be $HOME$CLOUDSYNC_FOLDER

UI-DEN-13198-1: reviewers added to UI-DEN-13198_UI BN 75

Mon, 19 Sep 2022 14:12:04 -0700

Dara Navaei added jishii (deleted user) to UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1: reviewers finished

Fri, 16 Sep 2022 10:12:01 -0700

Sean Nash finished reviewing UI-DEN-13198-1

UI-DEN-13198_UI BN 75

UI-DEN-13198-1: started by Dara Navaei

Dara Navaei — Thu, 08 Sep 2022 18:05:58 -0700

Dara Navaei started review UI-DEN-13198-1

UI-DEN-12716-2: closed by Behrouz NematiPour

Behrouz NematiPour — Thu, 08 Sep 2022 15:32:53 -0700

Behrouz NematiPour Closed UI-DEN-12716-2

UI-DEN-12716-2: reviewers finished

Thu, 08 Sep 2022 15:30:57 -0700

Tiffany Mejia finished reviewing UI-DEN-12716-2

UI-DEN-12716_UI BN S70

UI-DEN-12716-2: reviewers finished

Tue, 06 Sep 2022 11:20:55 -0700

Michael Garthwaite finished reviewing UI-DEN-12716-2

UI-DEN-12716_UI BN S70

application (bugfix/DEN-16597-UI-BN-S114): DEN-13645: IMP: Unhandled messages duplicate keys fix...

Behrouz NematiPour — Mon, 15 Aug 2022 20:47:30 -0700

Behrouz NematiPour committed 35db011 on branch master, @Environement_Swith and 192 more in application

DEN-13645: IMP: Unhandled messages duplicate keys fix

- it has been observed that the unhandled messages are not logged correctly and turned out it is because of the Types of each parameter used as keys and keys can't be duplicate by default which caused issue for the unhandled messages, since they may have 6 parameter and all with F32 type which then becomes one parameter of type F32.

- an attribute has been defined for the config file with the format:

#--duplicate_key_on

#--duplicate_key_off

to allow or disallow the duplicate key at any point in the config file.

- Note that the save config parameters are always unique key like AlarmVolume which doesn't make sense to have duplicate entry.

· /AlarmMapping.csv	(-4, +4)	\| History	\| Source	\| Diff
· /denali.pro.user	(-1, +1)	\| History	\| Source	\| Diff
· /sources/canbus/MessageInterpreter.cpp	(-1, +1)	\| History	\| Source	\| Diff
· /sources/gui/qml/pages/disinfect/DisinfectStack.qml	(-1, +1)	\| History	\| Source	\| Diff
· /sources/model/hd/alarm/MAlarmMapping.cpp	(-5, +5)	\| History	\| Source	\| Diff
· /sources/model/settings/MSettings.cpp	(-6, +11)	\| History	\| Source	\| Diff
· /sources/model/settings/MSettings.h	(-1, +1)	\| History	\| Source	\| Diff
· /sources/storage/Settings.cpp	(-10, +40)	\| History	\| Source	\| Diff
· /sources/storage/Settings.h	(-2, +5)	\| History	\| Source	\| Diff
· /sources/view/hd/adjustment/disinfect/VDisinfectAdjustDisinfect.h	(-0, +2)	\| History	\| Source	\| Diff